CSL-9543: Fix RPC failure issue #22805
Open
+23
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| cfg.PrimaryDatacenter = runtimeCfg.PrimaryDatacenter | ||
| cfg.DataDir = runtimeCfg.DataDir | ||
| cfg.NodeName = runtimeCfg.NodeName | ||
| cfg.NodeName = string(runtimeCfg.NodeID) |
There was a problem hiding this comment.
I suggest not to change the NodeName. Please share the justification for overriding the NodeName with NodeId.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reaping a stale Raft peer entry with an IP exact to current leader causes RPCs to fail.
This PR fixes the RPC error by registereing the node with the node id. Registering the node with node id will prevent the consul to consider the node renamed as a new one, in this PR we take the name as metadata for the node instead of taking it for unique name.
For more details advantages and drawbacks please look in to comments at https://hashicorp.atlassian.net/browse/CSL-9543