-
Notifications
You must be signed in to change notification settings - Fork 50
AdvancedTable column reorder docs #3133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
||
### Sortable Advanced Table | ||
|
||
!!! Insight |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is no longer the case
|
||
!!! Info | ||
|
||
Resizable columns are not supported in instances of the Advanced Table that have nested rows. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resizable columns are not supported in instances of the Advanced Table that have nested rows. | |
Reorderable columns are not supported in instances of the Advanced Table that have nested rows. |
</Hds::AdvancedTable> | ||
``` | ||
|
||
### Reorderable columns |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Suggestion] Do we want to add a code example for this section showing reorderable columns?
Resizable columns are not supported in instances of the Advanced Table that have nested rows. | ||
!!! | ||
|
||
Set the `@hasReorderableColumns` argument to `true` in order to make columns reorderable either by clicking and dragging on the column reorder handle, or by moving focus to the handle and using the right and left arrow keys. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Suggestion] Somewhere in this section we should mention the "move to start" and "move to end" actions are added to the context menu.
website/docs/components/table/advanced-table/partials/guidelines/guidelines.md
Outdated
Show resolved
Hide resolved
website/docs/components/table/advanced-table/partials/guidelines/guidelines.md
Show resolved
Hide resolved
5462d19
to
eee4fad
Compare
4528f35
to
4dbdd1c
Compare
Closed in favor of #3194 - Git got complicated |
📌 Summary
If merged, this PR adds eng docs for the advanced table column reorder feature.
🔗 External links
Jira ticket: HDS-XXX
Figma file: [if it applies]
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.