Skip to content

Conversation

zamoore
Copy link
Contributor

@zamoore zamoore commented Aug 28, 2025

📌 Summary

If merged, this PR adds eng docs for the advanced table column reorder feature.

🔗 External links

Jira ticket: HDS-XXX
Figma file: [if it applies]


👀 Component checklist

💬 Please consider using conventional comments when reviewing this PR.

📋 PCI review checklist
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've worked with GRC to document the impact of any changes to security controls.
    Examples of changes to controls include access controls, encryption, logging, etc.
  • If applicable, I've worked with GRC to ensure compliance due to a significant change to the in-scope PCI environment.
    Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.

@zamoore zamoore requested review from a team as code owners August 28, 2025 02:15
Copy link

vercel bot commented Aug 28, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
hds-showcase Error Error Sep 16, 2025 10:16pm
hds-website Error Error Sep 16, 2025 10:16pm

@hashibot-hds hashibot-hds added packages/components docs-website Content updates to the documentation website showcase labels Aug 28, 2025
@zamoore zamoore changed the base branch from main to zamoore/AdvancedTable/column-reordering-2 August 28, 2025 02:21
@zamoore zamoore changed the base branch from zamoore/AdvancedTable/column-reordering-2 to jt/advanced-table-reordering-docs August 28, 2025 02:21
@zamoore zamoore changed the base branch from jt/advanced-table-reordering-docs to zamoore/AdvancedTable/column-reordering-2 August 28, 2025 02:21

### Sortable Advanced Table

!!! Insight
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is no longer the case


!!! Info

Resizable columns are not supported in instances of the Advanced Table that have nested rows.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Resizable columns are not supported in instances of the Advanced Table that have nested rows.
Reorderable columns are not supported in instances of the Advanced Table that have nested rows.

</Hds::AdvancedTable>
```

### Reorderable columns
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Suggestion] Do we want to add a code example for this section showing reorderable columns?

Resizable columns are not supported in instances of the Advanced Table that have nested rows.
!!!

Set the `@hasReorderableColumns` argument to `true` in order to make columns reorderable either by clicking and dragging on the column reorder handle, or by moving focus to the handle and using the right and left arrow keys.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Suggestion] Somewhere in this section we should mention the "move to start" and "move to end" actions are added to the context menu.

@zamoore zamoore force-pushed the zamoore/AdvancedTable/column-reordering-2 branch from 5462d19 to eee4fad Compare September 8, 2025 16:59
Base automatically changed from zamoore/AdvancedTable/column-reordering-2 to main September 15, 2025 15:49
@zamoore
Copy link
Contributor Author

zamoore commented Sep 16, 2025

Closed in favor of #3194 - Git got complicated

@zamoore zamoore closed this Sep 16, 2025
@zamoore zamoore deleted the zamoore/AdvancedTable/column-reordering-2__docs branch September 16, 2025 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-website Content updates to the documentation website packages/components showcase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants