Showcase GTS conversion - ApplicationState #3175
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
zamoore
changed the title
aklkv
reviewed
Sep 13, 2025
showcase/app/components/page-components/application-state/index.gts
Outdated
Show resolved
Hide resolved
zamoore
force-pushed
the
zamoore/HDS-5329/convert-application-state-page-to-gts
branch
from
db33499 to
5b3e743
Compare
zamoore
force-pushed
the
zamoore/HDS-5329/convert-application-state-page-to-gts
branch
from
5b3e743 to
9ad4224
Compare
aklkv
reviewed
Sep 15, 2025
...ase/app/components/page-components/application-state/code-fragments/with-action-variants.gts
Outdated
Show resolved
Hide resolved
zamoore
force-pushed
the
zamoore/HDS-5329/convert-application-state-page-to-gts
branch
from
9ad4224 to
7451824
Compare
zamoore
force-pushed
the
zamoore/HDS-5329/convert-application-state-page-to-gts
branch
from
62ff389 to
51adda6
Compare
didoo
reviewed
Sep 23, 2025
| titleTag?: HdsApplicationStateHeaderSignature['Args']['titleTag']; | ||
| titleText?: string; | ||
| }; | ||
| Element: HdsApplicationStateSignature['Element']; |
There was a problem hiding this comment.
[note] technically this is not necessary, since we're not spreading the ...attributes operator
Comment on lines
+11
to
+15
| interface CodeFragmentWithGenericContentSignature { | ||
| Element: HdsApplicationStateSignature['Element']; | ||
| } | ||
|
|
||
| const CodeFragmentWithGenericContent: TemplateOnlyComponent<CodeFragmentWithGenericContentSignature> = |
There was a problem hiding this comment.
Suggested change
| interface CodeFragmentWithGenericContentSignature { | |
| Element: HdsApplicationStateSignature['Element']; | |
| } | |
| const CodeFragmentWithGenericContent: TemplateOnlyComponent<CodeFragmentWithGenericContentSignature> = | |
| const CodeFragmentWithGenericContent: TemplateOnlyComponent = |
| hasSecondaryAction?: boolean; | ||
| hasStandaloneLink?: boolean; | ||
| }; | ||
| Element: HdsApplicationStateSignature['Element']; |
There was a problem hiding this comment.
[note] technically this is not necessary, since we're not spreading the ...attributes operator
| <SF.Item @label="{{align}} aligned"> | ||
| <CodeFragmentWithErrorContent | ||
| @actions={{array "standaloneLink"}} | ||
| @align={{align}} |
There was a problem hiding this comment.
I see it now at line 126, should this be resolved?
|
|
||
| // Overrides necessary to simulate minimized behavior | ||
| .showcase-app.frameless { | ||
| .hds-side-nav, |
There was a problem hiding this comment.
[issue] I suspect this was part of another PR (related to the removal of the SideNav component for v5.0) and sneaked into this one.
| $tx: 0; | ||
| $ty: ($stack - 1) * 5px; | ||
| $tz: ($stack * 20px); | ||
| transform: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
If merged, this PR converts the ApplicationState showcase page to gts components.
📓 Notes
There is a small Percy diff, but it's just due to making a couple of examples have the same link text as other examples in their section for the sake of brevity.
🔗 External links
Jira ticket: HDS-5329
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.