-
Notifications
You must be signed in to change notification settings - Fork 51
Remove unneeded sass-related dependencies #3206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main-5.0.0
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a changeset is needed for this, no?
@didoo What's the format for a changeset for a global change? |
No need for |
81d8152
to
8c88fcd
Compare
7e5c422
to
62461e6
Compare
--- | ||
|
||
- Removed `sass` and `ember-cli-sass` as dependencies | ||
- Added `sass` as a dev-dependency |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We generally don't surface our devDependencies
to consumers. On all major changes we tend to offer brief but useful guidance on how to overcome the potential impact of these changes.
For example:
Removed `sass` and `ember-cli-sass` dependencies. Consumers using `sass` in their projects should make sure it's added as a direct dependency to their project.
|
π Summary
If merged, this PR:
sass
andember-cli-sass
as dependencies of the components packagesass
as a dev dependency.π οΈ Detailed description
ember-cli-sass
andsass
are no-longer required as dependencies for our components package.sass
is required, but only as a dev dependency.π External links
Jira ticket: HDS-4518
π Component checklist
π¬ Please consider using conventional comments when reviewing this PR.
π PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.