Skip to content

Conversation

zamoore
Copy link
Contributor

@zamoore zamoore commented Sep 18, 2025

πŸ“Œ Summary

If merged, this PR:

  • Removed sass and ember-cli-sass as dependencies of the components package
  • Adds sass as a dev dependency.

πŸ› οΈ Detailed description

ember-cli-sass and sass are no-longer required as dependencies for our components package. sass is required, but only as a dev dependency.

πŸ”— External links

Jira ticket: HDS-4518


πŸ‘€ Component checklist

πŸ’¬ Please consider using conventional comments when reviewing this PR.

πŸ“‹ PCI review checklist
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've worked with GRC to document the impact of any changes to security controls.
    Examples of changes to controls include access controls, encryption, logging, etc.
  • If applicable, I've worked with GRC to ensure compliance due to a significant change to the in-scope PCI environment.
    Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.

Copy link

vercel bot commented Sep 18, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
hds-showcase Ready Ready Preview Sep 24, 2025 8:08pm
hds-website Ready Ready Preview Sep 24, 2025 8:08pm

@zamoore zamoore changed the base branch from main to main-5.0.0 September 18, 2025 19:43
@zamoore zamoore marked this pull request as ready for review September 18, 2025 19:43
@zamoore zamoore requested a review from a team as a code owner September 18, 2025 19:43
Copy link
Contributor

@didoo didoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a changeset is needed for this, no?

@zamoore
Copy link
Contributor Author

zamoore commented Sep 19, 2025

I think a changeset is needed for this, no?

@didoo What's the format for a changeset for a global change?

@didoo
Copy link
Contributor

didoo commented Sep 19, 2025

I think a changeset is needed for this, no?

@didoo What's the format for a changeset for a global change?

No need for start/stop "tags", just plain text. https://hashicorp.atlassian.net/wiki/spaces/HDS/pages/3243114706/Changelog+authoring+best+practices#When-to-not-add-parsing-comments

@zamoore zamoore force-pushed the main-5.0.0 branch 9 times, most recently from 81d8152 to 8c88fcd Compare September 24, 2025 18:29
---

- Removed `sass` and `ember-cli-sass` as dependencies
- Added `sass` as a dev-dependency
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We generally don't surface our devDependencies to consumers. On all major changes we tend to offer brief but useful guidance on how to overcome the potential impact of these changes.
For example:

Removed `sass` and `ember-cli-sass` dependencies. Consumers using `sass` in their projects should make sure it's added as a direct dependency to their project.

@alex-ju
Copy link
Member

alex-ju commented Sep 25, 2025

embroider-optimized scenario seems to be failing on this PR – can you check to see if it's a flake or something that needs addressing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants