-
Notifications
You must be signed in to change notification settings - Fork 26
feat: use v2 api docs template for hvd api docs #2855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
π¦ Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action π€ New Page AddedThe following page was added to the bundle from the code in this PR:
|
} | ||
|
||
/** | ||
* Get static paths, using the configured `schemaSource`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Repeated comment here from above, should say "get static props"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good- links work, and like you mentioned it does work like /hcp/api-docs/vault-secrets. Some of the responsive design is weird with the @media css rules (assumption) but that's outside the scope of this for sure
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes 1 out of 2 committers have signed the CLA.
Have you signed the CLA already but the status is still pending? Recheck it. |
π Relevant links
ποΈ What
This PR adds api docs for hvd. The docs will live at
/hcp/api-docs/vault
. Since these api docs are large and often cause peoples web browsers to stall, we switched to using the v2 api docs template which splits up each endpoint into parts. This PR is basically a copy/paste of the vault-secrets api docs but with the info switched out for hvd.πΈ Design Screenshots
π§ͺ Testing