Skip to content

Conversation

LeahMarieBush
Copy link
Contributor

@LeahMarieBush LeahMarieBush commented Sep 26, 2025

πŸ”— Relevant links

πŸ—’οΈ What

This PR adds api docs for hvd. The docs will live at /hcp/api-docs/vault. Since these api docs are large and often cause peoples web browsers to stall, we switched to using the v2 api docs template which splits up each endpoint into parts. This PR is basically a copy/paste of the vault-secrets api docs but with the info switched out for hvd.

πŸ“Έ Design Screenshots

Screenshot 2025-09-26 at 11 23 12β€―AM

πŸ§ͺ Testing

  1. Go to preview
  2. Click into various endpoints for this section and verify nothing breaks

Copy link

vercel bot commented Sep 26, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
dev-portal Ready Ready Preview Comment Sep 30, 2025 6:32pm

Copy link

github-actions bot commented Sep 26, 2025

πŸ“¦ Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action πŸ€–

New Page Added

The following page was added to the bundle from the code in this PR:

Page Size (compressed) First Load
/hcp/api-docs/vault/[[...page]] 155.23Β KB 404.25Β KB

@LeahMarieBush LeahMarieBush marked this pull request as ready for review September 26, 2025 16:25
@LeahMarieBush LeahMarieBush requested review from a team and williamdalessandro and removed request for a team September 26, 2025 16:25
}

/**
* Get static paths, using the configured `schemaSource`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Repeated comment here from above, should say "get static props"

Copy link
Contributor

@williamdalessandro williamdalessandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good- links work, and like you mentioned it does work like /hcp/api-docs/vault-secrets. Some of the responsive design is weird with the @media css rules (assumption) but that's outside the scope of this for sure

Copy link

hashicorp-cla-app bot commented Sep 30, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

hashicorp-cla-app bot commented Sep 30, 2025

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


1 out of 2 committers have signed the CLA.

  • LeahMarieBush
  • emilypersson1

Have you signed the CLA already but the status is still pending? Recheck it.

@emilypersson1 emilypersson1 merged commit 23c8b9a into main Sep 30, 2025
12 checks passed
@emilypersson1 emilypersson1 deleted the leah/feat/hvd-v2-template branch September 30, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants