Skip to content

bug - revert processing on provisioningstatepoller #1229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2025
Merged

bug - revert processing on provisioningstatepoller #1229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions sdk/client/resourcemanager/poller_lro.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,11 +242,3 @@ const (
statusInProgress status = "InProgress"
statusSucceeded status = "Succeeded"
)

func statusIsTerminal(s status) bool {
switch s {
case statusCanceled, statusCancelled, statusFailed, statusSucceeded, statusInProgress:
return true
}
return false
}
2 changes: 1 addition & 1 deletion sdk/client/resourcemanager/poller_provisioning_state.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ func (p *provisioningStatePoller) Poll(ctx context.Context) (*pollers.PollResult
s := string(result.Status)

// if the result has a provisioningState field, we should prioritise that
if statusIsTerminal(result.Properties.ProvisioningState) {
if result.Properties.ProvisioningState != "" {
s = string(result.Properties.ProvisioningState)
}

Expand Down
Loading