Skip to content

Conversation

gregone
Copy link

@gregone gregone commented Sep 17, 2025

Enables deployments in the UI for system jobs

Description

Testing & Reproduction steps

Links

Contributor Checklist

  • Changelog Entry If this PR changes user-facing behavior, please generate and add a
    changelog entry using the make cl command.
  • Testing Please add tests to cover any new functionality or to demonstrate bug fixes and
    ensure regressions will be caught.
  • Documentation If the change impacts user-facing functionality such as the CLI, API, UI,
    and job configuration, please update the Nomad website documentation to reflect this. Refer to
    the website README for docs guidelines. Please also consider whether the
    change requires notes within the upgrade guide.

Reviewer Checklist

  • Backport Labels Please add the correct backport labels as described by the internal
    backporting document.
  • Commit Type Ensure the correct merge method is selected which should be "squash and merge"
    in the majority of situations. The main exceptions are long-lived feature branches or merges where
    history should be preserved.
  • Enterprise PRs If this is an enterprise only PR, please add any required changelog entry
    within the public repository.
  • If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Update computed property
@gregone gregone changed the title [WIP] support deployments for system jobs [WIP] [NMD-822] support deployments for system jobs Sep 17, 2025
@gregone gregone marked this pull request as ready for review October 2, 2025 15:15
@gregone gregone requested review from a team as code owners October 2, 2025 15:15
Copy link
Contributor

@philrenaud philrenaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff!

Copy link
Contributor

@pkazmierczak pkazmierczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉
Thanks for helping out, @gregone!

@jrasell jrasell added this to the 1.11.0 milestone Oct 3, 2025
@jrasell
Copy link
Member

jrasell commented Oct 8, 2025

@gregone and @philrenaud; I plan on merging this PR in despite the failure as it looks to be a persistent flake/error unrelated to this work. Does that sound right?

@jrasell jrasell self-assigned this Oct 8, 2025
@philrenaud
Copy link
Contributor

@jrasell yep, sounds good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants