`azurerm_private_endpoint`: Retry on "RetryableError" and "StorageAccountOperationInProgress" errors during LRO #28112

magodo · 2024-11-26T05:03:21Z

Community Note

Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

This PR makes azurerm_private_endpoint retry on "RetryableError" and "StorageAccountOperationInProgress" errors during LRO.

Depends on hashicorp/go-azure-sdk#1124

PR Checklist

I have followed the guidelines in our Contributing Documentation.
I have checked to ensure there aren't other open Pull Requests for the same update/change.
I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
I have written new tests for my resource or datasource changes & updated any relevent documentation.
I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
(For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Plan: 28 to add, 0 to change, 0 to destroy.
2024-11-26T14:47:53.547+1100 [INFO]  provider: configuring client automatic mTLS
2024-11-26T14:47:53.592+1100 [INFO]  provider.terraform-provider-azurerm: configuring server automatic mTLS: timestamp="2024-11-26T14:47:53.592+1100"
azurerm_virtual_network.example: Creating...
azurerm_virtual_network.example: Creation complete after 6s [id=/subscriptions/xxxx/resourceGroups/acctest-mgd-petestt4/providers/Microsoft.Network/virtualNetworks/virtnetname11]
azurerm_subnet.example["ssub9"]: Creating...
azurerm_subnet.example["ssub8"]: Creating...
azurerm_subnet.example["ssub7"]: Creating...
azurerm_subnet.example["ssub1"]: Creating...
2024-11-26T14:48:00.386+1100 [INFO]  provider.terraform-provider-azurerm: [INFO] preparing arguments for Azure ARM Subnet creation.
azurerm_subnet.example["ssub2"]: Creating...
azurerm_subnet.example["ssub3"]: Creating...
azurerm_subnet.example["ssub6"]: Creating...
azurerm_subnet.example["ssub5"]: Creating...
azurerm_subnet.example["ssub4"]: Creating...
2024-11-26T14:48:00.387+1100 [INFO]  provider.terraform-provider-azurerm: [INFO] preparing arguments for Azure ARM Subnet creation.
2024-11-26T14:48:00.387+1100 [INFO]  provider.terraform-provider-azurerm: [INFO] preparing arguments for Azure ARM Subnet creation.
2024-11-26T14:48:00.387+1100 [INFO]  provider.terraform-provider-azurerm: [INFO] preparing arguments for Azure ARM Subnet creation.
2024-11-26T14:48:00.387+1100 [INFO]  provider.terraform-provider-azurerm: [INFO] preparing arguments for Azure ARM Subnet creation.
2024-11-26T14:48:00.387+1100 [INFO]  provider.terraform-provider-azurerm: [INFO] preparing arguments for Azure ARM Subnet creation.
2024-11-26T14:48:00.387+1100 [INFO]  provider.terraform-provider-azurerm: [INFO] preparing arguments for Azure ARM Subnet creation.
2024-11-26T14:48:00.388+1100 [INFO]  provider.terraform-provider-azurerm: [INFO] preparing arguments for Azure ARM Subnet creation.
2024-11-26T14:48:00.388+1100 [INFO]  provider.terraform-provider-azurerm: [INFO] preparing arguments for Azure ARM Subnet creation.
azurerm_subnet.example["ssub1"]: Creation complete after 6s [id=/subscriptions/xxxx/resourceGroups/acctest-mgd-petestt4/providers/Microsoft.Network/virtualNetworks/virtnetname11/subnets/ssub1]
azurerm_subnet.example["ssub7"]: Still creating... [10s elapsed]
azurerm_subnet.example["ssub5"]: Still creating... [10s elapsed]
azurerm_subnet.example["ssub3"]: Still creating... [10s elapsed]
azurerm_subnet.example["ssub9"]: Still creating... [10s elapsed]
azurerm_subnet.example["ssub6"]: Still creating... [10s elapsed]
azurerm_subnet.example["ssub8"]: Still creating... [10s elapsed]
azurerm_subnet.example["ssub4"]: Still creating... [10s elapsed]
azurerm_subnet.example["ssub2"]: Still creating... [10s elapsed]
azurerm_subnet.example["ssub6"]: Creation complete after 12s [id=/subscriptions/xxxx/resourceGroups/acctest-mgd-petestt4/providers/Microsoft.Network/virtualNetworks/virtnetname11/subnets/ssub6]
azurerm_subnet.example["ssub3"]: Creation complete after 16s [id=/subscriptions/xxxx/resourceGroups/acctest-mgd-petestt4/providers/Microsoft.Network/virtualNetworks/virtnetname11/subnets/ssub3]
azurerm_subnet.example["ssub4"]: Still creating... [20s elapsed]
azurerm_subnet.example["ssub9"]: Still creating... [20s elapsed]
azurerm_subnet.example["ssub2"]: Still creating... [20s elapsed]
azurerm_subnet.example["ssub5"]: Still creating... [20s elapsed]
azurerm_subnet.example["ssub8"]: Still creating... [20s elapsed]
azurerm_subnet.example["ssub7"]: Still creating... [20s elapsed]
azurerm_subnet.example["ssub9"]: Creation complete after 20s [id=/subscriptions/xxxx/resourceGroups/acctest-mgd-petestt4/providers/Microsoft.Network/virtualNetworks/virtnetname11/subnets/ssub9]
azurerm_subnet.example["ssub8"]: Creation complete after 24s [id=/subscriptions/xxxx/resourceGroups/acctest-mgd-petestt4/providers/Microsoft.Network/virtualNetworks/virtnetname11/subnets/ssub8]
azurerm_subnet.example["ssub7"]: Creation complete after 28s [id=/subscriptions/xxxx/resourceGroups/acctest-mgd-petestt4/providers/Microsoft.Network/virtualNetworks/virtnetname11/subnets/ssub7]
azurerm_subnet.example["ssub4"]: Still creating... [30s elapsed]
azurerm_subnet.example["ssub5"]: Still creating... [30s elapsed]
azurerm_subnet.example["ssub2"]: Still creating... [30s elapsed]
azurerm_subnet.example["ssub4"]: Creation complete after 33s [id=/subscriptions/xxxx/resourceGroups/acctest-mgd-petestt4/providers/Microsoft.Network/virtualNetworks/virtnetname11/subnets/ssub4]
azurerm_subnet.example["ssub5"]: Creation complete after 38s [id=/subscriptions/xxxx/resourceGroups/acctest-mgd-petestt4/providers/Microsoft.Network/virtualNetworks/virtnetname11/subnets/ssub5]
azurerm_subnet.example["ssub2"]: Still creating... [40s elapsed]
azurerm_subnet.example["ssub2"]: Creation complete after 43s [id=/subscriptions/xxxx/resourceGroups/acctest-mgd-petestt4/providers/Microsoft.Network/virtualNetworks/virtnetname11/subnets/ssub2]
azurerm_subnet_network_security_group_association.example["ssub2"]: Creating...
azurerm_subnet_network_security_group_association.example["ssub7"]: Creating...
azurerm_subnet_network_security_group_association.example["ssub9"]: Creating...
azurerm_subnet_network_security_group_association.example["ssub5"]: Creating...
azurerm_subnet_network_security_group_association.example["ssub8"]: Creating...
azurerm_subnet_network_security_group_association.example["ssub1"]: Creating...
azurerm_private_endpoint.example["ssub4"]: Creating...
azurerm_subnet_network_security_group_association.example["ssub6"]: Creating...
azurerm_private_endpoint.example["ssub9"]: Creating...
azurerm_private_endpoint.example["ssub6"]: Creating...
azurerm_subnet_network_security_group_association.example["ssub3"]: Creating...
azurerm_subnet_network_security_group_association.example["ssub4"]: Creating...
azurerm_private_endpoint.example["ssub7"]: Creating...
azurerm_private_endpoint.example["ssub3"]: Creating...
azurerm_private_endpoint.example["ssub2"]: Creating...
azurerm_private_endpoint.example["ssub1"]: Creating...
azurerm_private_endpoint.example["ssub5"]: Creating...
azurerm_private_endpoint.example["ssub8"]: Creating...
azurerm_subnet_network_security_group_association.example["ssub7"]: Creation complete after 4s [id=/subscriptions/xxxx/resourceGroups/acctest-mgd-petestt4/providers/Microsoft.Network/virtualNetworks/virtnetname11/subnets/ssub7]
azurerm_subnet_network_security_group_association.example["ssub2"]: Still creating... [9s elapsed]
azurerm_subnet_network_security_group_association.example["ssub5"]: Still creating... [9s elapsed]
azurerm_subnet_network_security_group_association.example["ssub1"]: Still creating... [9s elapsed]
azurerm_subnet_network_security_group_association.example["ssub9"]: Still creating... [9s elapsed]
azurerm_subnet_network_security_group_association.example["ssub8"]: Still creating... [9s elapsed]
azurerm_subnet_network_security_group_association.example["ssub6"]: Still creating... [9s elapsed]
azurerm_private_endpoint.example["ssub4"]: Still creating... [9s elapsed]
azurerm_private_endpoint.example["ssub9"]: Still creating... [9s elapsed]
azurerm_private_endpoint.example["ssub8"]: Still creating... [9s elapsed]
azurerm_private_endpoint.example["ssub2"]: Still creating... [9s elapsed]
azurerm_private_endpoint.example["ssub3"]: Still creating... [9s elapsed]
azurerm_subnet_network_security_group_association.example["ssub4"]: Still creating... [9s elapsed]
azurerm_private_endpoint.example["ssub1"]: Still creating... [9s elapsed]
azurerm_private_endpoint.example["ssub5"]: Still creating... [9s elapsed]
azurerm_subnet_network_security_group_association.example["ssub3"]: Still creating... [9s elapsed]
azurerm_private_endpoint.example["ssub6"]: Still creating... [9s elapsed]
azurerm_private_endpoint.example["ssub7"]: Still creating... [9s elapsed]
azurerm_subnet_network_security_group_association.example["ssub2"]: Creation complete after 9s [id=/subscriptions/xxxx/resourceGroups/acctest-mgd-petestt4/providers/Microsoft.Network/virtualNetworks/virtnetname11/subnets/ssub2]
azurerm_subnet_network_security_group_association.example["ssub6"]: Still creating... [19s elapsed]
azurerm_private_endpoint.example["ssub7"]: Still creating... [19s elapsed]
azurerm_subnet_network_security_group_association.example["ssub9"]: Still creating... [19s elapsed]
azurerm_subnet_network_security_group_association.example["ssub5"]: Still creating... [19s elapsed]
azurerm_subnet_network_security_group_association.example["ssub8"]: Still creating... [19s elapsed]
azurerm_subnet_network_security_group_association.example["ssub1"]: Still creating... [19s elapsed]
azurerm_private_endpoint.example["ssub4"]: Still creating... [19s elapsed]
azurerm_private_endpoint.example["ssub5"]: Still creating... [19s elapsed]
azurerm_subnet_network_security_group_association.example["ssub3"]: Still creating... [19s elapsed]
azurerm_private_endpoint.example["ssub6"]: Still creating... [19s elapsed]
azurerm_subnet_network_security_group_association.example["ssub4"]: Still creating... [19s elapsed]
azurerm_private_endpoint.example["ssub1"]: Still creating... [19s elapsed]
azurerm_private_endpoint.example["ssub9"]: Still creating... [19s elapsed]
azurerm_private_endpoint.example["ssub8"]: Still creating... [19s elapsed]
azurerm_private_endpoint.example["ssub3"]: Still creating... [19s elapsed]
azurerm_private_endpoint.example["ssub2"]: Still creating... [19s elapsed]
2024-11-26T14:49:03.419+1100 [WARN]  provider.terraform-provider-azurerm: [WARN] Retry polling "Private Endpoint (Subscription: \"xxxx\"\nResource Group Name: \"acctest-mgd-petestt4\"\nPrivate Endpoint Name: \"example-endpoint-in-ssub3\")" on error code: "RetryableError"
azurerm_subnet_network_security_group_association.example["ssub1"]: Creation complete after 22s [id=/subscriptions/xxxx/resourceGroups/acctest-mgd-petestt4/providers/Microsoft.Network/virtualNetworks/virtnetname11/subnets/ssub1]
azurerm_subnet_network_security_group_association.example["ssub5"]: Creation complete after 27s [id=/subscriptions/xxxx/resourceGroups/acctest-mgd-petestt4/providers/Microsoft.Network/virtualNetworks/virtnetname11/subnets/ssub5]
azurerm_private_endpoint.example["ssub2"]: Still creating... [29s elapsed]
azurerm_private_endpoint.example["ssub3"]: Still creating... [29s elapsed]
azurerm_private_endpoint.example["ssub6"]: Still creating... [29s elapsed]
azurerm_private_endpoint.example["ssub7"]: Still creating... [29s elapsed]
azurerm_subnet_network_security_group_association.example["ssub3"]: Still creating... [29s elapsed]
azurerm_private_endpoint.example["ssub1"]: Still creating... [29s elapsed]
azurerm_private_endpoint.example["ssub9"]: Still creating... [29s elapsed]
azurerm_private_endpoint.example["ssub8"]: Still creating... [29s elapsed]
azurerm_subnet_network_security_group_association.example["ssub4"]: Still creating... [29s elapsed]
azurerm_private_endpoint.example["ssub4"]: Still creating... [29s elapsed]
azurerm_private_endpoint.example["ssub5"]: Still creating... [29s elapsed]
azurerm_subnet_network_security_group_association.example["ssub8"]: Still creating... [29s elapsed]
azurerm_subnet_network_security_group_association.example["ssub6"]: Still creating... [29s elapsed]
azurerm_subnet_network_security_group_association.example["ssub9"]: Still creating... [29s elapsed]
azurerm_subnet_network_security_group_association.example["ssub9"]: Creation complete after 35s [id=/subscriptions/xxxx/resourceGroups/acctest-mgd-petestt4/providers/Microsoft.Network/virtualNetworks/virtnetname11/subnets/ssub9]
azurerm_subnet_network_security_group_association.example["ssub6"]: Still creating... [38s elapsed]
azurerm_subnet_network_security_group_association.example["ssub8"]: Still creating... [38s elapsed]
azurerm_private_endpoint.example["ssub6"]: Still creating... [38s elapsed]
azurerm_private_endpoint.example["ssub8"]: Still creating... [38s elapsed]
azurerm_private_endpoint.example["ssub7"]: Still creating... [38s elapsed]
azurerm_private_endpoint.example["ssub1"]: Still creating... [38s elapsed]
azurerm_private_endpoint.example["ssub4"]: Still creating... [38s elapsed]
azurerm_private_endpoint.example["ssub3"]: Still creating... [38s elapsed]
azurerm_private_endpoint.example["ssub5"]: Still creating... [38s elapsed]
azurerm_subnet_network_security_group_association.example["ssub4"]: Still creating... [38s elapsed]
azurerm_private_endpoint.example["ssub2"]: Still creating... [38s elapsed]
azurerm_subnet_network_security_group_association.example["ssub3"]: Still creating... [38s elapsed]
azurerm_private_endpoint.example["ssub9"]: Still creating... [38s elapsed]
azurerm_subnet_network_security_group_association.example["ssub8"]: Creation complete after 40s [id=/subscriptions/xxxx/re
sourceGroups/acctest-mgd-petestt4/providers/Microsoft.Network/virtualNetworks/virtnetname11/subnets/ssub8]
2024-11-26T14:49:24.508+1100 [WARN]  provider.terraform-provider-azurerm: [WARN] Retry polling "Private Endpoint (Subscription: \"xxxx\"\nResource Group Name: \"acctest-mgd-petestt4\"\nPrivate Endpoint Name: \"example-endpoint-in-ssub8\")" on error code: "StorageAccountOperationInProgress"
azurerm_subnet_network_security_group_association.example["ssub6"]: Creation complete after 44s [id=/subscriptions/xxxx/resourceGroups/acctest-mgd-petestt4/providers/Microsoft.Network/virtualNetworks/virtnetname11/subnets/ssub6]
azurerm_private_endpoint.example["ssub1"]: Still creating... [48s elapsed]
azurerm_private_endpoint.example["ssub3"]: Still creating... [48s elapsed]
azurerm_private_endpoint.example["ssub9"]: Still creating... [48s elapsed]
azurerm_private_endpoint.example["ssub4"]: Still creating... [48s elapsed]
azurerm_subnet_network_security_group_association.example["ssub3"]: Still creating... [48s elapsed]
azurerm_private_endpoint.example["ssub2"]: Still creating... [48s elapsed]
azurerm_private_endpoint.example["ssub6"]: Still creating... [48s elapsed]
azurerm_private_endpoint.example["ssub8"]: Still creating... [48s elapsed]
azurerm_private_endpoint.example["ssub7"]: Still creating... [48s elapsed]
azurerm_private_endpoint.example["ssub5"]: Still creating... [48s elapsed]
azurerm_subnet_network_security_group_association.example["ssub4"]: Still creating... [48s elapsed]
azurerm_subnet_network_security_group_association.example["ssub4"]: Creation complete after 48s [id=/subscriptions/xxxx/resourceGroups/acctest-mgd-petestt4/providers/Microsoft.Network/virtualNetworks/virtnetname11/subnets/ssub4]
azurerm_private_endpoint.example["ssub7"]: Creation complete after 54s [id=/subscriptions/xxxx/resourceGroups/acctest-mgd-petestt4/providers/Microsoft.Network/privateEndpoints/example-endpoint-in-ssub7]
azurerm_private_endpoint.example["ssub9"]: Creation complete after 54s [id=/subscriptions/xxxx/resourceGroups/acctest-mgd-petestt4/providers/Microsoft.Network/privateEndpoints/example-endpoint-in-ssub9]
azurerm_private_endpoint.example["ssub6"]: Creation complete after 54s [id=/subscriptions/xxxx/resourceGroups/acctest-mgd-petestt4/providers/Microsoft.Network/privateEndpoints/example-endpoint-in-ssub6]
azurerm_private_endpoint.example["ssub4"]: Creation complete after 56s [id=/subscriptions/xxxx/resourceGroups/acctest-mgd-petestt4/providers/Microsoft.Network/privateEndpoints/example-endpoint-in-ssub4]
azurerm_subnet_network_security_group_association.example["ssub3"]: Creation complete after 56s [id=/subscriptions/xxxx/resourceGroups/acctest-mgd-petestt4/providers/Microsoft.Network/virtualNetworks/virtnetname11/subnets/ssub3]
azurerm_private_endpoint.example["ssub1"]: Creation complete after 57s [id=/subscriptions/xxxx/resourceGroups/acctest-mgd-petestt4/providers/Microsoft.Network/privateEndpoints/example-endpoint-in-ssub1]
azurerm_private_endpoint.example["ssub5"]: Still creating... [58s elapsed]
azurerm_private_endpoint.example["ssub8"]: Still creating... [58s elapsed]
azurerm_private_endpoint.example["ssub3"]: Still creating... [58s elapsed]
azurerm_private_endpoint.example["ssub2"]: Still creating... [58s elapsed]
azurerm_private_endpoint.example["ssub8"]: Still creating... [1m7s elapsed]
azurerm_private_endpoint.example["ssub5"]: Still creating... [1m7s elapsed]
azurerm_private_endpoint.example["ssub3"]: Still creating... [1m7s elapsed]
azurerm_private_endpoint.example["ssub2"]: Still creating... [1m7s elapsed]
azurerm_private_endpoint.example["ssub3"]: Creation complete after 1m8s [id=/subscriptions/xxxx/resourceGroups/acctest-mgd-petestt4/providers/Microsoft.Network/privateEndpoints/example-endpoint-in-ssub3]
azurerm_private_endpoint.example["ssub2"]: Creation complete after 1m9s [id=/subscriptions/xxxx/resourceGroups/acctest-mgd-petestt4/providers/Microsoft.Network/privateEndpoints/example-endpoint-in-ssub2]
azurerm_private_endpoint.example["ssub5"]: Still creating... [1m17s elapsed]
azurerm_private_endpoint.example["ssub8"]: Still creating... [1m17s elapsed]
azurerm_private_endpoint.example["ssub8"]: Creation complete after 1m18s [id=/subscriptions/xxxx/resourceGroups/acctest-mgd-petestt4/providers/Microsoft.Network/privateEndpoints/example-endpoint-in-ssub8]
azurerm_private_endpoint.example["ssub5"]: Still creating... [1m27s elapsed]
azurerm_private_endpoint.example["ssub5"]: Still creating... [1m36s elapsed]
azurerm_private_endpoint.example["ssub5"]: Creation complete after 1m38s [id=/subscriptions/xxxx/resourceGroups/acctest-mgd-petestt4/providers/Microsoft.Network/privateEndpoints/example-endpoint-in-ssub5]
2024-11-26T14:50:20.857+1100 [INFO]  provider: plugin process exited: plugin=/home/magodo/go/bin/terraform-provider-azurerm id=71897

Apply complete! Resources: 28 added, 0 changed, 0 destroyed.

Note about the [WARN] logs above.

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

azurerm_private_endpoint: Retry on "RetryableError" and "StorageAccountOperationInProgress" errors during LRO [GH-00000]

This is a (please select all that apply):

Bug Fix
New Feature (ie adding a service, resource, or data source)
Enhancement
Breaking Change

Related Issue(s)

Fixes #21293

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

…ountOperationInProgress" errors during LRO

github-actions · 2024-12-30T06:03:40Z

This PR is being labeled as "stale" because it has not been updated for 30 or more days.

If this PR is still valid, please remove the "stale" label. If this PR is blocked, please add it to the "Blocked" milestone.

If you need some help completing this PR, please leave a comment letting us know. Thank you!

github-actions · 2025-02-03T06:03:36Z

This PR is being labeled as "stale" because it has not been updated for 30 or more days.

If this PR is still valid, please remove the "stale" label. If this PR is blocked, please add it to the "Blocked" milestone.

If you need some help completing this PR, please leave a comment letting us know. Thank you!

github-actions · 2025-03-10T06:03:31Z

This PR is being labeled as "stale" because it has not been updated for 30 or more days.

If this PR is still valid, please remove the "stale" label. If this PR is blocked, please add it to the "Blocked" milestone.

If you need some help completing this PR, please leave a comment letting us know. Thank you!

github-actions · 2025-04-14T06:04:03Z

This PR is being labeled as "stale" because it has not been updated for 30 or more days.

If this PR is still valid, please remove the "stale" label. If this PR is blocked, please add it to the "Blocked" milestone.

If you need some help completing this PR, please leave a comment letting us know. Thank you!

enterpriseSoftware · 2025-05-07T16:01:21Z

This is still an issue, any ideas when this request will be resolved?

dannyger97 · 2025-05-09T10:18:26Z

Any updates on this? I really would like to see this fixed

github-actions · 2025-06-09T06:04:44Z

This PR is being labeled as "stale" because it has not been updated for 30 or more days.

If this PR is still valid, please remove the "stale" label. If this PR is blocked, please add it to the "Blocked" milestone.

If you need some help completing this PR, please leave a comment letting us know. Thank you!

dannyger97 · 2025-06-18T10:44:31Z

@magodo it is not stale. would you be so kind to provide an update?

magodo · 2025-06-18T23:37:47Z

Kindly ping @jackofallops

enterpriseSoftware · 2025-07-15T14:03:37Z

any updates?

magodo · 2025-07-23T08:36:18Z

This PR got updated per the change on the underlying SDK at: hashicorp/go-azure-sdk#1221. Now it depends on another PR: hashicorp/go-azure-sdk#1224.

magodo · 2025-07-30T01:39:45Z

@jackofallops Given #30254 is merged, this PR is now ready for review.

wyattfry

One very minor error message adjustment IMO. Otherwise looks good to go.

wyattfry · 2025-08-19T13:12:49Z

internal/services/network/private_endpoint_resource.go

-				}
+			}
+			return &pluginsdk.RetryError{
+				Err:       fmt.Errorf("waiting the creation of %s: %+v", id, err),


Could the error message stay the same? Or did you mean "waiting for"?

Suggested change

Err: fmt.Errorf("waiting the creation of %s: %+v", id, err),

Err: fmt.Errorf("creating %s: %+v", id, err),

@wyattfry Yes, I meant "waiting for", to differ from the error message for L359:

result, err := client.CreateOrUpdate(ctx, id, parameters) if err != nil { return &pluginsdk.RetryError{ Err: fmt.Errorf("creating %s: %+v", id, err), Retryable: false, } }

wyattfry

LGTM 👍

github-actions · 2025-09-20T02:16:40Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

azurerm_private_endpoint: Retry on "RetryableError" and "StorageAcc…

d4b24a7

…ountOperationInProgress" errors during LRO

github-actions bot added service/network size/S bug waiting-response labels Nov 26, 2024

github-actions bot added the stale label Dec 30, 2024

magodo removed the stale label Dec 30, 2024

github-actions bot added the stale label Feb 3, 2025

magodo removed the stale label Feb 3, 2025

magodo mentioned this pull request Feb 3, 2025

azurerm_private_endpoint fails intermittently with retriable error #2 #21293

Closed

1 task

github-actions bot added the stale label Mar 10, 2025

magodo removed the stale label Mar 10, 2025

github-actions bot added the stale label Apr 14, 2025

magodo removed the stale label Apr 14, 2025

github-actions bot added the stale label Jun 9, 2025

magodo removed the stale label Jun 10, 2025

github-actions bot removed the waiting-response label Jun 18, 2025

Merge branch 'main' into pe_retryableerror

0f9b609

github-actions bot added the waiting-response label Jul 23, 2025

gofumpt

f553c28

github-actions bot removed the waiting-response label Jul 23, 2025

remove a useless check introduced in hashicorp#16315

628e5ea

Merge branch 'main' into pe_retryableerror

ee6bd93

magodo changed the title ~~WIP: azurerm_private_endpoint: Retry on "RetryableError" and "StorageAccountOperationInProgress" errors during LRO~~ azurerm_private_endpoint: Retry on "RetryableError" and "StorageAccountOperationInProgress" errors during LRO Jul 30, 2025

magodo marked this pull request as ready for review July 30, 2025 01:38

magodo requested review from a team and WodansSon as code owners July 30, 2025 01:38

wyattfry self-assigned this Aug 19, 2025

wyattfry suggested changes Aug 19, 2025

View reviewed changes

github-actions bot added the waiting-response label Aug 19, 2025

wording

e99c07d

github-actions bot removed the waiting-response label Aug 20, 2025

wyattfry approved these changes Aug 20, 2025

View reviewed changes

wyattfry merged commit 79c3cb2 into hashicorp:main Aug 20, 2025
33 checks passed

github-actions bot added this to the v4.41.0 milestone Aug 20, 2025

wyattfry added a commit that referenced this pull request Aug 20, 2025

Update CHANGELOG.md #28112

4f3e700

mbfrahry pushed a commit that referenced this pull request Aug 21, 2025

Update CHANGELOG.md #28112

c2fb468

github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2025

	Err: fmt.Errorf("waiting the creation of %s: %+v", id, err),
	Err: fmt.Errorf("creating %s: %+v", id, err),

azurerm_private_endpoint: Retry on "RetryableError" and "StorageAccountOperationInProgress" errors during LRO #28112

azurerm_private_endpoint: Retry on "RetryableError" and "StorageAccountOperationInProgress" errors during LRO #28112

Uh oh!

Conversation

magodo commented Nov 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Community Note

Description

PR Checklist

Changes to existing Resource / Data Source

Testing

Change Log

Related Issue(s)

Uh oh!

github-actions bot commented Dec 30, 2024

Uh oh!

github-actions bot commented Feb 3, 2025

Uh oh!

github-actions bot commented Mar 10, 2025

Uh oh!

github-actions bot commented Apr 14, 2025

Uh oh!

enterpriseSoftware commented May 7, 2025

Uh oh!

dannyger97 commented May 9, 2025

Uh oh!

github-actions bot commented Jun 9, 2025

Uh oh!

dannyger97 commented Jun 18, 2025

Uh oh!

magodo commented Jun 18, 2025

Uh oh!

enterpriseSoftware commented Jul 15, 2025

Uh oh!

magodo commented Jul 23, 2025 • edited by jackofallops Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

magodo commented Jul 30, 2025

Uh oh!

wyattfry left a comment

Choose a reason for hiding this comment

Uh oh!

wyattfry Aug 19, 2025

Choose a reason for hiding this comment

Uh oh!

magodo Aug 20, 2025

Choose a reason for hiding this comment

Uh oh!

wyattfry left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Sep 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

`azurerm_private_endpoint`: Retry on "RetryableError" and "StorageAccountOperationInProgress" errors during LRO #28112

`azurerm_private_endpoint`: Retry on "RetryableError" and "StorageAccountOperationInProgress" errors during LRO #28112

magodo commented Nov 26, 2024 •

edited

Loading

magodo commented Jul 23, 2025 •

edited by jackofallops

Loading