azurerm_logic_app_standard - support for the key_vault_reference_identity_id proerty

[ziyeqf]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Adding a new property.
I set this property to O+C because the service will set a default value SystemAssigned to it when identity is configured as SystemAssigned.
However, I'm very concerned this will not allow users to reset this property to null, and it may breaks the best practice.
Here is the options and concerns:

1. setting it to O+C: users will not be able to reset this property to null from a user-assigned identity id by removing this property.
2. Setting it only optional: It will break existing Terraform configurations with system assigned identity, users will see the diff key_vault_reference_identity_id: "SystemAssigned" -> null

A possible solution is to set it O+C in current 4.x version but remove the Computed in v5.0?

Thanks for any insight in advance.

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevant documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_logic_app_standard - support for the key_vault_reference_identity_id proerty [GH-00000]

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #0000

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the provider.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[magodo]

@ziyeqf Please resolve the conflict and I'll take a look at this PR. Thanks!

[ziyeqf]

❯ tftest logic TestAccLogicAppStandard_
=== RUN   TestAccLogicAppStandard_basic
=== PAUSE TestAccLogicAppStandard_basic
=== RUN   TestAccLogicAppStandard_complete
=== PAUSE TestAccLogicAppStandard_complete
=== RUN   TestAccLogicAppStandard_completeUpdated
=== PAUSE TestAccLogicAppStandard_completeUpdated
=== RUN   TestAccLogicAppStandard_publishBasicAuth
=== PAUSE TestAccLogicAppStandard_publishBasicAuth
=== RUN   TestAccLogicAppStandard_publicNetworkAccessDisabled
=== PAUSE TestAccLogicAppStandard_publicNetworkAccessDisabled
=== RUN   TestAccLogicAppStandard_containerized
=== PAUSE TestAccLogicAppStandard_containerized
=== RUN   TestAccLogicAppStandard_extensionBundle
=== PAUSE TestAccLogicAppStandard_extensionBundle
=== RUN   TestAccLogicAppStandard_siteConfigVnetRouteAllEnabled
=== PAUSE TestAccLogicAppStandard_siteConfigVnetRouteAllEnabled
=== RUN   TestAccLogicAppStandard_appSettingsVnetRouteAllEnabled
=== PAUSE TestAccLogicAppStandard_appSettingsVnetRouteAllEnabled
=== RUN   TestAccLogicAppStandard_requiresImport
=== PAUSE TestAccLogicAppStandard_requiresImport
=== RUN   TestAccLogicAppStandard_tags
=== PAUSE TestAccLogicAppStandard_tags
=== RUN   TestAccLogicAppStandard_tagsUpdate
=== PAUSE TestAccLogicAppStandard_tagsUpdate
=== RUN   TestAccLogicAppStandard_appSettings
=== PAUSE TestAccLogicAppStandard_appSettings
=== RUN   TestAccLogicAppStandard_customShare
=== PAUSE TestAccLogicAppStandard_customShare
=== RUN   TestAccLogicAppStandard_siteConfig
=== PAUSE TestAccLogicAppStandard_siteConfig
=== RUN   TestAccLogicAppStandard_healthCheck
=== PAUSE TestAccLogicAppStandard_healthCheck
=== RUN   TestAccLogicAppStandard_connectionStrings
=== PAUSE TestAccLogicAppStandard_connectionStrings
=== RUN   TestAccLogicAppStandard_updateVersion
=== PAUSE TestAccLogicAppStandard_updateVersion
=== RUN   TestAccLogicAppStandard_3264bit
=== PAUSE TestAccLogicAppStandard_3264bit
=== RUN   TestAccLogicAppStandard_httpsOnly
=== PAUSE TestAccLogicAppStandard_httpsOnly
=== RUN   TestAccLogicAppStandard_createIdentity
=== PAUSE TestAccLogicAppStandard_createIdentity
=== RUN   TestAccLogicAppStandard_updateIdentity
=== PAUSE TestAccLogicAppStandard_updateIdentity
=== RUN   TestAccLogicAppStandard_userAssignedIdentity
=== PAUSE TestAccLogicAppStandard_userAssignedIdentity
=== RUN   TestAccLogicAppStandard_corsSettings
=== PAUSE TestAccLogicAppStandard_corsSettings
=== RUN   TestAccLogicAppStandard_corsSettingsRemoved
=== PAUSE TestAccLogicAppStandard_corsSettingsRemoved
=== RUN   TestAccLogicAppStandard_enableHttp2
=== PAUSE TestAccLogicAppStandard_enableHttp2
=== RUN   TestAccLogicAppStandard_minTlsVersion
=== PAUSE TestAccLogicAppStandard_minTlsVersion
=== RUN   TestAccLogicAppStandard_ftpsState
=== PAUSE TestAccLogicAppStandard_ftpsState
=== RUN   TestAccLogicAppStandard_preWarmedInstanceCount
=== PAUSE TestAccLogicAppStandard_preWarmedInstanceCount
=== RUN   TestAccLogicAppStandard_computedPreWarmedInstanceCount
=== PAUSE TestAccLogicAppStandard_computedPreWarmedInstanceCount
=== RUN   TestAccLogicAppStandard_oneIpRestriction
=== PAUSE TestAccLogicAppStandard_oneIpRestriction
=== RUN   TestAccLogicAppStandard_oneServiceTagIpRestriction
=== PAUSE TestAccLogicAppStandard_oneServiceTagIpRestriction
=== RUN   TestAccLogicAppStandard_changeIpToServiceTagIpRestriction
=== PAUSE TestAccLogicAppStandard_changeIpToServiceTagIpRestriction
=== RUN   TestAccLogicAppStandard_oneVNetSubnetIpRestriction
=== PAUSE TestAccLogicAppStandard_oneVNetSubnetIpRestriction
=== RUN   TestAccLogicAppStandard_ipRestrictionRemoved
=== PAUSE TestAccLogicAppStandard_ipRestrictionRemoved
=== RUN   TestAccLogicAppStandard_scmIpRestrictionRemoved
=== PAUSE TestAccLogicAppStandard_scmIpRestrictionRemoved
=== RUN   TestAccLogicAppStandard_scmIpRestrictionUpdate
=== PAUSE TestAccLogicAppStandard_scmIpRestrictionUpdate
=== RUN   TestAccLogicAppStandard_manyIpRestrictions
=== PAUSE TestAccLogicAppStandard_manyIpRestrictions
=== RUN   TestAccLogicAppStandard_scmType
=== PAUSE TestAccLogicAppStandard_scmType
=== RUN   TestAccLogicAppStandard_scmUseMainIpRestriction
=== PAUSE TestAccLogicAppStandard_scmUseMainIpRestriction
=== RUN   TestAccLogicAppStandard_scmOneIpRestriction
=== PAUSE TestAccLogicAppStandard_scmOneIpRestriction
=== RUN   TestAccLogicAppStandard_scmMinTlsVersion
=== PAUSE TestAccLogicAppStandard_scmMinTlsVersion
=== RUN   TestAccLogicAppStandard_updateStorageAccountKey
=== PAUSE TestAccLogicAppStandard_updateStorageAccountKey
=== RUN   TestAccLogicAppStandard_clientCertMode
=== PAUSE TestAccLogicAppStandard_clientCertMode
=== RUN   TestAccLogicAppStandard_elasticInstanceMinimum
=== PAUSE TestAccLogicAppStandard_elasticInstanceMinimum
=== RUN   TestAccLogicAppStandard_appScaleLimit
=== PAUSE TestAccLogicAppStandard_appScaleLimit
=== RUN   TestAccLogicAppStandard_runtimeScaleMonitoringEnabled
=== PAUSE TestAccLogicAppStandard_runtimeScaleMonitoringEnabled
=== RUN   TestAccLogicAppStandard_dotnetVersion4
=== PAUSE TestAccLogicAppStandard_dotnetVersion4
=== RUN   TestAccLogicAppStandard_dotnetVersion5
=== PAUSE TestAccLogicAppStandard_dotnetVersion5
=== RUN   TestAccLogicAppStandard_dotnetVersion6
=== PAUSE TestAccLogicAppStandard_dotnetVersion6
=== RUN   TestAccLogicAppStandard_dotnetVersion8
=== PAUSE TestAccLogicAppStandard_dotnetVersion8
=== RUN   TestAccLogicAppStandard_vNetIntegration
=== PAUSE TestAccLogicAppStandard_vNetIntegration
=== RUN   TestAccLogicAppStandard_vNetIntegrationUpdate
=== PAUSE TestAccLogicAppStandard_vNetIntegrationUpdate
=== RUN   TestAccLogicAppStandard_publicNetworkAccessEnabled
=== PAUSE TestAccLogicAppStandard_publicNetworkAccessEnabled
=== RUN   TestAccLogicAppStandard_vnetContentShareEnabled
=== PAUSE TestAccLogicAppStandard_vnetContentShareEnabled
=== RUN   TestAccLogicAppStandard_keyVaultReferenceIdentity
=== PAUSE TestAccLogicAppStandard_keyVaultReferenceIdentity
=== CONT  TestAccLogicAppStandard_basic
=== CONT  TestAccLogicAppStandard_preWarmedInstanceCount
=== CONT  TestAccLogicAppStandard_updateStorageAccountKey
=== CONT  TestAccLogicAppStandard_siteConfig
=== CONT  TestAccLogicAppStandard_ftpsState
=== CONT  TestAccLogicAppStandard_minTlsVersion
=== CONT  TestAccLogicAppStandard_enableHttp2
=== CONT  TestAccLogicAppStandard_corsSettingsRemoved
--- PASS: TestAccLogicAppStandard_minTlsVersion (434.64s)
=== CONT  TestAccLogicAppStandard_corsSettings
--- PASS: TestAccLogicAppStandard_siteConfig (442.41s)
=== CONT  TestAccLogicAppStandard_userAssignedIdentity
--- PASS: TestAccLogicAppStandard_ftpsState (442.46s)
=== CONT  TestAccLogicAppStandard_updateIdentity
--- PASS: TestAccLogicAppStandard_enableHttp2 (444.55s)
=== CONT  TestAccLogicAppStandard_createIdentity
--- PASS: TestAccLogicAppStandard_preWarmedInstanceCount (456.19s)
=== CONT  TestAccLogicAppStandard_httpsOnly
--- PASS: TestAccLogicAppStandard_basic (467.14s)
=== CONT  TestAccLogicAppStandard_3264bit
--- PASS: TestAccLogicAppStandard_corsSettings (369.35s)
=== CONT  TestAccLogicAppStandard_updateVersion
--- PASS: TestAccLogicAppStandard_corsSettingsRemoved (819.94s)
=== CONT  TestAccLogicAppStandard_connectionStrings
--- PASS: TestAccLogicAppStandard_createIdentity (375.91s)
=== CONT  TestAccLogicAppStandard_healthCheck
--- PASS: TestAccLogicAppStandard_userAssignedIdentity (381.63s)
=== CONT  TestAccLogicAppStandard_tagsUpdate
--- PASS: TestAccLogicAppStandard_httpsOnly (374.69s)
=== CONT  TestAccLogicAppStandard_customShare
=== CONT  TestAccLogicAppStandard_appSettings
--- PASS: TestAccLogicAppStandard_updateStorageAccountKey (887.50s)
--- PASS: TestAccLogicAppStandard_updateIdentity (597.11s)
=== CONT  TestAccLogicAppStandard_scmIpRestrictionRemoved
--- PASS: TestAccLogicAppStandard_3264bit (597.46s)
=== CONT  TestAccLogicAppStandard_scmMinTlsVersion
--- PASS: TestAccLogicAppStandard_connectionStrings (369.96s)
=== CONT  TestAccLogicAppStandard_scmOneIpRestriction
--- PASS: TestAccLogicAppStandard_healthCheck (395.14s)
=== CONT  TestAccLogicAppStandard_scmUseMainIpRestriction
--- PASS: TestAccLogicAppStandard_customShare (388.12s)
=== CONT  TestAccLogicAppStandard_scmType
--- PASS: TestAccLogicAppStandard_tagsUpdate (395.02s)
=== CONT  TestAccLogicAppStandard_manyIpRestrictions
--- PASS: TestAccLogicAppStandard_updateVersion (591.78s)
=== CONT  TestAccLogicAppStandard_scmIpRestrictionUpdate
--- PASS: TestAccLogicAppStandard_scmMinTlsVersion (374.97s)
=== CONT  TestAccLogicAppStandard_requiresImport
=== CONT  TestAccLogicAppStandard_tags
--- PASS: TestAccLogicAppStandard_appSettings (582.54s)
--- PASS: TestAccLogicAppStandard_scmUseMainIpRestriction (372.86s)
=== CONT  TestAccLogicAppStandard_changeIpToServiceTagIpRestriction
--- PASS: TestAccLogicAppStandard_scmType (371.75s)
=== CONT  TestAccLogicAppStandard_ipRestrictionRemoved
--- PASS: TestAccLogicAppStandard_manyIpRestrictions (379.08s)
=== CONT  TestAccLogicAppStandard_oneVNetSubnetIpRestriction
--- PASS: TestAccLogicAppStandard_scmIpRestrictionRemoved (577.98s)
=== CONT  TestAccLogicAppStandard_publicNetworkAccessDisabled
--- PASS: TestAccLogicAppStandard_requiresImport (314.38s)
=== CONT  TestAccLogicAppStandard_extensionBundle
--- PASS: TestAccLogicAppStandard_scmOneIpRestriction (587.27s)
=== CONT  TestAccLogicAppStandard_containerized
--- PASS: TestAccLogicAppStandard_tags (368.63s)
=== CONT  TestAccLogicAppStandard_dotnetVersion6
=== CONT  TestAccLogicAppStandard_keyVaultReferenceIdentity
--- PASS: TestAccLogicAppStandard_oneVNetSubnetIpRestriction (383.45s)
--- PASS: TestAccLogicAppStandard_extensionBundle (367.02s)
=== CONT  TestAccLogicAppStandard_vnetContentShareEnabled
--- PASS: TestAccLogicAppStandard_containerized (373.59s)
=== CONT  TestAccLogicAppStandard_publicNetworkAccessEnabled
--- PASS: TestAccLogicAppStandard_ipRestrictionRemoved (577.49s)
=== CONT  TestAccLogicAppStandard_vNetIntegrationUpdate
--- PASS: TestAccLogicAppStandard_dotnetVersion6 (367.97s)
=== CONT  TestAccLogicAppStandard_vNetIntegration
--- PASS: TestAccLogicAppStandard_keyVaultReferenceIdentity (375.54s)
=== CONT  TestAccLogicAppStandard_dotnetVersion8
--- PASS: TestAccLogicAppStandard_changeIpToServiceTagIpRestriction (799.71s)
=== CONT  TestAccLogicAppStandard_oneIpRestriction
--- PASS: TestAccLogicAppStandard_scmIpRestrictionUpdate (1007.77s)
=== CONT  TestAccLogicAppStandard_oneServiceTagIpRestriction
=== CONT  TestAccLogicAppStandard_runtimeScaleMonitoringEnabled
--- PASS: TestAccLogicAppStandard_publicNetworkAccessDisabled (789.50s)
--- PASS: TestAccLogicAppStandard_vNetIntegration (402.59s)
=== CONT  TestAccLogicAppStandard_dotnetVersion5
--- PASS: TestAccLogicAppStandard_dotnetVersion8 (369.22s)
=== CONT  TestAccLogicAppStandard_dotnetVersion4
--- PASS: TestAccLogicAppStandard_publicNetworkAccessEnabled (584.96s)
=== CONT  TestAccLogicAppStandard_computedPreWarmedInstanceCount
--- PASS: TestAccLogicAppStandard_oneIpRestriction (369.56s)
=== CONT  TestAccLogicAppStandard_appSettingsVnetRouteAllEnabled
--- PASS: TestAccLogicAppStandard_oneServiceTagIpRestriction (366.79s)
=== CONT  TestAccLogicAppStandard_completeUpdated
--- PASS: TestAccLogicAppStandard_runtimeScaleMonitoringEnabled (369.12s)
=== CONT  TestAccLogicAppStandard_publishBasicAuth
=== CONT  TestAccLogicAppStandard_elasticInstanceMinimum
--- PASS: TestAccLogicAppStandard_vnetContentShareEnabled (817.41s)
--- PASS: TestAccLogicAppStandard_dotnetVersion5 (393.53s)
=== CONT  TestAccLogicAppStandard_appScaleLimit
--- PASS: TestAccLogicAppStandard_dotnetVersion4 (370.27s)
=== CONT  TestAccLogicAppStandard_clientCertMode
--- PASS: TestAccLogicAppStandard_computedPreWarmedInstanceCount (369.28s)
=== CONT  TestAccLogicAppStandard_complete
--- PASS: TestAccLogicAppStandard_appSettingsVnetRouteAllEnabled (374.39s)
=== CONT  TestAccLogicAppStandard_siteConfigVnetRouteAllEnabled
--- PASS: TestAccLogicAppStandard_vNetIntegrationUpdate (1102.81s)
--- PASS: TestAccLogicAppStandard_elasticInstanceMinimum (367.73s)
--- PASS: TestAccLogicAppStandard_appScaleLimit (382.60s)
--- PASS: TestAccLogicAppStandard_completeUpdated (627.03s)
--- PASS: TestAccLogicAppStandard_complete (395.17s)
--- PASS: TestAccLogicAppStandard_siteConfigVnetRouteAllEnabled (374.45s)
--- PASS: TestAccLogicAppStandard_publishBasicAuth (811.09s)
--- PASS: TestAccLogicAppStandard_clientCertMode (1291.01s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/logic 4387.695s

[magodo]

@ziyeqf Thank you for resolving the conflicts! I have some additional questions regarding the new attribute:

1. In the current design, it is only meant to be set for UAI. However, since the identity can support both SAI and UAI, does it mean this new attribute can support both?
2. Say I have two UAIs assigned to the identity, can I only specify one of them?
3. Given the identity is SAI, and we didn't specify the kv_ref_identity_id here, it defaults to assigning the SAI. Is it the same case for UAI? Meaning if I assign one SAI, and leave the kv one absent, does it mean this UAI will be assigned to reference the key vault by default?

[ziyeqf]

@magodo

1. yes, it can be set to SystemAssigned
2. yes for UAI it only accepts one value
3. no, it will not set UAI by default. However found that once the property is set, it can not be removed... which means, if the identity is set to SAI, then changed to UAI, the key_vault_reference_identity_id will keep SystemAssigned till a new value be set.

[ziyeqf]

Here is the new test result:

terraform-provider-azurerm [ logic_kv_identity][$!?][🐹 v1.24.5][⏱ 8m57s]
❯ tftest logic TestAccLogicAppStandard_keyVaultReferenceIdentity
=== RUN   TestAccLogicAppStandard_keyVaultReferenceIdentity
=== PAUSE TestAccLogicAppStandard_keyVaultReferenceIdentity
=== CONT  TestAccLogicAppStandard_keyVaultReferenceIdentity
--- PASS: TestAccLogicAppStandard_keyVaultReferenceIdentity (594.80s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/logic 594.835s

However I'm feeling a bit weird...

[magodo]

@ziyeqf Could you test with the v5 feature both enabled and disabled?

[ziyeqf]

sure, @magodo. Here is the result with 5.0 feature flag.

❯ tftest logic TestAccLogicAppStandard_
=== RUN   TestAccLogicAppStandard_basic
=== PAUSE TestAccLogicAppStandard_basic
=== RUN   TestAccLogicAppStandard_complete
=== PAUSE TestAccLogicAppStandard_complete
=== RUN   TestAccLogicAppStandard_completeUpdated
=== PAUSE TestAccLogicAppStandard_completeUpdated
=== RUN   TestAccLogicAppStandard_publishBasicAuth
=== PAUSE TestAccLogicAppStandard_publishBasicAuth
=== RUN   TestAccLogicAppStandard_publicNetworkAccessDisabled
=== PAUSE TestAccLogicAppStandard_publicNetworkAccessDisabled
=== RUN   TestAccLogicAppStandard_containerized
=== PAUSE TestAccLogicAppStandard_containerized
=== RUN   TestAccLogicAppStandard_extensionBundle
=== PAUSE TestAccLogicAppStandard_extensionBundle
=== RUN   TestAccLogicAppStandard_siteConfigVnetRouteAllEnabled
=== PAUSE TestAccLogicAppStandard_siteConfigVnetRouteAllEnabled
=== RUN   TestAccLogicAppStandard_appSettingsVnetRouteAllEnabled
=== PAUSE TestAccLogicAppStandard_appSettingsVnetRouteAllEnabled
=== RUN   TestAccLogicAppStandard_requiresImport
=== PAUSE TestAccLogicAppStandard_requiresImport
=== RUN   TestAccLogicAppStandard_tags
=== PAUSE TestAccLogicAppStandard_tags
=== RUN   TestAccLogicAppStandard_tagsUpdate
=== PAUSE TestAccLogicAppStandard_tagsUpdate
=== RUN   TestAccLogicAppStandard_appSettings
=== PAUSE TestAccLogicAppStandard_appSettings
=== RUN   TestAccLogicAppStandard_customShare
=== PAUSE TestAccLogicAppStandard_customShare
=== RUN   TestAccLogicAppStandard_siteConfig
=== PAUSE TestAccLogicAppStandard_siteConfig
=== RUN   TestAccLogicAppStandard_healthCheck
=== PAUSE TestAccLogicAppStandard_healthCheck
=== RUN   TestAccLogicAppStandard_connectionStrings
=== PAUSE TestAccLogicAppStandard_connectionStrings
=== RUN   TestAccLogicAppStandard_updateVersion
=== PAUSE TestAccLogicAppStandard_updateVersion
=== RUN   TestAccLogicAppStandard_3264bit
=== PAUSE TestAccLogicAppStandard_3264bit
=== RUN   TestAccLogicAppStandard_httpsOnly
=== PAUSE TestAccLogicAppStandard_httpsOnly
=== RUN   TestAccLogicAppStandard_createIdentity
=== PAUSE TestAccLogicAppStandard_createIdentity
=== RUN   TestAccLogicAppStandard_updateIdentity
=== PAUSE TestAccLogicAppStandard_updateIdentity
=== RUN   TestAccLogicAppStandard_userAssignedIdentity
=== PAUSE TestAccLogicAppStandard_userAssignedIdentity
=== RUN   TestAccLogicAppStandard_corsSettings
=== PAUSE TestAccLogicAppStandard_corsSettings
=== RUN   TestAccLogicAppStandard_corsSettingsRemoved
=== PAUSE TestAccLogicAppStandard_corsSettingsRemoved
=== RUN   TestAccLogicAppStandard_enableHttp2
=== PAUSE TestAccLogicAppStandard_enableHttp2
=== RUN   TestAccLogicAppStandard_minTlsVersion
=== PAUSE TestAccLogicAppStandard_minTlsVersion
=== RUN   TestAccLogicAppStandard_ftpsState
=== PAUSE TestAccLogicAppStandard_ftpsState
=== RUN   TestAccLogicAppStandard_preWarmedInstanceCount
=== PAUSE TestAccLogicAppStandard_preWarmedInstanceCount
=== RUN   TestAccLogicAppStandard_computedPreWarmedInstanceCount
=== PAUSE TestAccLogicAppStandard_computedPreWarmedInstanceCount
=== RUN   TestAccLogicAppStandard_oneIpRestriction
=== PAUSE TestAccLogicAppStandard_oneIpRestriction
=== RUN   TestAccLogicAppStandard_oneServiceTagIpRestriction
=== PAUSE TestAccLogicAppStandard_oneServiceTagIpRestriction
=== RUN   TestAccLogicAppStandard_changeIpToServiceTagIpRestriction
=== PAUSE TestAccLogicAppStandard_changeIpToServiceTagIpRestriction
=== RUN   TestAccLogicAppStandard_oneVNetSubnetIpRestriction
=== PAUSE TestAccLogicAppStandard_oneVNetSubnetIpRestriction
=== RUN   TestAccLogicAppStandard_ipRestrictionRemoved
=== PAUSE TestAccLogicAppStandard_ipRestrictionRemoved
=== RUN   TestAccLogicAppStandard_scmIpRestrictionRemoved
=== PAUSE TestAccLogicAppStandard_scmIpRestrictionRemoved
=== RUN   TestAccLogicAppStandard_scmIpRestrictionUpdate
=== PAUSE TestAccLogicAppStandard_scmIpRestrictionUpdate
=== RUN   TestAccLogicAppStandard_manyIpRestrictions
=== PAUSE TestAccLogicAppStandard_manyIpRestrictions
=== RUN   TestAccLogicAppStandard_scmType
=== PAUSE TestAccLogicAppStandard_scmType
=== RUN   TestAccLogicAppStandard_scmUseMainIpRestriction
=== PAUSE TestAccLogicAppStandard_scmUseMainIpRestriction
=== RUN   TestAccLogicAppStandard_scmOneIpRestriction
=== PAUSE TestAccLogicAppStandard_scmOneIpRestriction
=== RUN   TestAccLogicAppStandard_scmMinTlsVersion
=== PAUSE TestAccLogicAppStandard_scmMinTlsVersion
=== RUN   TestAccLogicAppStandard_updateStorageAccountKey
=== PAUSE TestAccLogicAppStandard_updateStorageAccountKey
=== RUN   TestAccLogicAppStandard_clientCertMode
=== PAUSE TestAccLogicAppStandard_clientCertMode
=== RUN   TestAccLogicAppStandard_elasticInstanceMinimum
=== PAUSE TestAccLogicAppStandard_elasticInstanceMinimum
=== RUN   TestAccLogicAppStandard_appScaleLimit
=== PAUSE TestAccLogicAppStandard_appScaleLimit
=== RUN   TestAccLogicAppStandard_runtimeScaleMonitoringEnabled
=== PAUSE TestAccLogicAppStandard_runtimeScaleMonitoringEnabled
=== RUN   TestAccLogicAppStandard_dotnetVersion4
=== PAUSE TestAccLogicAppStandard_dotnetVersion4
=== RUN   TestAccLogicAppStandard_dotnetVersion5
=== PAUSE TestAccLogicAppStandard_dotnetVersion5
=== RUN   TestAccLogicAppStandard_dotnetVersion6
=== PAUSE TestAccLogicAppStandard_dotnetVersion6
=== RUN   TestAccLogicAppStandard_dotnetVersion8
=== PAUSE TestAccLogicAppStandard_dotnetVersion8
=== RUN   TestAccLogicAppStandard_vNetIntegration
=== PAUSE TestAccLogicAppStandard_vNetIntegration
=== RUN   TestAccLogicAppStandard_vNetIntegrationUpdate
=== PAUSE TestAccLogicAppStandard_vNetIntegrationUpdate
=== RUN   TestAccLogicAppStandard_publicNetworkAccessEnabled
    logic_app_standard_resource_test.go:1060: skipping since `site_config.public_network_access_enabled` is removed in v5.0
--- SKIP: TestAccLogicAppStandard_publicNetworkAccessEnabled (0.00s)
=== RUN   TestAccLogicAppStandard_vnetContentShareEnabled
=== PAUSE TestAccLogicAppStandard_vnetContentShareEnabled
=== RUN   TestAccLogicAppStandard_keyVaultReferenceIdentity
=== PAUSE TestAccLogicAppStandard_keyVaultReferenceIdentity
=== CONT  TestAccLogicAppStandard_clientCertMode
=== CONT  TestAccLogicAppStandard_basic
=== CONT  TestAccLogicAppStandard_updateStorageAccountKey
=== CONT  TestAccLogicAppStandard_scmMinTlsVersion
=== CONT  TestAccLogicAppStandard_scmOneIpRestriction
=== CONT  TestAccLogicAppStandard_scmUseMainIpRestriction
=== CONT  TestAccLogicAppStandard_scmType
=== CONT  TestAccLogicAppStandard_manyIpRestrictions
--- PASS: TestAccLogicAppStandard_scmUseMainIpRestriction (273.52s)
=== CONT  TestAccLogicAppStandard_scmIpRestrictionUpdate
--- PASS: TestAccLogicAppStandard_basic (294.46s)
=== CONT  TestAccLogicAppStandard_scmIpRestrictionRemoved
--- PASS: TestAccLogicAppStandard_manyIpRestrictions (301.27s)
=== CONT  TestAccLogicAppStandard_ipRestrictionRemoved
--- PASS: TestAccLogicAppStandard_scmMinTlsVersion (318.95s)
=== CONT  TestAccLogicAppStandard_oneVNetSubnetIpRestriction
--- PASS: TestAccLogicAppStandard_scmType (331.35s)
=== CONT  TestAccLogicAppStandard_changeIpToServiceTagIpRestriction
--- PASS: TestAccLogicAppStandard_scmOneIpRestriction (443.24s)
=== CONT  TestAccLogicAppStandard_oneServiceTagIpRestriction
--- PASS: TestAccLogicAppStandard_updateStorageAccountKey (569.25s)
=== CONT  TestAccLogicAppStandard_oneIpRestriction
--- PASS: TestAccLogicAppStandard_oneVNetSubnetIpRestriction (269.87s)
=== CONT  TestAccLogicAppStandard_computedPreWarmedInstanceCount
--- PASS: TestAccLogicAppStandard_scmIpRestrictionRemoved (394.73s)
=== CONT  TestAccLogicAppStandard_preWarmedInstanceCount
--- PASS: TestAccLogicAppStandard_oneServiceTagIpRestriction (250.45s)
=== CONT  TestAccLogicAppStandard_ftpsState
--- PASS: TestAccLogicAppStandard_ipRestrictionRemoved (456.34s)
=== CONT  TestAccLogicAppStandard_minTlsVersion
--- PASS: TestAccLogicAppStandard_oneIpRestriction (247.61s)
=== CONT  TestAccLogicAppStandard_enableHttp2
--- PASS: TestAccLogicAppStandard_computedPreWarmedInstanceCount (253.98s)
=== CONT  TestAccLogicAppStandard_corsSettingsRemoved
--- PASS: TestAccLogicAppStandard_clientCertMode (859.46s)
=== CONT  TestAccLogicAppStandard_corsSettings
--- PASS: TestAccLogicAppStandard_changeIpToServiceTagIpRestriction (575.02s)
=== CONT  TestAccLogicAppStandard_userAssignedIdentity
--- PASS: TestAccLogicAppStandard_preWarmedInstanceCount (253.27s)
=== CONT  TestAccLogicAppStandard_updateIdentity
--- PASS: TestAccLogicAppStandard_scmIpRestrictionUpdate (710.20s)
=== CONT  TestAccLogicAppStandard_createIdentity
--- PASS: TestAccLogicAppStandard_ftpsState (299.61s)
=== CONT  TestAccLogicAppStandard_httpsOnly
--- PASS: TestAccLogicAppStandard_minTlsVersion (247.54s)
=== CONT  TestAccLogicAppStandard_3264bit
--- PASS: TestAccLogicAppStandard_enableHttp2 (248.16s)
=== CONT  TestAccLogicAppStandard_updateVersion
--- PASS: TestAccLogicAppStandard_corsSettings (264.66s)
=== CONT  TestAccLogicAppStandard_connectionStrings
--- PASS: TestAccLogicAppStandard_userAssignedIdentity (257.83s)
=== CONT  TestAccLogicAppStandard_healthCheck
--- PASS: TestAccLogicAppStandard_createIdentity (252.44s)
=== CONT  TestAccLogicAppStandard_siteConfig
--- PASS: TestAccLogicAppStandard_httpsOnly (246.62s)
=== CONT  TestAccLogicAppStandard_customShare
--- PASS: TestAccLogicAppStandard_updateIdentity (385.61s)
=== CONT  TestAccLogicAppStandard_appSettings
--- PASS: TestAccLogicAppStandard_corsSettingsRemoved (500.53s)
=== CONT  TestAccLogicAppStandard_tagsUpdate
--- PASS: TestAccLogicAppStandard_connectionStrings (250.04s)
=== CONT  TestAccLogicAppStandard_tags
--- PASS: TestAccLogicAppStandard_3264bit (381.90s)
=== CONT  TestAccLogicAppStandard_requiresImport
--- PASS: TestAccLogicAppStandard_healthCheck (248.69s)
=== CONT  TestAccLogicAppStandard_appSettingsVnetRouteAllEnabled
--- PASS: TestAccLogicAppStandard_updateVersion (395.17s)
=== CONT  TestAccLogicAppStandard_siteConfigVnetRouteAllEnabled
=== CONT  TestAccLogicAppStandard_extensionBundle
--- PASS: TestAccLogicAppStandard_siteConfig (244.38s)
--- PASS: TestAccLogicAppStandard_customShare (256.98s)
=== CONT  TestAccLogicAppStandard_containerized
--- PASS: TestAccLogicAppStandard_tagsUpdate (261.59s)
=== CONT  TestAccLogicAppStandard_publicNetworkAccessDisabled
--- PASS: TestAccLogicAppStandard_requiresImport (225.77s)
=== CONT  TestAccLogicAppStandard_publishBasicAuth
--- PASS: TestAccLogicAppStandard_tags (256.57s)
=== CONT  TestAccLogicAppStandard_completeUpdated
--- PASS: TestAccLogicAppStandard_appSettingsVnetRouteAllEnabled (258.74s)
=== CONT  TestAccLogicAppStandard_complete
--- PASS: TestAccLogicAppStandard_appSettings (381.91s)
=== CONT  TestAccLogicAppStandard_runtimeScaleMonitoringEnabled
--- PASS: TestAccLogicAppStandard_siteConfigVnetRouteAllEnabled (253.22s)
=== CONT  TestAccLogicAppStandard_dotnetVersion5
=== NAME  TestAccLogicAppStandard_publicNetworkAccessDisabled
    testcase.go:173: Step 1/9 error: Check failed: Check 3/3 error: azurerm_logic_app_standard.test: Attribute 'site_config.0.public_network_access_enabled' not found
--- PASS: TestAccLogicAppStandard_extensionBundle (262.53s)
=== CONT  TestAccLogicAppStandard_dotnetVersion4
--- PASS: TestAccLogicAppStandard_containerized (260.31s)
=== CONT  TestAccLogicAppStandard_appScaleLimit
--- FAIL: TestAccLogicAppStandard_publicNetworkAccessDisabled (164.56s)
=== CONT  TestAccLogicAppStandard_vNetIntegrationUpdate
--- PASS: TestAccLogicAppStandard_complete (271.75s)
=== CONT  TestAccLogicAppStandard_keyVaultReferenceIdentity
--- PASS: TestAccLogicAppStandard_runtimeScaleMonitoringEnabled (244.66s)
=== CONT  TestAccLogicAppStandard_vnetContentShareEnabled
--- PASS: TestAccLogicAppStandard_dotnetVersion5 (241.32s)
=== CONT  TestAccLogicAppStandard_vNetIntegration
--- PASS: TestAccLogicAppStandard_dotnetVersion4 (243.27s)
=== CONT  TestAccLogicAppStandard_dotnetVersion8
--- PASS: TestAccLogicAppStandard_appScaleLimit (275.98s)
=== CONT  TestAccLogicAppStandard_elasticInstanceMinimum
--- PASS: TestAccLogicAppStandard_completeUpdated (407.14s)
=== CONT  TestAccLogicAppStandard_dotnetVersion6
--- PASS: TestAccLogicAppStandard_publishBasicAuth (554.25s)
--- PASS: TestAccLogicAppStandard_vNetIntegration (272.65s)
--- PASS: TestAccLogicAppStandard_dotnetVersion8 (251.66s)
--- PASS: TestAccLogicAppStandard_elasticInstanceMinimum (256.22s)
--- PASS: TestAccLogicAppStandard_dotnetVersion6 (259.12s)
--- PASS: TestAccLogicAppStandard_vNetIntegrationUpdate (696.96s)
--- PASS: TestAccLogicAppStandard_vnetContentShareEnabled (512.55s)
--- PASS: TestAccLogicAppStandard_keyVaultReferenceIdentity (536.45s)
FAIL
FAIL    github.com/hashicorp/terraform-provider-azurerm/internal/services/logic 2480.109s
FAIL

In 5.0 mode we have one failure

=== NAME  TestAccLogicAppStandard_publicNetworkAccessDisabled
    testcase.go:173: Step 1/9 error: Check failed: Check 3/3 error: azurerm_logic_app_standard.test: Attribute 'site_config.0.public_network_access_enabled' not found

going to fix it on #30698 (it's still draft)