Skip to content

Conversation

atombrella
Copy link
Contributor

@atombrella atombrella commented Sep 25, 2025

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

This PR adds support for setting minimum_tls_version for azurerm_eventgrid_topic as requested in #30383

I am not sure if this field should be in the data source or not. My general gut feeling is that it shouldn't.

The property for the event grid domain topic can also be specified. The code to support this resource could be expanded.

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevant documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Testing and configuring an environment to do actual acceptance tests has not yet been done. I'll configure it later.

Change Log

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #30383

@atombrella atombrella force-pushed the feature/eventgrid_topic_min_tls_version_30383 branch from 69e3208 to d0b5d75 Compare September 25, 2025 18:20
@atombrella atombrella force-pushed the feature/eventgrid_topic_min_tls_version_30383 branch from edb143f to 9027a7b Compare September 25, 2025 19:47
@atombrella
Copy link
Contributor Author

atombrella commented Sep 27, 2025

@mplasch @RogerSward @AlexcFrench You can give a 👍 to get it prioritized by the maintainers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Event Grid Topic - TLS version setting
1 participant