Skip to content

Update CHANGELOG.md with 5.44.2 #19848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2024
Merged

Update CHANGELOG.md with 5.44.2 #19848

merged 1 commit into from
Oct 14, 2024

Conversation

@rileykarson
Copy link
Collaborator

@rileykarson rileykarson commented Oct 14, 2024

No description provided.

@github-actions github-actions bot requested a review from melinath October 14, 2024 23:28
@github-actions
Copy link

github-actions bot commented Oct 14, 2024

** WARNING **: This repository is generated by https://github.com/GoogleCloudPlatform/magic-modules. Any changes made directly to this repository will likely be overwritten. If you have further questions, please feel free to ping your reviewer or, internal employees, reach out to one of the engineers. Thank you!

@rileykarson rileykarson mentioned this pull request Oct 14, 2024
Merged
hao-nan-li
hao-nan-li reviewed Oct 14, 2024
View reviewed changes
CHANGELOG.md
@@ -1,5 +1,16 @@
## 6.8.0 (Unreleased)

## 5.44.2 (October 14, 2024)
Copy link
Collaborator

@hao-nan-li hao-nan-li Oct 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to keep this 5.44.2 changelog on top of the 6.xx.x? Or should we leave it on top of 5.44.1?

Copy link
Collaborator Author

@rileykarson rileykarson Oct 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally prefer chronological order, although I see 5.44.1 was different! I'm gonna split out the 4.X and 5.X changelogs soon anyways.

Copy link
Collaborator

@hao-nan-li hao-nan-li Oct 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rileykarson rileykarson merged commit ea2178d into main Oct 14, 2024
4 checks passed
@rileykarson rileykarson deleted the rileykarson-patch-3 branch October 14, 2024 23:59
@github-actions
Copy link

github-actions bot commented Nov 15, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@hao-nan-li hao-nan-li hao-nan-li approved these changes

@melinath melinath Awaiting requested review from melinath melinath is a code owner

Assignees

No one assigned

Labels

size/xs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rileykarson @hao-nan-li