[Feedback needed] Use OpenAPI v3 endopint for manifest schema discovery #2775
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollback Plan
If a change needs to be reverted, we will publish an updated version of the library.
Changes to Security Controls
I'm not sure if this is relevant for this section, but this change would mean that the Terraform user would no longer need CRD related permissions (unless the managed resources includes actual CRDs of course, i.e. addressing #1665).
Description
This PR changes the behavior of kubernetes_manifest schema discovery to prefer the
openapi/v3
endpoint over listing CRDs and falling back toopenapi/v3
. More Info in #2769. I will also add information here once it is decide how this new behavior should be controlled.Acceptance tests
I have not added any acceptance tests because this changes are tested by all the existing manifest acceptance tests.
Output from acceptance testing:
All manifest acceptance tests pass in my local setup against a kind cluster, with the only exception that the CertManager tests fails during cleanup. However, I get excatly the same problem when running the tests on
main
.Release Note
Release note for CHANGELOG:
References
Community Note