Allowed Module Version #20
Open
+59
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hcrhall
reviewed
Feb 22, 2023
Contributor
hcrhall
left a comment
hcrhall
left a comment
There was a problem hiding this comment.
@TroyFluegge do you have any tests for this policy?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an additional function to validate allowed module versions. This is a simplified option to check against a map of allowed modules and versions. It's not a whitelist of modules but a list of approved versions of modules. There are some more advance options in the
http-examplesthat validate against the PMR. Submitting this PR as another potential option.