BE-260: HashQL: Switch to bump allocator with scoping support #8218

indietyp · 2025-12-26T18:41:29Z

🌟 What is the purpose of this PR?

Replace bumpalo with bump-scope for arena allocation in hashql. This allows us to do intermediary allocations, such as in tight loops, without requiring a whole new allocator. Support for that has been in the works in bumpalo for a long time, without any progress. And bump-scope specifically I've had on my radar for 1+ years.

🔍 What does this change?

Replaces the bumpalo dependency with bump-scope for arena allocation
Refactors the BumpAllocator trait into two separate traits:
- BumpAllocator: Core bump allocation with scoped arenas and slice copying
- ResetAllocator: Adds bulk deallocation via reset
Adds support for scoped allocations with the new scoped method
Makes allocate_slice_copy infallible with a fallible try_allocate_slice_copy variant
Updates all implementations and callers to use the new API

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

does not modify any publishable blocks or libraries, or modifications do not need publishing

📜 Does this require a change to the docs?

The changes in this PR:

are internal and do not require a docs change

🕸️ Does this require a change to the Turbo Graph?

The changes in this PR:

do not affect the execution graph

🛡 What tests cover this?

Existing tests continue to cover the functionality, as this is primarily an internal implementation change.

❓ How to test this?

Run the existing test suite to verify that all functionality works with the new allocator
Verify that performance is maintained or improved with the new implementation

cursor · 2025-12-26T18:41:35Z

PR Summary

Switches HashQL’s arena allocator from bumpalo to bump-scope, enabling scoped sub-arenas and refining the allocator API.

Introduces BumpAllocator (now with scoped and slice copy APIs) and new ResetAllocator for bulk deallocation; updates blanket impls
Replaces internal allocator wrapper to use bump_scope::{Bump, BumpBox, BumpScope}; adds AllocatorScope for nested scopes
Updates Heap and Scratch to the new traits; removes old allocation-limit API; wires scoped and fallible try_allocate_slice_copy (with infallible allocate_slice_copy)
Refactors TransferInto to unify fallible/infallible paths; tweaks CloneIn/TryCloneIn for boxed slices
Propagates API changes across HashQL MIR passes, solver, benches, and tests (renaming trait bounds from BumpAllocator to ResetAllocator where needed)
Cargo: drop bumpalo, add bump-scope; adjust workspace deps

^{Written by Cursor Bugbot for commit a7e9d27. This will update automatically on new commits. Configure here.}

indietyp · 2025-12-26T18:42:10Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

codecov · 2025-12-26T18:47:10Z

Codecov Report

❌ Patch coverage is 50.50505% with 49 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.19%. Comparing base (b00cdae) to head (a7e9d27).

Files with missing lines	Patch %	Lines
libs/@local/hashql/core/src/heap/allocator.rs	57.14%	27 Missing ⚠️
libs/@local/hashql/core/src/heap/bump.rs	33.33%	8 Missing ⚠️
libs/@local/hashql/core/src/heap/clone.rs	0.00%	6 Missing ⚠️
libs/@local/hashql/core/src/heap/scratch.rs	0.00%	5 Missing ⚠️
libs/@local/hashql/core/src/heap/mod.rs	60.00%	2 Missing ⚠️
libs/@local/hashql/core/src/heap/transfer.rs	87.50%	1 Missing ⚠️

Additional details and impacted files

@@                                Coverage Diff                                @@
##           bm/be-259-hashql-write-type-system-benchmarks    #8218      +/-   ##
=================================================================================
- Coverage                                          59.23%   59.19%   -0.04%     
=================================================================================
  Files                                               1201     1201              
  Lines                                             114088   114153      +65     
  Branches                                            5062     5063       +1     
=================================================================================
+ Hits                                               67576    67577       +1     
- Misses                                             45734    45798      +64     
  Partials                                             778      778

Flag	Coverage Δ
apps.hash-ai-worker-ts	`1.32% <ø> (ø)`
apps.hash-api	`0.00% <ø> (ø)`
blockprotocol.type-system	`40.84% <ø> (ø)`
local.claude-hooks	`0.00% <ø> (ø)`
local.harpc-client	`51.24% <ø> (ø)`
local.hash-graph-sdk	`10.88% <ø> (ø)`
local.hash-isomorphic-utils	`0.00% <ø> (ø)`
rust.antsi	`0.00% <ø> (ø)`
rust.error-stack	`90.88% <ø> (ø)`
rust.harpc-codec	`84.70% <ø> (ø)`
rust.harpc-net	`96.14% <ø> (ø)`
rust.harpc-tower	`66.80% <ø> (ø)`
rust.harpc-types	`0.00% <ø> (ø)`
rust.harpc-wire-protocol	`92.23% <ø> (ø)`
rust.hash-codec	`72.76% <ø> (ø)`
rust.hash-graph-api	`2.89% <ø> (ø)`
rust.hash-graph-authorization	`62.47% <ø> (ø)`
rust.hash-graph-postgres-store	`25.61% <ø> (ø)`
rust.hash-graph-store	`30.54% <ø> (ø)`
rust.hash-graph-temporal-versioning	`47.95% <ø> (ø)`
rust.hash-graph-types	`0.00% <ø> (ø)`
rust.hash-graph-validation	`83.45% <ø> (ø)`
rust.hashql-ast	`87.25% <ø> (ø)`
rust.hashql-compiletest	`46.65% <ø> (ø)`
rust.hashql-core	`81.88% <50.50%> (-0.26%)`	⬇️
rust.hashql-diagnostics	`72.43% <ø> (ø)`
rust.hashql-eval	`68.54% <ø> (ø)`
rust.hashql-hir	`89.10% <ø> (ø)`
rust.hashql-mir	`88.51% <ø> (ø)`
rust.hashql-syntax-jexpr	`94.05% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

augmentcode · 2025-12-26T18:47:45Z

🤖 Augment PR Summary

Summary: Migrates HashQL’s arena allocation from bumpalo to bump-scope to enable nested/scoped sub-arenas for short-lived intermediate allocations.

Changes:

Replace bumpalo with bump-scope in hashql-core, including lockfile updates.
Rework the internal arena wrapper to support scoped allocation via a new AllocatorScope type.
Split the allocator API into BumpAllocator (scoping + slice copy) and ResetAllocator (bulk reset()).
Add scoped(..) support across allocators to rewind temporary allocations at scope exit.
Make allocate_slice_copy infallible (panic-on-OOM) and introduce try_allocate_slice_copy for fallible callers.
Update Heap/Scratch, transfer/clone utilities, and MIR passes/benches to use the new traits (notably requiring ResetAllocator where reset() is used).

Technical Notes: Scoped arenas provide a lightweight way to discard temporary allocations without resetting the entire allocator, while keeping existing bulk-reset behavior available via ResetAllocator.

_{🤖 Was this summary useful? React with 👍 or 👎}

augmentcode

Review completed. 2 suggestions posted.

Comment augment review to trigger a new review at any time.

libs/@local/hashql/core/src/heap/scratch.rs

libs/@local/hashql/core/src/heap/transfer.rs

codspeed-hq · 2025-12-26T18:49:15Z

CodSpeed Performance Report

Merging #8218 will not alter performance

_{Comparing bm/be-260-hashql-switch-internal-allocator-implementation-to-scoping (a7e9d27) with bm/be-259-hashql-write-type-system-benchmarks (b00cdae)}

Summary

✅ 29 untouched

Cargo.toml

github-actions · 2025-12-26T20:43:13Z

Benchmark results

@rust/hash-graph-benches – Integrations

policy_resolution_large

Function	Value	Mean	Flame graphs
resolve_policies_for_actor	user: empty, selectivity: high, policies: 2002	$$26.5 \mathrm{ms} \pm 223 \mathrm{μs}\left({\color{lightgreen}-5.250 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: empty, selectivity: low, policies: 1	$$3.20 \mathrm{ms} \pm 14.9 \mathrm{μs}\left({\color{gray}-2.397 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: empty, selectivity: medium, policies: 1001	$$12.5 \mathrm{ms} \pm 76.8 \mathrm{μs}\left({\color{lightgreen}-9.468 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: seeded, selectivity: high, policies: 3314	$$42.3 \mathrm{ms} \pm 276 \mathrm{μs}\left({\color{gray}-1.428 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: seeded, selectivity: low, policies: 1	$$14.2 \mathrm{ms} \pm 93.2 \mathrm{μs}\left({\color{gray}0.359 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: seeded, selectivity: medium, policies: 1526	$$23.6 \mathrm{ms} \pm 150 \mathrm{μs}\left({\color{gray}-1.093 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: system, selectivity: high, policies: 2078	$$26.5 \mathrm{ms} \pm 190 \mathrm{μs}\left({\color{lightgreen}-38.710 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: system, selectivity: low, policies: 1	$$3.63 \mathrm{ms} \pm 21.2 \mathrm{μs}\left({\color{lightgreen}-81.810 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: system, selectivity: medium, policies: 1033	$$11.3 \mathrm{ms} \pm 86.5 \mathrm{μs}\left({\color{lightgreen}-59.309 \mathrm{\%}}\right) $$	Flame Graph

policy_resolution_medium

Function	Value	Mean	Flame graphs
resolve_policies_for_actor	user: empty, selectivity: high, policies: 102	$$3.64 \mathrm{ms} \pm 19.2 \mathrm{μs}\left({\color{gray}-1.705 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: empty, selectivity: low, policies: 1	$$2.85 \mathrm{ms} \pm 13.9 \mathrm{μs}\left({\color{gray}0.661 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: empty, selectivity: medium, policies: 51	$$3.24 \mathrm{ms} \pm 23.3 \mathrm{μs}\left({\color{gray}1.31 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: seeded, selectivity: high, policies: 269	$$4.95 \mathrm{ms} \pm 24.3 \mathrm{μs}\left({\color{gray}-0.999 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: seeded, selectivity: low, policies: 1	$$3.42 \mathrm{ms} \pm 30.7 \mathrm{μs}\left({\color{gray}1.42 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: seeded, selectivity: medium, policies: 107	$$3.94 \mathrm{ms} \pm 18.3 \mathrm{μs}\left({\color{gray}-0.390 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: system, selectivity: high, policies: 133	$$4.21 \mathrm{ms} \pm 19.0 \mathrm{μs}\left({\color{lightgreen}-6.382 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: system, selectivity: low, policies: 1	$$3.29 \mathrm{ms} \pm 14.8 \mathrm{μs}\left({\color{gray}-0.283 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: system, selectivity: medium, policies: 63	$$3.83 \mathrm{ms} \pm 17.6 \mathrm{μs}\left({\color{gray}-1.125 \mathrm{\%}}\right) $$	Flame Graph

policy_resolution_none

Function	Value	Mean	Flame graphs
resolve_policies_for_actor	user: empty, selectivity: high, policies: 2	$$2.59 \mathrm{ms} \pm 12.9 \mathrm{μs}\left({\color{red}6.53 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: empty, selectivity: low, policies: 1	$$2.50 \mathrm{ms} \pm 10.0 \mathrm{μs}\left({\color{gray}3.73 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: empty, selectivity: medium, policies: 1	$$2.65 \mathrm{ms} \pm 12.7 \mathrm{μs}\left({\color{gray}4.14 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: system, selectivity: high, policies: 8	$$2.81 \mathrm{ms} \pm 13.2 \mathrm{μs}\left({\color{red}5.62 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: system, selectivity: low, policies: 1	$$2.71 \mathrm{ms} \pm 12.6 \mathrm{μs}\left({\color{red}6.76 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: system, selectivity: medium, policies: 3	$$2.92 \mathrm{ms} \pm 14.4 \mathrm{μs}\left({\color{gray}2.07 \mathrm{\%}}\right) $$	Flame Graph

policy_resolution_small

Function	Value	Mean	Flame graphs
resolve_policies_for_actor	user: empty, selectivity: high, policies: 52	$$2.90 \mathrm{ms} \pm 10.5 \mathrm{μs}\left({\color{gray}4.99 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: empty, selectivity: low, policies: 1	$$2.60 \mathrm{ms} \pm 10.1 \mathrm{μs}\left({\color{red}7.25 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: empty, selectivity: medium, policies: 25	$$2.78 \mathrm{ms} \pm 11.2 \mathrm{μs}\left({\color{red}8.14 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: seeded, selectivity: high, policies: 94	$$3.24 \mathrm{ms} \pm 14.3 \mathrm{μs}\left({\color{red}5.08 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: seeded, selectivity: low, policies: 1	$$2.84 \mathrm{ms} \pm 11.7 \mathrm{μs}\left({\color{red}6.21 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: seeded, selectivity: medium, policies: 26	$$3.04 \mathrm{ms} \pm 12.1 \mathrm{μs}\left({\color{red}5.16 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: system, selectivity: high, policies: 66	$$3.18 \mathrm{ms} \pm 17.5 \mathrm{μs}\left({\color{gray}4.97 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: system, selectivity: low, policies: 1	$$2.80 \mathrm{ms} \pm 12.3 \mathrm{μs}\left({\color{red}6.78 \mathrm{\%}}\right) $$	Flame Graph
resolve_policies_for_actor	user: system, selectivity: medium, policies: 29	$$3.06 \mathrm{ms} \pm 18.5 \mathrm{μs}\left({\color{red}6.47 \mathrm{\%}}\right) $$	Flame Graph

read_scaling_complete

Function	Value	Mean	Flame graphs
entity_by_id;one_depth	1 entities	$$38.5 \mathrm{ms} \pm 159 \mathrm{μs}\left({\color{gray}-0.314 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id;one_depth	10 entities	$$55.4 \mathrm{ms} \pm 248 \mathrm{μs}\left({\color{lightgreen}-26.620 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id;one_depth	25 entities	$$43.4 \mathrm{ms} \pm 156 \mathrm{μs}\left({\color{gray}-0.032 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id;one_depth	5 entities	$$45.1 \mathrm{ms} \pm 168 \mathrm{μs}\left({\color{gray}0.310 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id;one_depth	50 entities	$$53.9 \mathrm{ms} \pm 298 \mathrm{μs}\left({\color{gray}3.59 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id;two_depth	1 entities	$$40.6 \mathrm{ms} \pm 161 \mathrm{μs}\left({\color{gray}1.26 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id;two_depth	10 entities	$$219 \mathrm{ms} \pm 676 \mathrm{μs}\left({\color{lightgreen}-47.361 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id;two_depth	25 entities	$$93.7 \mathrm{ms} \pm 497 \mathrm{μs}\left({\color{gray}0.250 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id;two_depth	5 entities	$$83.4 \mathrm{ms} \pm 267 \mathrm{μs}\left({\color{gray}0.406 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id;two_depth	50 entities	$$281 \mathrm{ms} \pm 788 \mathrm{μs}\left({\color{lightgreen}-9.803 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id;zero_depth	1 entities	$$14.4 \mathrm{ms} \pm 88.1 \mathrm{μs}\left({\color{gray}-3.730 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id;zero_depth	10 entities	$$14.8 \mathrm{ms} \pm 66.4 \mathrm{μs}\left({\color{gray}1.64 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id;zero_depth	25 entities	$$15.1 \mathrm{ms} \pm 79.8 \mathrm{μs}\left({\color{gray}2.19 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id;zero_depth	5 entities	$$14.6 \mathrm{ms} \pm 78.1 \mathrm{μs}\left({\color{gray}0.750 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id;zero_depth	50 entities	$$18.1 \mathrm{ms} \pm 90.4 \mathrm{μs}\left({\color{gray}1.61 \mathrm{\%}}\right) $$	Flame Graph

read_scaling_linkless

Function	Value	Mean	Flame graphs
entity_by_id	1 entities	$$15.0 \mathrm{ms} \pm 84.3 \mathrm{μs}\left({\color{gray}-0.772 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	10 entities	$$14.7 \mathrm{ms} \pm 65.1 \mathrm{μs}\left({\color{gray}1.78 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	100 entities	$$14.8 \mathrm{ms} \pm 64.5 \mathrm{μs}\left({\color{gray}1.01 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	1000 entities	$$15.3 \mathrm{ms} \pm 78.4 \mathrm{μs}\left({\color{gray}-0.187 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	10000 entities	$$22.8 \mathrm{ms} \pm 171 \mathrm{μs}\left({\color{gray}4.52 \mathrm{\%}}\right) $$	Flame Graph

representative_read_entity

Function	Value	Mean	Flame graphs
entity_by_id	entity type ID: `https://blockprotocol.org/@alice/types/entity-type/block/v/1`	$$31.1 \mathrm{ms} \pm 316 \mathrm{μs}\left({\color{red}8.26 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	entity type ID: `https://blockprotocol.org/@alice/types/entity-type/book/v/1`	$$29.5 \mathrm{ms} \pm 303 \mathrm{μs}\left({\color{gray}1.67 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	entity type ID: `https://blockprotocol.org/@alice/types/entity-type/building/v/1`	$$30.4 \mathrm{ms} \pm 329 \mathrm{μs}\left({\color{red}5.43 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	entity type ID: `https://blockprotocol.org/@alice/types/entity-type/organization/v/1`	$$30.3 \mathrm{ms} \pm 311 \mathrm{μs}\left({\color{red}5.03 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	entity type ID: `https://blockprotocol.org/@alice/types/entity-type/page/v/2`	$$29.6 \mathrm{ms} \pm 282 \mathrm{μs}\left({\color{gray}-1.520 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	entity type ID: `https://blockprotocol.org/@alice/types/entity-type/person/v/1`	$$30.9 \mathrm{ms} \pm 300 \mathrm{μs}\left({\color{red}7.77 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	entity type ID: `https://blockprotocol.org/@alice/types/entity-type/playlist/v/1`	$$31.1 \mathrm{ms} \pm 365 \mathrm{μs}\left({\color{red}5.86 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	entity type ID: `https://blockprotocol.org/@alice/types/entity-type/song/v/1`	$$29.9 \mathrm{ms} \pm 263 \mathrm{μs}\left({\color{gray}2.08 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	entity type ID: `https://blockprotocol.org/@alice/types/entity-type/uk-address/v/1`	$$29.6 \mathrm{ms} \pm 272 \mathrm{μs}\left({\color{gray}0.455 \mathrm{\%}}\right) $$	Flame Graph

representative_read_entity_type

Function	Value	Mean	Flame graphs
get_entity_type_by_id	Account ID: `bf5a9ef5-dc3b-43cf-a291-6210c0321eba`	$$8.12 \mathrm{ms} \pm 35.1 \mathrm{μs}\left({\color{gray}1.92 \mathrm{\%}}\right) $$	Flame Graph

representative_read_multiple_entities

Function	Value	Mean	Flame graphs
entity_by_property	traversal_paths=0	0	$$46.2 \mathrm{ms} \pm 224 \mathrm{μs}\left({\color{gray}2.24 \mathrm{\%}}\right) $$
entity_by_property	traversal_paths=255	1,resolve_depths=inherit:1;values:255;properties:255;links:127;link_dests:126;type:true	$$95.9 \mathrm{ms} \pm 405 \mathrm{μs}\left({\color{gray}-1.019 \mathrm{\%}}\right) $$
entity_by_property	traversal_paths=2	1,resolve_depths=inherit:0;values:0;properties:0;links:0;link_dests:0;type:false	$$54.5 \mathrm{ms} \pm 333 \mathrm{μs}\left({\color{gray}3.03 \mathrm{\%}}\right) $$
entity_by_property	traversal_paths=2	1,resolve_depths=inherit:0;values:0;properties:0;links:1;link_dests:0;type:true	$$60.5 \mathrm{ms} \pm 330 \mathrm{μs}\left({\color{gray}-0.229 \mathrm{\%}}\right) $$
entity_by_property	traversal_paths=2	1,resolve_depths=inherit:0;values:0;properties:2;links:1;link_dests:0;type:true	$$69.4 \mathrm{ms} \pm 358 \mathrm{μs}\left({\color{gray}-1.408 \mathrm{\%}}\right) $$
entity_by_property	traversal_paths=2	1,resolve_depths=inherit:0;values:2;properties:2;links:1;link_dests:0;type:true	$$76.8 \mathrm{ms} \pm 281 \mathrm{μs}\left({\color{gray}-0.721 \mathrm{\%}}\right) $$
link_by_source_by_property	traversal_paths=0	0	$$50.8 \mathrm{ms} \pm 361 \mathrm{μs}\left({\color{gray}-3.893 \mathrm{\%}}\right) $$
link_by_source_by_property	traversal_paths=255	1,resolve_depths=inherit:1;values:255;properties:255;links:127;link_dests:126;type:true	$$77.3 \mathrm{ms} \pm 427 \mathrm{μs}\left({\color{gray}-1.428 \mathrm{\%}}\right) $$
link_by_source_by_property	traversal_paths=2	1,resolve_depths=inherit:0;values:0;properties:0;links:0;link_dests:0;type:false	$$57.3 \mathrm{ms} \pm 312 \mathrm{μs}\left({\color{gray}-3.987 \mathrm{\%}}\right) $$
link_by_source_by_property	traversal_paths=2	1,resolve_depths=inherit:0;values:0;properties:0;links:1;link_dests:0;type:true	$$66.4 \mathrm{ms} \pm 435 \mathrm{μs}\left({\color{gray}-2.053 \mathrm{\%}}\right) $$
link_by_source_by_property	traversal_paths=2	1,resolve_depths=inherit:0;values:0;properties:2;links:1;link_dests:0;type:true	$$67.2 \mathrm{ms} \pm 348 \mathrm{μs}\left({\color{gray}0.601 \mathrm{\%}}\right) $$
link_by_source_by_property	traversal_paths=2	1,resolve_depths=inherit:0;values:2;properties:2;links:1;link_dests:0;type:true	$$67.6 \mathrm{ms} \pm 431 \mathrm{μs}\left({\color{gray}2.32 \mathrm{\%}}\right) $$

scenarios

Function	Value	Mean	Flame graphs
full_test	query-limited	$$137 \mathrm{ms} \pm 441 \mathrm{μs}\left({\color{gray}2.86 \mathrm{\%}}\right) $$	Flame Graph
full_test	query-unlimited	$$140 \mathrm{ms} \pm 460 \mathrm{μs}\left({\color{gray}4.07 \mathrm{\%}}\right) $$	Flame Graph
linked_queries	query-limited	$$39.8 \mathrm{ms} \pm 203 \mathrm{μs}\left({\color{lightgreen}-61.994 \mathrm{\%}}\right) $$	Flame Graph
linked_queries	query-unlimited	$$588 \mathrm{ms} \pm 1.12 \mathrm{ms}\left({\color{gray}3.35 \mathrm{\%}}\right) $$	Flame Graph

indietyp added 3 commits December 26, 2025 18:08

feat: add infallible allocate method

d28b2b4

feat: unify transfer functions

c44530b

feat: ResetAllocator

96bcb96

graphite-app bot assigned indietyp Dec 26, 2025

github-actions bot added area/deps Relates to third-party dependencies (area) area/libs Relates to first-party libraries/crates/packages (area) type/eng > backend Owned by the @backend team labels Dec 26, 2025

indietyp changed the title ~~BE-260: Use scoped bump allocator~~ BE-260: HashQL: Switch to bump allocator with scoping support Dec 26, 2025

vercel bot deployed to Preview – petrinaut December 26, 2025 18:46 View deployment

augmentcode bot reviewed Dec 26, 2025

View reviewed changes

libs/@local/hashql/core/src/heap/scratch.rs Outdated Show resolved Hide resolved

libs/@local/hashql/core/src/heap/transfer.rs Outdated Show resolved Hide resolved

indietyp added 2 commits December 26, 2025 19:51

chore: reduce nightly dependence

44c91b0

chore: comment

c606c22

vercel bot temporarily deployed to Preview – petrinaut December 26, 2025 18:53 Inactive

graphite-app bot reviewed Dec 26, 2025

View reviewed changes

Cargo.toml Outdated Show resolved Hide resolved

vercel bot deployed to Preview – hash December 26, 2025 19:05 View deployment

chore: remove bumpalo

a7e9d27

vercel bot deployed to Preview – hashdotdesign December 26, 2025 19:36 View deployment

vercel bot deployed to Preview – petrinaut December 26, 2025 19:38 View deployment

vercel bot deployed to Preview – hash December 26, 2025 19:45 View deployment

BE-260: HashQL: Switch to bump allocator with scoping support #8218

Are you sure you want to change the base?

BE-260: HashQL: Switch to bump allocator with scoping support #8218

Uh oh!

Conversation

indietyp commented Dec 26, 2025

🌟 What is the purpose of this PR?

🔍 What does this change?

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

📜 Does this require a change to the docs?

🕸️ Does this require a change to the Turbo Graph?

🛡 What tests cover this?

❓ How to test this?

Uh oh!

cursor bot commented Dec 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

Uh oh!

indietyp commented Dec 26, 2025

Uh oh!

codecov bot commented Dec 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

augmentcode bot commented Dec 26, 2025

Uh oh!

augmentcode bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

codspeed-hq bot commented Dec 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #8218 will not alter performance

Summary

Uh oh!

Uh oh!

github-actions bot commented Dec 26, 2025

Benchmark results

@rust/hash-graph-benches – Integrations

policy_resolution_large

policy_resolution_medium

policy_resolution_none

policy_resolution_small

read_scaling_complete

read_scaling_linkless

representative_read_entity

representative_read_entity_type

representative_read_multiple_entities

scenarios

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

cursor bot commented Dec 26, 2025 •

edited

Loading

codecov bot commented Dec 26, 2025 •

edited

Loading

codspeed-hq bot commented Dec 26, 2025 •

edited

Loading