Add Hashable instances for Data.Semigroup.{Sum,Product}.#326
Open
jonathanknowles wants to merge 1 commit intohaskell-unordered-containers:masterfrom
Conversation
jonathanknowles
commented
Oct 20, 2025
| deriving newtype instance Hashable a => Hashable (Semi.Max a) | ||
|
|
||
| deriving newtype instance Hashable a => Hashable (Semi.Sum a) | ||
| deriving newtype instance Hashable a => Hashable (Semi.Product a) |
Author
There was a problem hiding this comment.
I'd be happy to also add:
- a
@since <version number>for each new instance - an accompanying
CHANGELOGentry
Though what version should be listed? (I notice that some repositories use "unreleased" as a placeholder for the eventual version number.)
Author
|
@phadej Friendly ping on this PR — just checking whether this change is acceptable or if there's anything you'd like adjusted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
Hashableinstances for:Data.Semigroup.SumData.Semigroup.Product