Fix ClientSSLTest Certificate
#1535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emreyigit
approved these changes
Apr 28, 2025
This was referenced May 14, 2025
JackPGreen
added a commit
to hazelcast/client-compatibility-suites
that referenced
this pull request
May 23, 2025
Outdated certificates caused a [test failure](https://github.com/hazelcast/client-compatibility-suites/actions/runs/14998179569/job/42138824244). There was [an action](https://github.com/hazelcast/hazelcast-python-client/actions/runs/14766960347/workflow) to update these automatically in the repo, but due to new branch protection [it's failing](https://github.com/hazelcast/hazelcast-python-client/actions/runs/14766960347/job/41460207509). Rather than update the source code, we can simply hot-replace the certificates before we test as per hazelcast/hazelcast-nodejs-client#1535. [Example execution](https://github.com/hazelcast/client-compatibility-suites/actions/runs/15025997762). Post-merge actions: - [ ] disable [the action](https://github.com/hazelcast/hazelcast-python-client/actions/runs/14766960347/workflow)
JackPGreen
added a commit
to hazelcast/client-compatibility-suites
that referenced
this pull request
Jul 3, 2025
The [NodeJS tests are failing](https://github.com/hazelcast/client-compatibility-suites/actions/runs/16021764635/job/45200929188): > WARN at ConnectionManager: Error during initial connection to 127.0.0.1:34513 Error: certificate has expired Same issue (and solution - albeit slightly reworked) as hazelcast/hazelcast-nodejs-client#1535
JackPGreen
added a commit
to hazelcast/client-compatibility-suites
that referenced
this pull request
Jul 3, 2025
The [NodeJS tests are failing](https://github.com/hazelcast/client-compatibility-suites/actions/runs/16021764635/job/45200929188): > WARN at ConnectionManager: Error during initial connection to 127.0.0.1:34513 Error: certificate has expired Same issue (and solution - albeit slightly reworked) as hazelcast/hazelcast-nodejs-client#1535
JackPGreen
added a commit
to hazelcast/client-compatibility-suites
that referenced
this pull request
Jul 3, 2025
The [NodeJS tests are failing](https://github.com/hazelcast/client-compatibility-suites/actions/runs/16021764635/job/45200929188): > WARN at ConnectionManager: Error during initial connection to 127.0.0.1:34513 Error: certificate has expired Same issue (and solution - albeit slightly reworked) as hazelcast/hazelcast-nodejs-client#1535
JackPGreen
added a commit
to hazelcast/client-compatibility-suites
that referenced
this pull request
Jul 3, 2025
The [NodeJS tests are failing](https://github.com/hazelcast/client-compatibility-suites/actions/runs/16021764635/job/45200929188): > WARN at ConnectionManager: Error during initial connection to 127.0.0.1:34513 Error: certificate has expired Same issue (and solution - albeit slightly reworked) as hazelcast/hazelcast-nodejs-client#1535 [Example execution](https://github.com/hazelcast/client-compatibility-suites/actions/runs/16051905507).
JackPGreen
added a commit
to hazelcast/client-compatibility-suites
that referenced
this pull request
Jul 7, 2025
The [NodeJS tests are failing](https://github.com/hazelcast/client-compatibility-suites/actions/runs/16021764635/job/45200929188): > WARN at ConnectionManager: Error during initial connection to 127.0.0.1:34513 Error: certificate has expired Same issue (and solution - albeit slightly reworked) as hazelcast/hazelcast-nodejs-client#1535 [Example execution](https://github.com/hazelcast/client-compatibility-suites/actions/runs/16051905507).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nightly tests are failing:
The certificates were manually updated in #1525, but the upstream source is updated automatically and so they have become outdated.
We already download the upstream source as part of the action anyway, so updated to overwrite the existing
keystore.jkswith the latest version.Example execution showing success of
ClientSSLTest(other test failures out of scope).