Skip to content

Conversation

JackPGreen
Copy link
Contributor

@JackPGreen JackPGreen commented Sep 18, 2025

While investigating a build failure I noticed several areas of improvement:

  • The download-rc.js file duplicates the code for downloading each JAR
    • should be centralised
  • Log messages are not correct, prints both regardless:
    • Starting Remote Controller ... enterprise ...
    • Starting Hazelcast Remote Controller ... oss ...
  • The RCD logs are not viewable during a PR builder execution (making debugging startup failures tricky)

@JackPGreen JackPGreen changed the title Fix PR builder Refactor download-rc.js Sep 18, 2025
Copy link

codecov bot commented Sep 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.43%. Comparing base (67b3f7a) to head (f715110).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1553      +/-   ##
==========================================
- Coverage   93.46%   93.43%   -0.03%     
==========================================
  Files         466      466              
  Lines       16628    16628              
  Branches     1350     1350              
==========================================
- Hits        15541    15537       -4     
- Misses        796      797       +1     
- Partials      291      294       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JackPGreen JackPGreen self-assigned this Sep 18, 2025
@JackPGreen JackPGreen changed the title Refactor download-rc.js Improve PR builder Sep 18, 2025
@JackPGreen JackPGreen marked this pull request as ready for review September 18, 2025 14:11
Copy link

@nishaatr nishaatr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me
Good change!

@JackPGreen JackPGreen merged commit 8b15ae1 into hazelcast:master Sep 18, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants