-
Notifications
You must be signed in to change notification settings - Fork 63
Improve PR builder #1553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve PR builder #1553
Conversation
7909653
to
aab6423
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1553 +/- ##
==========================================
- Coverage 93.46% 93.43% -0.03%
==========================================
Files 466 466
Lines 16628 16628
Branches 1350 1350
==========================================
- Hits 15541 15537 -4
- Misses 796 797 +1
- Partials 291 294 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok to me
Good change!
While investigating a build failure I noticed several areas of improvement:
download-rc.js
file duplicates the code for downloading each JARStarting Remote Controller ... enterprise ...
Starting Hazelcast Remote Controller ... oss ...