drivers/video: Improve IT66021 EDID definitions and add new DTDs#601
Open
Strykar wants to merge 2 commits intohd-zero:mainfrom
Open
drivers/video: Improve IT66021 EDID definitions and add new DTDs#601Strykar wants to merge 2 commits intohd-zero:mainfrom
Strykar wants to merge 2 commits intohd-zero:mainfrom
Conversation
This patch refactors the IT66021 HDMI transmitter's hardcoded EDID array to improve maintainability and memory efficiency, while adding support for two new video timings. Functional Changes Replaces two redundant Detailed Timing Descriptors (DTDs) in the CEA Extension block with: 1280x720 @ 50 Hz (replaces duplicated 720p60) 960x720 @ 100 Hz (CVT-RB) (replaces duplicated 1080p60) The base EDID and previously supported fundamental timings (1080p60, 720p60) remain completely intact and unaffected. Technical Enhancements Memory Optimization: Added the static modifier to the 256-byte EDID array. Previously, the lack of this modifier forced the compiler to dynamically allocate and populate this.
The inner loop in IT66021_Get_VTMG() reads r9a[j+1] while iterating j from IT66121_9A_READ_N - 1, which can access one element past the end of the array. This change adjusts the loop bound to prevent out-of-bounds access while preserving the existing sorting behavior. Is a full refactor necessary to address the bounds violation?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch (originally at #591) refactors the IT66021 HDMI hardcoded EDID array to improve maintainability and memory efficiency, while adding support for two new video timings.
Using designated initializers makes the checksum location explicit and prevents accidental misplacement if the EDID contents are edited later.
Functional Changes
Replaces two redundant Detailed Timing Descriptors (DTDs) in the CEA Extension block with:
The base EDID and previously supported fundamental timings (1080p60, 720p60) remain completely intact and unaffected.
Technical Enhancements
Memory Optimization: Added the static modifier to the 256-byte EDID array. Previously, the lack of this modifier forced the compiler to dynamically allocate and populate this.