CAS support for Hector#671
Open
woolfel wants to merge 4 commits intohector-client:masterfrom
woolfel:master
Open
CAS support for Hector#671woolfel wants to merge 4 commits intohector-client:masterfrom woolfel:master
woolfel wants to merge 4 commits intohector-client:masterfrom
woolfel:master
Conversation
Got CAS support working in hector. need to clean up the unit test before I check it in.
added test case
added serial and local serial
there wasn't an alias for date type, so I added one for DynamicComposite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I finally got time to work on CAS support and finished it. There's 1 unit test for it in MutatorTest and it passes. A couple of general thoughts about CAS. They way it was added to Cassandra feels like a "bolt-on", as a result it does feel a bit "out of place" with the existing Mutator interface. Basically it feels like a "bolt-on" since that's basically what I did to minimize the impact of adding support.