Make grammar::Error more verbose. #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The carried `libloading::Error` is useful to debug actual issues occurring on
dependent projects — I had to adapt a bit of code in kak-tree-sitter to pinpoint
an issue while loading grammars with the wrong symbol (I was still trying to read
tree_sitter_<lang> while the API of tree-house sets the prefix on its own), and I
could have seen that right away if the {err} was present in the Display impl.
the-mikedavis
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The carried
libloading::Erroris useful to debug actual issues occurring on dependent projects — I had to adapt a bit of code in kak-tree-sitter to pinpoint an issue while loading grammars with the wrong symbol (I was still trying to read tree_sitter_ while the API of tree-house sets the prefix on its own), and I could have seen that right away if the {err} was present in the Display impl.Context.