feat: add basic type assertions and adjust to API change #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for SPDX BOM format alongside the existing CDX BOM format, including basic type assertions for BOM validation. The changes introduce SPDX23 types, create validation functions to distinguish between BOM formats, and fix an API response structure.
- Added SPDX23 type support and SupportedBom union type
- Created validation functions for CDX and SPDX BOM detection
- Fixed API response structure in EolReportQueryResponse
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/types/index.mts | Adds SPDX23 import and exports new union type SupportedBom |
| src/types/eol-scan.mts | Fixes nested property name from 'result' to 'report' in API response |
| src/index.mts | Exports new SPDX types and validation functions |
| src/bom/validation.mts | Implements type assertion functions for BOM format detection |
sunshastry
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.