Add methods to DefaultFlushEntityEventListener for Hibernate Reactive #11475
+15
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! This pull request does not follow the contribution rules. Could you have a look? ❌ All commit messages should start with a JIRA issue key matching pattern › This message was automatically generated. |
gavinking
reviewed
Dec 18, 2025
| } | ||
|
|
||
| // Used by Hibernate Reactive | ||
| protected void logIdentifiedAltered(EntityPersister persister, Object entryId, Object currentId) { |
Member
Author
There was a problem hiding this comment.
Hi @gavinking, right I really chose a bad method name :(
probably just IdentifiedAltered can work, what do you think?
Member
There was a problem hiding this comment.
checkIdentifierUnchanged() or checkIdentifierUnmodified() ?
Member
Author
There was a problem hiding this comment.
the check has been done before the call to this method, what about throwIdentifiedAlteredException ?
dreab8
force-pushed
the
DefaultFlushEntityEventListenerChangesForReactive_72
branch
from
40c54ad to
3f3c39e
Compare
dreab8
force-pushed
the
DefaultFlushEntityEventListenerChangesForReactive_72
branch
from
3f3c39e to
8bedd0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Please describe here what your change is about]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.