Skip to content

Conversation

@ibankov
Copy link
Contributor

@ibankov ibankov commented Sep 17, 2025

Description:
DRAFT

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@ibankov ibankov added this to the v0.67 milestone Sep 17, 2025
@ibankov ibankov changed the title enable TransactionRecordParityValidator for EmbeddedNetwork test: enable TransactionRecordParityValidator for EmbeddedNetwork Sep 17, 2025
@lfdt-bot
Copy link

lfdt-bot commented Sep 17, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

@github-actions
Copy link

github-actions bot commented Sep 17, 2025

Node: Unit Test Results

  1 867 files  ±0        1 errors  1 866 suites   - 1   2h 46m 14s ⏱️ - 4m 15s
156 055 tests  - 1  155 991 ✅  - 1  64 💤 ±0  0 ❌ ±0 
162 894 runs   - 1  162 830 ✅  - 1  64 💤 ±0  0 ❌ ±0 

For more details on these parsing errors, see this check.

Results for commit 35185bb. ± Comparison against base commit 83908f3.

This pull request removes 446 and adds 208 tests. Note that renamed tests count towards both.

  
             IssuerDN: CN=s-node1
            SubjectDN: CN=s-node1
           Final Date: Fri Jan 01 00:00:00 GMT 2100
           Public Key: RSA Public Key [2e:28:bc:1e:d3:83:25:92:8e:cb:98:b1:b6:84:06:9c:d5:d8:14:d5],[56:66:d1:a4]
           Start Date: Sat Jan 01 00:00:00 GMT 2000
         SerialNumber: 12482092706667292405
        modulus: c1a0ff5d2372b53d12d12bb87dd03f…
        modulus: c1a0ff5d2372b53d12d12bb87dd03…
…
com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [4] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [6] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [7]   
  
com.hedera.node.app.state.merkle.StateMetadataTest ‑ [11] 

com.hedera.node.app.state.merkle.StateMetadataTest ‑ [203] Some Legal Characters 

com.hedera.node.app.state.merkle.StateMetadataTest ‑ [395] 
 Some Legal Characters
com.hedera.node.app.state.recordcache.RecordCacheImplTest$ReceiptQueryTests ‑ [10] INVALID_TRANSACTION_ID
com.hedera.node.app.state.recordcache.RecordCacheImplTest$ReceiptQueryTests ‑ [11] FAIL_FEE
com.hedera.node.app.state.recordcache.RecordCacheImplTest$ReceiptQueryTests ‑ [13] RECORD_NOT_FOUND
com.hedera.node.app.state.recordcache.RecordCacheImplTest$ReceiptQueryTests ‑ [15] SUCCESS
…

♻️ This comment has been updated with latest results.

@codacy-production
Copy link

codacy-production bot commented Sep 17, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (b4b4fab) 103177 77556 75.17%
Head commit (78e3343) 103389 (+212) 77716 (+160) 75.17% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#21103) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@codecov
Copy link

codecov bot commented Sep 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Impacted file tree graph

@@            Coverage Diff             @@
##               main   #21103    +/-   ##
==========================================
  Coverage     71.23%   71.23%            
- Complexity    24191    24225    +34     
==========================================
  Files          2669     2670     +1     
  Lines        103272   103488   +216     
  Branches      10748    10775    +27     
==========================================
+ Hits          73564    73719   +155     
- Misses        25670    25726    +56     
- Partials       4038     4043     +5     

see 37 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: ibankov <[email protected]>
Signed-off-by: ibankov <[email protected]>
Signed-off-by: ibankov <[email protected]>
@github-actions
Copy link

github-actions bot commented Sep 18, 2025

Node: HAPI Test (Misc) Results

  192 files  +   10      1 errors  191 suites  +9   12m 25s ⏱️ - 6m 33s
  339 tests +  175    332 ✅ +  168  1 💤 +1  6 ❌ +6 
1 738 runs  +1 112  1 730 ✅ +1 104  1 💤 +1  7 ❌ +7 

For more details on these parsing errors and failures, see this check.

Results for commit 4743a08. ± Comparison against base commit 83908f3.

This pull request removes 51 and adds 226 tests. Note that renamed tests count towards both.
com.hedera.services.bdd.suites.contract.ethereum.JumboTransactionsEnabledTest$JumboEthereumTransactionsNegativeTests ‑ as written
com.hedera.services.bdd.suites.contract.ethereum.JumboTransactionsEnabledTest$JumboEthereumTransactionsPositiveTests ‑ as written
com.hedera.services.bdd.suites.contract.fees.SmartContractServiceFeesTest ‑ as written
com.hedera.services.bdd.suites.contract.precompile.ContractBurnHTSV2SecurityModelSuite ‑ as written
com.hedera.services.bdd.suites.contract.precompile.UpdateTokenFeeScheduleTest ‑ as written
com.hedera.services.bdd.suites.contract.precompile.airdrops.AirdropFromContractTest ‑ as written
com.hedera.services.bdd.suites.contract.precompile.airdrops.AirdropFromContractTest$AirdropFromContractNegativeCases ‑ as written
com.hedera.services.bdd.suites.contract.precompile.airdrops.AirdropSystemContractTest ‑ as written
com.hedera.services.bdd.suites.contract.precompile.airdrops.AirdropToContractSystemContractTest$AirdropToAssociatedReceiverContract ‑ as written
com.hedera.services.bdd.suites.contract.precompile.airdrops.AirdropToContractSystemContractTest$AirdropToContract ‑ as written
…
com.hedera.services.bdd.suites.consensus.AtomicBatchConsensusServiceEndToEndTest$AtomicBatchConsensusServiceWithCustomFees ‑ as written
com.hedera.services.bdd.suites.consensus.AtomicBatchConsensusServiceEndToEndTest$AtomicBatchConsensusServiceWithCustomFeesExemptList ‑ as written
com.hedera.services.bdd.suites.contract.leaky.batch.AtomicLeakyContractTestsSuite ‑ evmLazyCreateViaSolidityCall()
com.hedera.services.bdd.suites.crypto.AtomicBatchAutoAccountCreationEndToEndTests$AtomicBatchAutoAccountCreationEditsAndTransfersTests ‑ as written
com.hedera.services.bdd.suites.crypto.AtomicBatchAutoAccountCreationEndToEndTests$AtomicBatchAutoAccountCreationMultipleAccountsAndTransfersTests ‑ as written
com.hedera.services.bdd.suites.crypto.AtomicBatchAutoAccountCreationEndToEndTests$AtomicBatchAutoAccountCreationTokensMintsAndTransfersTests ‑ as written
com.hedera.services.bdd.suites.file.FileAppendSuite ‑ VanillaAppendSucceeds as written
com.hedera.services.bdd.suites.file.FileAppendSuite ‑ getInfoIdVariantsTreatedAsExpected as written
com.hedera.services.bdd.suites.file.FileAppendSuite ‑ idVariantsTreatedAsExpected as written
com.hedera.services.bdd.suites.file.ProtectedFilesUpdateSuite ‑ ADDRESS_BOOK_CONTROLCanUpdateADDRESS_BOOK as written
…

♻️ This comment has been updated with latest results.

JivkoKelchev and others added 10 commits September 18, 2025 13:43
Signed-off-by: Zhivko Kelchev <[email protected]>
Signed-off-by: ibankov <[email protected]>
Signed-off-by: Zhivko Kelchev <[email protected]>
Signed-off-by: ibankov <[email protected]>
Signed-off-by: ibankov <[email protected]>
Signed-off-by: ibankov <[email protected]>
Signed-off-by: ibankov <[email protected]>
Signed-off-by: ibankov <[email protected]>
@github-actions
Copy link

github-actions bot commented Sep 19, 2025

Node: HAPI Test (Misc Records) Results

  294 files  +  183      1 errors  293 suites  +182   23m 13s ⏱️ + 11m 41s
  342 tests +  235    340 ✅ +  233  1 💤 +1  1 ❌ +1 
1 734 runs  +1 581  1 732 ✅ +1 579  1 💤 +1  1 ❌ +1 

For more details on these parsing errors and failures, see this check.

Results for commit 78e3343. ± Comparison against base commit b4b4fab.

♻️ This comment has been updated with latest results.

@ibankov ibankov changed the title test: enable TransactionRecordParityValidator for EmbeddedNetwork test: enable hapiEmbedded tests in MATS Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants