-
Notifications
You must be signed in to change notification settings - Fork 179
chore: Use dispatch's FeeCharging strategy in HandleContext
#21776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #21776 +/- ##
============================================
+ Coverage 71.57% 71.58% +0.01%
- Complexity 24489 24505 +16
============================================
Files 2675 2675
Lines 103960 103986 +26
Branches 10880 10884 +4
============================================
+ Hits 74408 74439 +31
+ Misses 25487 25483 -4
+ Partials 4065 4064 -1 ... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
joshmarinacci
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Signed-off-by: Michael Tinker <[email protected]>
mhess-swl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @tinker-michaelj!
thenswan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from foundation perspective.
Signed-off-by: Michael Tinker <[email protected]>
a9bf083
lukasz-hashgraph
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Signed-off-by: Michael Tinker <[email protected]>
Description:
HandleContext.tryToCharge()fromFeeAccumulatortoFeeCharging#21775