Skip to content

Conversation

@tinker-michaelj
Copy link
Contributor

@tinker-michaelj tinker-michaelj requested review from a team as code owners October 21, 2025 23:50
@tinker-michaelj tinker-michaelj added this to the v0.68 milestone Oct 21, 2025
@tinker-michaelj tinker-michaelj self-assigned this Oct 21, 2025
@lfdt-bot
Copy link

lfdt-bot commented Oct 21, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

mhess-swl
mhess-swl previously approved these changes Oct 22, 2025
@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

❌ Patch coverage is 96.96970% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../com/hedera/node/app/spi/fees/NoopFeeCharging.java 83.33% 1 Missing ⚠️

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #21776      +/-   ##
============================================
+ Coverage     71.57%   71.58%   +0.01%     
- Complexity    24489    24505      +16     
============================================
  Files          2675     2675              
  Lines        103960   103986      +26     
  Branches      10880    10884       +4     
============================================
+ Hits          74408    74439      +31     
+ Misses        25487    25483       -4     
+ Partials       4065     4064       -1     
Files with missing lines Coverage Δ Complexity Δ
...java/com/hedera/node/app/spi/fees/FeeCharging.java 100.00% <100.00%> (ø) 1.00 <1.00> (+1.00)
...hedera/node/app/spi/workflows/DispatchOptions.java 100.00% <ø> (ø) 17.00 <0.00> (ø)
.../java/com/hedera/node/app/fees/AppFeeCharging.java 100.00% <ø> (ø) 14.00 <0.00> (ø)
...de/app/workflows/handle/DispatchHandleContext.java 97.88% <100.00%> (+1.06%) 58.00 <7.00> (+11.00)
...orkflows/handle/dispatch/ChildDispatchFactory.java 86.95% <100.00%> (+0.19%) 19.00 <0.00> (+1.00)
...pp/workflows/handle/dispatch/ValidationResult.java 92.59% <100.00%> (+0.28%) 20.00 <1.00> (ø)
...e/app/workflows/handle/steps/ParentTxnFactory.java 94.11% <100.00%> (+0.04%) 18.00 <0.00> (ø)
...ows/standalone/impl/StandaloneDispatchFactory.java 95.52% <100.00%> (+0.06%) 5.00 <0.00> (ø)
.../impl/exec/scope/HandleHederaNativeOperations.java 92.98% <100.00%> (ø) 18.00 <0.00> (ø)
...mpl/exec/scope/HandleSystemContractOperations.java 97.87% <ø> (ø) 9.00 <0.00> (ø)
... and 1 more

... and 2 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codacy-production
Copy link

codacy-production bot commented Oct 22, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.01% (target: -1.00%) 96.97%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (881222a) 103865 78429 75.51%
Head commit (a9bf083) 103891 (+26) 78459 (+30) 75.52% (+0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#21776) 33 32 96.97%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@akdev akdev requested a review from joshmarinacci October 22, 2025 06:46
Copy link
Contributor

@joshmarinacci joshmarinacci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

mhess-swl
mhess-swl previously approved these changes Oct 24, 2025
Copy link
Contributor

@mhess-swl mhess-swl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @tinker-michaelj!

thenswan
thenswan previously approved these changes Oct 27, 2025
Copy link
Contributor

@thenswan thenswan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from foundation perspective.

imalygin
imalygin previously approved these changes Oct 27, 2025
Signed-off-by: Michael Tinker <[email protected]>
@tinker-michaelj tinker-michaelj dismissed stale reviews from imalygin, thenswan, and mhess-swl via a9bf083 October 27, 2025 18:24
Copy link
Contributor

@lukasz-hashgraph lukasz-hashgraph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@tinker-michaelj tinker-michaelj merged commit 76e9d4f into main Oct 28, 2025
60 of 61 checks passed
@tinker-michaelj tinker-michaelj deleted the 21775-use-fee-charging-everywhere branch October 28, 2025 17:10
mxtartaglia-sl pushed a commit that referenced this pull request Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate HandleContext.tryToCharge() from FeeAccumulator to FeeCharging

8 participants