Skip to content

Conversation

@petreze
Copy link
Contributor

@petreze petreze commented Oct 23, 2025

Description:
A mirror PR for the following work

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@lfdt-bot
Copy link

lfdt-bot commented Oct 23, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@codacy-production
Copy link

codacy-production bot commented Oct 23, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 77.27%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (5fd761d) 103837 78664 75.76%
Head commit (11ff2e6) 103813 (-24) 78644 (-20) 75.76% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#21818) 110 85 77.27%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

❌ Patch coverage is 77.27273% with 25 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...app/blocks/impl/streaming/BlockNodeConnection.java 75.00% 16 Missing ⚠️
...cks/impl/streaming/BlockNodeConnectionManager.java 80.43% 9 Missing ⚠️

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #21818      +/-   ##
============================================
- Coverage     71.84%   71.84%   -0.01%     
+ Complexity    24570    24562       -8     
============================================
  Files          2673     2672       -1     
  Lines        103932   103908      -24     
  Branches      10868    10867       -1     
============================================
- Hits          74670    74650      -20     
+ Misses        25223    25219       -4     
  Partials       4039     4039              
Files with missing lines Coverage Δ Complexity Δ
...cks/impl/streaming/BlockNodeConnectionManager.java 79.66% <80.43%> (+0.50%) 60.00 <6.00> (ø)
...app/blocks/impl/streaming/BlockNodeConnection.java 85.71% <75.00%> (-0.29%) 70.00 <8.00> (-1.00)

... and 5 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

# Conflicts:
#	hedera-node/hedera-app/src/main/java/com/hedera/node/app/blocks/impl/streaming/BlockNodeConnection.java
#	hedera-node/hedera-app/src/main/java/com/hedera/node/app/blocks/impl/streaming/BlockNodeConnectionManager.java
#	hedera-node/hedera-app/src/main/java/com/hedera/node/app/util/LoggingUtilities.java
Signed-off-by: Petar Tonev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants