- 
                Notifications
    
You must be signed in to change notification settings  - Fork 179
 
fix: reduce log spam when remote node is falling behind (backport) #21828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Artur Biesiadowski <[email protected]> (cherry picked from commit 8b40094)
          ✅ Snyk checks have passed. No issues have been found so far.
 💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.  | 
    
          Codecov Report❌ Patch coverage is  
 @@                Coverage Diff                 @@
##             release/0.67   #21828      +/-   ##
==================================================
+ Coverage           71.33%   71.35%   +0.01%     
- Complexity          24378    24379       +1     
==================================================
  Files                2664     2664              
  Lines              103756   103755       -1     
  Branches            10842    10843       +1     
==================================================
+ Hits                74019    74030      +11     
+ Misses              25695    25682      -13     
- Partials             4042     4043       +1     
 ... and 16 files with indirect coverage changes 🚀 New features to boost your workflow:
  | 
    
          Coverage summary from CodacySee diff coverage on Codacy
 Coverage variation details
 Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:  Diff coverage details
 Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:  See your quality gate settings Change summary preferences | 
    
| /** | ||
| * Limiter to not spam with logs about falling behind compared to other nodes | ||
| */ | ||
| private final RateLimiter fallBehindRateLimiter; | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is also a RateLimitedLogger, might be more appropriate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's true. We can use that class instead in main
Description:
Do not complain in logs when remote node is falling behind. While it is very useful info for debugging and shows that things go wrong on remote node, it is indeed a bit spammy if remote node is broken for a longer time.
Related issue(s):
Fixes #21813
Notes for reviewer:
Backport of #21824
Checklist