Skip to content

Conversation

@abies
Copy link
Contributor

@abies abies commented Oct 23, 2025

Description:
Do not complain in logs when remote node is falling behind. While it is very useful info for debugging and shows that things go wrong on remote node, it is indeed a bit spammy if remote node is broken for a longer time.

Related issue(s):

Fixes #21813

Notes for reviewer:

Backport of #21824

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Artur Biesiadowski <[email protected]>
(cherry picked from commit 8b40094)
@abies abies added this to the v0.67 milestone Oct 23, 2025
@abies abies self-assigned this Oct 23, 2025
@abies abies requested a review from a team as a code owner October 23, 2025 15:47
@abies abies requested review from netopyr and poulok October 23, 2025 15:47
@lfdt-bot
Copy link

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@abies abies requested review from lpetrovic05 and removed request for netopyr October 23, 2025 15:48
@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ds/platform/gossip/shadowgraph/RpcPeerHandler.java 83.33% 0 Missing and 1 partial ⚠️

Impacted file tree graph

@@                Coverage Diff                 @@
##             release/0.67   #21828      +/-   ##
==================================================
+ Coverage           71.33%   71.35%   +0.01%     
- Complexity          24378    24379       +1     
==================================================
  Files                2664     2664              
  Lines              103756   103755       -1     
  Branches            10842    10843       +1     
==================================================
+ Hits                74019    74030      +11     
+ Misses              25695    25682      -13     
- Partials             4042     4043       +1     
Files with missing lines Coverage Δ Complexity Δ
...ds/platform/gossip/shadowgraph/RpcPeerHandler.java 66.21% <83.33%> (+1.11%) 23.00 <0.00> (ø)

... and 16 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codacy-production
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.01% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (70a76f6) 103661 78017 75.26%
Head commit (7bfb8df) 103660 (-1) 78029 (+12) 75.27% (+0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#21828) 6 6 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

/**
* Limiter to not spam with logs about falling behind compared to other nodes
*/
private final RateLimiter fallBehindRateLimiter;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also a RateLimitedLogger, might be more appropriate

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's true. We can use that class instead in main

@abies abies closed this Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants