Skip to content

Conversation

@lpetrovic05
Copy link
Contributor

closes #20282

Signed-off-by: Lazar Petrovic <[email protected]>
Signed-off-by: Lazar Petrovic <[email protected]>
Signed-off-by: Lazar Petrovic <[email protected]>
Signed-off-by: Lazar Petrovic <[email protected]>
Signed-off-by: Lazar Petrovic <[email protected]>
s
Signed-off-by: Lazar Petrovic <[email protected]>
Signed-off-by: Lazar Petrovic <[email protected]>

# Conflicts:
#	platform-sdk/consensus-otter-tests/src/testFixtures/java/org/hiero/otter/fixtures/internal/AbstractNetwork.java
@lpetrovic05 lpetrovic05 added this to the v0.68 milestone Oct 23, 2025
@lpetrovic05 lpetrovic05 requested review from abies and poulok October 23, 2025 16:13
@lpetrovic05 lpetrovic05 self-assigned this Oct 23, 2025
@lpetrovic05 lpetrovic05 requested a review from a team as a code owner October 23, 2025 16:13
@lfdt-bot
Copy link

lfdt-bot commented Oct 23, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #21830      +/-   ##
============================================
+ Coverage     71.82%   71.92%   +0.10%     
- Complexity    24546    24614      +68     
============================================
  Files          2670     2673       +3     
  Lines        103892   103976      +84     
  Branches      10867    10877      +10     
============================================
+ Hits          74619    74789     +170     
+ Misses        25231    25149      -82     
+ Partials       4042     4038       -4     
Files with missing lines Coverage Δ Complexity Δ
...swirlds/platform/crypto/KeysAndCertsGenerator.java 61.40% <100.00%> (+2.91%) 3.00 <2.00> (+1.00)

... and 67 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codacy-production
Copy link

codacy-production bot commented Oct 23, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.09% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (de63ef8) 103797 78616 75.74%
Head commit (06f733b) 103844 (+47) 78746 (+130) 75.83% (+0.09%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#21830) 11 11 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@poulok poulok requested a review from netopyr October 23, 2025 17:15
Signed-off-by: Lazar Petrovic <[email protected]>
@lpetrovic05 lpetrovic05 requested a review from poulok October 24, 2025 10:19
netopyr
netopyr previously approved these changes Oct 24, 2025
Copy link
Contributor

@netopyr netopyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in the Otter framework look good to me. The changes in KeysAndCertsGenerator are outside of my area of expertise.

Signed-off-by: Lazar Petrovic <[email protected]>
s
Signed-off-by: Lazar Petrovic <[email protected]>
Signed-off-by: Lazar Petrovic <[email protected]>
@lpetrovic05 lpetrovic05 requested a review from a team as a code owner October 24, 2025 15:03
Copy link
Contributor

@netopyr netopyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @lpetrovic05

@lpetrovic05 lpetrovic05 merged commit 4bf94c6 into main Oct 27, 2025
62 of 65 checks passed
@lpetrovic05 lpetrovic05 deleted the 20282-otter-test-nodes-change-keys branch October 27, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Write a Otter migration test where all nodes have different keys on startup

6 participants