- 
                Notifications
    You must be signed in to change notification settings 
- Fork 179
feat: otter test nodes change keys #21830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Lazar Petrovic <[email protected]>
Signed-off-by: Lazar Petrovic <[email protected]>
Signed-off-by: Lazar Petrovic <[email protected]>
Signed-off-by: Lazar Petrovic <[email protected]>
Signed-off-by: Lazar Petrovic <[email protected]>
Signed-off-by: Lazar Petrovic <[email protected]>
Signed-off-by: Lazar Petrovic <[email protected]> # Conflicts: # platform-sdk/consensus-otter-tests/src/testFixtures/java/org/hiero/otter/fixtures/internal/AbstractNetwork.java
| ✅ Snyk checks have passed. No issues have been found so far.
 💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. | 
| Codecov Report✅ All modified and coverable lines are covered by tests. @@             Coverage Diff              @@
##               main   #21830      +/-   ##
============================================
+ Coverage     71.82%   71.92%   +0.10%     
- Complexity    24546    24614      +68     
============================================
  Files          2670     2673       +3     
  Lines        103892   103976      +84     
  Branches      10867    10877      +10     
============================================
+ Hits          74619    74789     +170     
+ Misses        25231    25149      -82     
+ Partials       4042     4038       -4     
 ... and 67 files with indirect coverage changes 🚀 New features to boost your workflow:
 | 
| Coverage summary from CodacySee diff coverage on Codacy
 Coverage variation details
 Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:  Diff coverage details
 Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:  See your quality gate settings Change summary preferences | 
        
          
                platform-sdk/consensus-otter-tests/src/testFixtures/java/org/hiero/otter/fixtures/Node.java
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                ...sensus-otter-tests/src/testFixtures/java/org/hiero/otter/fixtures/internal/AbstractNode.java
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                .../consensus-otter-tests/src/testIntegration/java/org/hiero/otter/test/StartFromStateTest.java
              
                Outdated
          
            Show resolved
            Hide resolved
        
      Signed-off-by: Lazar Petrovic <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes in the Otter framework look good to me. The changes in KeysAndCertsGenerator are outside of my area of expertise.
        
          
                .../consensus-otter-tests/src/testIntegration/java/org/hiero/otter/test/StartFromStateTest.java
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                .../consensus-otter-tests/src/testIntegration/java/org/hiero/otter/test/StartFromStateTest.java
          
            Show resolved
            Hide resolved
        
      Signed-off-by: Lazar Petrovic <[email protected]>
Signed-off-by: Lazar Petrovic <[email protected]>
Signed-off-by: Lazar Petrovic <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks @lpetrovic05
closes #20282