Skip to content

fix: Aligns debug_traceTransaction validation with industry standards #3789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Jun 20, 2025
Merged

fix: Aligns debug_traceTransaction validation with industry standards #3789

merged 21 commits into from
Jun 20, 2025

Conversation

@konstantinabl
Copy link
Contributor

@konstantinabl konstantinabl commented May 23, 2025

Description:

Changes validation for debug_traceTransaction to align with industry standards (Alchemy, QuickNode)

Related issue(s):

Fixes #3739

@konstantinabl konstantinabl linked an issue May 23, 2025 that may be closed by this pull request
[NEED INVESTIGATION] Incorrect param validation for debug_traceTransaction #3739
Closed
@lfdt-bot
Copy link

lfdt-bot commented May 23, 2025 •
edited
Loading

🎉 Snyk checks have passed. No issues have been found so far.

✅ security/snyk check is complete. No issues have been found. (View Details)

✅ license/snyk check is complete. No issues have been found. (View Details)

@github-actions
Copy link

github-actions bot commented May 23, 2025 •
edited
Loading

Test Results

 21 files  + 1  278 suites  +22   19m 57s ⏱️ + 1m 47s
665 tests ± 0  659 ✅  -  1  5 💤 ±0  1 ❌ +1 
721 runs  +40  715 ✅ +39  5 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 2d107c6. ± Comparison against base commit d4229d9.

♻️ This comment has been updated with latest results.

@acuarica
Copy link
Contributor

acuarica commented May 23, 2025

Hey @konstantinabl, left a comment in the respective issue #3739 (comment).

@konstantinabl konstantinabl marked this pull request as ready for review June 4, 2025 13:50
@konstantinabl konstantinabl requested review from a team as code owners June 4, 2025 13:50
@konstantinabl konstantinabl requested a review from simzzz June 4, 2025 13:50
@konstantinabl konstantinabl added this to the 0.69.0 milestone Jun 4, 2025
simzzz
simzzz previously approved these changes Jun 5, 2025
View reviewed changes
Copy link
Contributor

@simzzz simzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

quiet-node
quiet-node reviewed Jun 5, 2025
View reviewed changes
@konstantinabl konstantinabl changed the title Aligns debug_traceTransaction validation with industry standards fix: Aligns debug_traceTransaction validation with industry standards Jun 9, 2025
quiet-node
quiet-node reviewed Jun 9, 2025
View reviewed changes
@acuarica
Copy link
Contributor

acuarica commented Jun 11, 2025

We need to update our docs/openrpc.json spec, right?

Moreover, we have changed the signature of the method in a non-compatible way, meaning, should we mark this as a breaking change? Because we would need to include this in the release notes for the next release.

acuarica
acuarica reviewed Jun 11, 2025
View reviewed changes
@natanasow natanasow modified the milestones: 0.69.0, 0.70.0 Jun 13, 2025
@konstantinabl
adds custom config for traceTransaction endpoint
67a0003 
Signed-off-by: Konstantina Blazhukova <[email protected]>
@konstantinabl
improves validation for debug traceTransaction
c05924f 
Signed-off-by: Konstantina Blazhukova <[email protected]>
@konstantinabl
removes unused variables
0c0376c 
Signed-off-by: Konstantina Blazhukova <[email protected]>
@konstantinabl
covers edge cases for tracer config wrapper
acc2794 
Signed-off-by: Konstantina Blazhukova <[email protected]>
@konstantinabl
fixes unit tests
2baa95e 
Signed-off-by: Konstantina Blazhukova <[email protected]>
@konstantinabl
adds clarification for validate method
df82902 
Signed-off-by: Konstantina Blazhukova <[email protected]>
@konstantinabl
removes redundant variable initialization
4760a0d 
Signed-off-by: Konstantina Blazhukova <[email protected]>
@konstantinabl
simplifies code in traceTransaction
e7859f9 
Signed-off-by: Konstantina Blazhukova <[email protected]>
@konstantinabl
removes unused variable
c61a686 
Signed-off-by: Konstantina Blazhukova <[email protected]>
@konstantinabl
improves validation
33b6d41 
Signed-off-by: Konstantina Blazhukova <[email protected]>
@konstantinabl
improves utils tests for traceTransaction
7425fb7 
Signed-off-by: Konstantina Blazhukova <[email protected]>
@konstantinabl
improves types
285645f 
Signed-off-by: Konstantina Blazhukova <[email protected]>
@konstantinabl konstantinabl force-pushed the 3739-need-investigation-incorrect-param-validation-for-debug_tracetransaction branch from edd3ef5 to 285645f Compare June 13, 2025 13:41
@konstantinabl
Merge branch 'main' into 3739-need-investigation-incorrect-param-vali…
3b7c76e 
…dation-for-debug_tracetransaction
@konstantinabl
moves prestate tracer check
a962ce7 
Signed-off-by: Konstantina Blazhukova <[email protected]>
@konstantinabl
fixes tests
cb71bc7 
Signed-off-by: Konstantina Blazhukova <[email protected]>
@konstantinabl
removes unused variable
3d6ebc4 
Signed-off-by: Konstantina Blazhukova <[email protected]>
@konstantinabl
fixes all integration tests
bcaf769 
Signed-off-by: Konstantina Blazhukova <[email protected]>
@konstantinabl
updates openrpc
c7f493b 
Signed-off-by: Konstantina Blazhukova <[email protected]>
@konstantinabl konstantinabl added enhancement New feature or request labels Jun 16, 2025
quiet-node
quiet-node requested changes Jun 16, 2025
View reviewed changes
Copy link
Contributor

@quiet-node quiet-node left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG one small item left

acuarica
acuarica reviewed Jun 16, 2025
View reviewed changes
quiet-node
quiet-node approved these changes Jun 17, 2025
View reviewed changes
Copy link
Contributor

@quiet-node quiet-node left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acuarica acuarica merged commit cd835cf into main Jun 20, 2025
45 of 47 checks passed
@acuarica acuarica deleted the 3739-need-investigation-incorrect-param-validation-for-debug_tracetransaction branch June 20, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@acuarica acuarica acuarica approved these changes

@quiet-node quiet-node quiet-node approved these changes

@simzzz simzzz Awaiting requested review from simzzz

Assignees

@konstantinabl konstantinabl

Labels

enhancement New feature or request

Projects

None yet

Milestone

0.70.0

Development

Successfully merging this pull request may close these issues.

[NEED INVESTIGATION] Incorrect param validation for debug_traceTransaction

7 participants

@konstantinabl @lfdt-bot @acuarica @simzzz @quiet-node @natanasow