-
Notifications
You must be signed in to change notification settings - Fork 88
feat: add OpenRPC JSON updater tool (#1837) #3810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add OpenRPC JSON updater tool (#1837) #3810
Conversation
Signed-off-by: Michał Walczak <[email protected]>
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
…ersions (hiero-ledger#1837) Signed-off-by: Michał Walczak <[email protected]>
Signed-off-by: Michał Walczak <[email protected]>
…pdater scripts (hiero-ledger#1837) Signed-off-by: Michał Walczak <[email protected]>
…pdater scripts (hiero-ledger#1837) Signed-off-by: Michał Walczak <[email protected]>
…n OpenRPC JSON updater scripts (hiero-ledger#1837) Signed-off-by: Michał Walczak <[email protected]>
…C JSON updater workflow (hiero-ledger#1837) Signed-off-by: Michał Walczak <[email protected]>
…low (hiero-ledger#1837) Signed-off-by: Michał Walczak <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works great! I just have a suggestion that we could describe, configure, and fine-tune a few things a bit better.
…ved README, and workflow refinements (hiero-ledger#1837) Signed-off-by: Michał Walczak <[email protected]>
…iero-ledger#1837) Signed-off-by: Michał Walczak <[email protected]>
Signed-off-by: Michał Walczak <[email protected]>
…on` changes (hiero-ledger#1837) Signed-off-by: Michał Walczak <[email protected]>
…ts (hiero-ledger#1837) Signed-off-by: Michał Walczak <[email protected]>
…d adding new methods (hiero-ledger#1837) Signed-off-by: Michał Walczak <[email protected]>
…removal of deprecated logic (hiero-ledger#1837) Signed-off-by: Michał Walczak <[email protected]>
Related issue: #3839 (comment) |
…t.params.2.required` in CUSTOM_FIELDS (hiero-ledger#1837) Signed-off-by: Michał Walczak <[email protected]>
Signed-off-by: Michał Walczak <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good, great stuff to have this
…streamline path handling (hiero-ledger#1837) Signed-off-by: Michał Walczak <[email protected]>
…and update related workflow (hiero-ledger#1837) Signed-off-by: Michał Walczak <[email protected]>
…`openrpc.json` and `refs-openrpc.json` (hiero-ledger#1837) Signed-off-by: Michał Walczak <[email protected]>
…PR body description (hiero-ledger#1837) Signed-off-by: Michał Walczak <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #3810 +/- ##
=======================================
Coverage ? 52.45%
=======================================
Files ? 83
Lines ? 4819
Branches ? 988
=======================================
Hits ? 2528
Misses ? 1891
Partials ? 400 🚀 New features to boost your workflow:
|
Description:
Tool to keep the spec in sync in case of updates.
Related issue(s):
Fixes #1837
Checklist