Skip to content

Conversation

mwb-al
Copy link
Contributor

@mwb-al mwb-al commented Jun 3, 2025

Description:

Tool to keep the spec in sync in case of updates.

Related issue(s):

Fixes #1837

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@lfdt-bot
Copy link

lfdt-bot commented Jun 3, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

Copy link
Contributor

@arianejasuwienas arianejasuwienas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works great! I just have a suggestion that we could describe, configure, and fine-tune a few things a bit better.

@arianejasuwienas arianejasuwienas added the ArianeLabs Items ArianeLabs is contributing to label Jun 4, 2025
@arianejasuwienas arianejasuwienas added this to the 0.69.0 milestone Jun 4, 2025
@mwb-al mwb-al marked this pull request as ready for review June 9, 2025 13:47
@mwb-al mwb-al requested review from a team as code owners June 9, 2025 13:47
@natanasow natanasow modified the milestones: 0.69.0, 0.70.0 Jun 13, 2025
@mwb-al
Copy link
Contributor Author

mwb-al commented Jun 17, 2025

Related issue: #3839 (comment)

Copy link
Contributor

@acuarica acuarica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, great stuff to have this

@mwb-al mwb-al requested a review from acuarica June 26, 2025 13:08
Copy link
Contributor

@Ferparishuertas Ferparishuertas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jul 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

@@           Coverage Diff           @@
##             main    #3810   +/-   ##
=======================================
  Coverage        ?   52.45%           
=======================================
  Files           ?       83           
  Lines           ?     4819           
  Branches        ?      988           
=======================================
  Hits            ?     2528           
  Misses          ?     1891           
  Partials        ?      400           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@arianejasuwienas arianejasuwienas merged commit f220ace into hiero-ledger:main Jul 1, 2025
38 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ArianeLabs Items ArianeLabs is contributing to

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make the openrpc.json schema adhere to the Ethereum execution API specs

6 participants