fix: add default gas fee value for eth_getBlockReceipts #3811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simeon Nakov <[email protected]>
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
Test Results 22 files ± 0 298 suites +3 35m 52s ⏱️ +5s For more details on these failures, see this check. Results for commit 23f4ff6. ± Comparison against base commit c839172. ♻️ This comment has been updated with latest results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
There seems to be a case where retrieving the network fees for very old blocks fails and returns a 404 from the mirror node side as there are no records. In order to fix this problem a default value will be used for
eth_getBlockReceiptsso it doesn't break any tools. The default is purposefully low so that any tool that multiplies gasUsed × gasPrice will simply see a very small “fee paid,” and won’t blow up or double‐count fees.Related issue(s):
Fixes #3797