feat: update getBlockReceipts to return null when block is not found
#3833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…und (hiero-ledger#3813) Signed-off-by: Michał Walczak <[email protected]>
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
konstantinabl
requested changes
Jun 11, 2025
…ansactionReceipt` (hiero-ledger#3813) Signed-off-by: Michał Walczak <[email protected]>
…s not found (hiero-ledger#3813) Signed-off-by: Michał Walczak <[email protected]>
acuarica
approved these changes
Jun 12, 2025
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #3833 +/- ##
=======================================
Coverage ? 47.56%
=======================================
Files ? 83
Lines ? 4770
Branches ? 978
=======================================
Hits ? 2269
Misses ? 2163
Partials ? 338
🚀 New features to boost your workflow:
|
|
Hi @konstantinabl |
konstantinabl
approved these changes
Jun 17, 2025
mwb-al
added a commit
to mwb-al/hiero-json-rpc-relay
that referenced
this pull request
Jun 23, 2025
…und (hiero-ledger#3833) Signed-off-by: Michał Walczak <[email protected]> Co-authored-by: konstantinabl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When querying the eth_getBlockReceipts method in Hedera’s JSON-RPC API with a valid but nonexistent block hash, the endpoint throws an error. This behavior is inconsistent with Ethereum-compatible JSON-RPC endpoints (such as Sepolia), which return null for nonexistent blocks, as per the standard JSON-RPC specification.
Related issue(s):
Fixes #3813
Checklist