Skip to content

Conversation

@acuarica
Copy link
Contributor

@acuarica acuarica commented Jun 12, 2025

Description:

This PR removes getBlockReceipts' custom cache logic leftover from https://github.com/hiero-ledger/hiero-json-rpc-relay/pull/3758/files#r2098146076.

Related issue(s):

Fixes #3778.

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@acuarica acuarica linked an issue Jun 12, 2025 that may be closed by this pull request
@acuarica acuarica self-assigned this Jun 12, 2025
@lfdt-bot
Copy link

lfdt-bot commented Jun 12, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@acuarica acuarica added the Technical Debt Issue which resolves technical debt label Jun 12, 2025
@acuarica acuarica added this to the 0.69.0 milestone Jun 12, 2025
@github-actions
Copy link

github-actions bot commented Jun 12, 2025

Test Results

 22 files  + 2  300 suites  +44   21m 36s ⏱️ + 3m 26s
664 tests ± 0  658 ✅  -  1  5 💤 ±0  1 ❌ +1 
760 runs  +80  753 ✅ +78  5 💤 ±0  2 ❌ +2 

For more details on these failures, see this check.

Results for commit 72a3eab. ± Comparison against base commit 6b670fc.

♻️ This comment has been updated with latest results.

@acuarica acuarica marked this pull request as ready for review June 12, 2025 16:05
@acuarica acuarica requested review from a team as code owners June 12, 2025 16:05
@acuarica acuarica requested a review from Ferparishuertas June 12, 2025 16:05
Copy link
Contributor

@AlfredoG87 AlfredoG87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@quiet-node quiet-node left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acuarica acuarica merged commit b44a8f4 into main Jun 12, 2025
48 of 52 checks passed
@acuarica acuarica deleted the 3778-remove-custom-cache-from-getblockreceipts-method branch June 12, 2025 20:20
mwb-al pushed a commit to mwb-al/hiero-json-rpc-relay that referenced this pull request Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Technical Debt Issue which resolves technical debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove custom cache from getBlockReceipts method

5 participants