Skip to content

Conversation

@rbarker-dev
Copy link
Member

@rbarker-dev rbarker-dev commented Jun 16, 2025

Description:

This pull request updates GitHub Actions workflows to enhance security and improve configuration consistency. Key changes include modifying permissions, adding GPG key import steps, and ensuring proper configuration for GPG signing.

Workflow Permissions and Security Enhancements:

GPG Signing and Configuration Updates:

  • .github/workflows/gh-pages-sync.yaml: Added a step to import a GPG key for signing commits and tags, using the step-security/ghaction-import-gpg action. Configured the GPG signing process with environment variables and secrets for user details and passphrase.
  • .github/workflows/release-automation.yml: Updated the GPG signing step to include git_committer_email and git_committer_name for consistency with the gh-pages-sync workflow.

Related issue(s):

Fixes #3856

Testing:

@rbarker-dev rbarker-dev added this to the 0.71.0 milestone Jun 16, 2025
@rbarker-dev rbarker-dev self-assigned this Jun 16, 2025
@rbarker-dev rbarker-dev requested review from a team as code owners June 16, 2025 19:14
@rbarker-dev rbarker-dev linked an issue Jun 16, 2025 that may be closed by this pull request
@lfdt-bot
Copy link

lfdt-bot commented Jun 16, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

andrewb1269hg
andrewb1269hg previously approved these changes Jun 16, 2025
@rbarker-dev rbarker-dev changed the title 3856 fix gh pages sync fix: gh pages sync Jun 16, 2025
@github-actions
Copy link

github-actions bot commented Jun 16, 2025

Test Results

 20 files   -  1  256 suites   - 25   18m 13s ⏱️ -3s
665 tests  -  1  660 ✅ ± 0  5 💤 ±0  0 ❌  - 1 
681 runs   - 87  676 ✅  - 86  5 💤 ±0  0 ❌  - 1 

Results for commit f08d44e. ± Comparison against base commit 8c7fbc9.

This pull request removes 1 test.
"after all" hook in "@web-socket-batch-1 eth_call" ‑ RPC Server Acceptance Tests Acceptance tests @web-socket-batch-1 eth_call "after all" hook in "@web-socket-batch-1 eth_call"

♻️ This comment has been updated with latest results.

Signed-off-by: Roger Barker <[email protected]>
andrewb1269hg
andrewb1269hg previously approved these changes Jun 16, 2025
Signed-off-by: Roger Barker <[email protected]>
@rbarker-dev rbarker-dev merged commit d4229d9 into main Jun 17, 2025
49 checks passed
@rbarker-dev rbarker-dev deleted the 3856-fix-gh-pages-sync branch June 17, 2025 02:39
mwb-al pushed a commit to mwb-al/hiero-json-rpc-relay that referenced this pull request Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: gh-pages sync

4 participants