Skip to content

Conversation

@simzzz
Copy link
Contributor

@simzzz simzzz commented Jun 19, 2025

Description:
This PR enables proxy support to trust proxy-added headers for client IP detection

Related issue(s):

should fix #3783

Signed-off-by: Simeon Nakov <[email protected]>
@simzzz simzzz self-assigned this Jun 19, 2025
@simzzz simzzz added this to the 0.70.0 milestone Jun 19, 2025
@lfdt-bot
Copy link

lfdt-bot commented Jun 19, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@simzzz simzzz added the enhancement New feature or request label Jun 19, 2025
@simzzz simzzz marked this pull request as ready for review June 19, 2025 08:50
@simzzz simzzz requested review from a team as code owners June 19, 2025 08:50
@simzzz simzzz requested a review from konstantinabl June 19, 2025 08:50
@github-actions
Copy link

github-actions bot commented Jun 19, 2025

Test Results

 21 files  + 1  278 suites  +22   19m 55s ⏱️ + 1m 49s
666 tests ± 0  660 ✅  -  1  5 💤 ±0  1 ❌ +1 
722 runs  +40  716 ✅ +39  5 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 418c5a4. ± Comparison against base commit 27bcc1c.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@Ferparishuertas Ferparishuertas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

natanasow
natanasow previously approved these changes Jun 19, 2025
Signed-off-by: Simeon Nakov <[email protected]>
@simzzz simzzz dismissed stale reviews from natanasow and Ferparishuertas via 50cf050 June 19, 2025 14:33
Copy link
Contributor

@Ferparishuertas Ferparishuertas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

natanasow
natanasow previously approved these changes Jun 20, 2025
@simzzz simzzz dismissed stale reviews from natanasow and Ferparishuertas via 253e222 June 20, 2025 07:39
@simzzz simzzz force-pushed the enable-proxy-support branch from 253e222 to 50cf050 Compare June 20, 2025 08:27
Signed-off-by: Simeon Nakov <[email protected]>
Copy link
Contributor

@Ferparishuertas Ferparishuertas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simzzz simzzz merged commit 39e72e1 into main Jun 20, 2025
44 of 45 checks passed
@simzzz simzzz deleted the enable-proxy-support branch June 20, 2025 09:31
natanasow pushed a commit that referenced this pull request Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test multi-pod integration for shared rate-limiting

5 participants