fix: fixes caching for nested objects and adds tests #3873
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Konstantina Blazhukova <[email protected]>
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
…en-added-to-cache-key
…en-added-to-cache-key
acuarica
reviewed
Jun 24, 2025
Signed-off-by: Konstantina Blazhukova <[email protected]>
…en-added-to-cache-key
Signed-off-by: Konstantina Blazhukova <[email protected]>
Co-authored-by: Luis Mastrangelo <[email protected]> Signed-off-by: konstantinabl <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]>
natanasow
approved these changes
Jun 30, 2025
…en-added-to-cache-key
konstantinabl
deleted the
3872-objects-in-params-are-not-serialized-when-added-to-cache-key
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Updated the generateCacheKey function to properly serialize nested objects using JSON.stringify()
Also removed type IArgument = Record<string, any> as it is not correctly representing what params could be passed to methods.
Related issue(s):
Fixes #3872
Testing
Notes for reviewers
Previously, the test imports were referencing modules from the dist directory. This caused incorrect behavior when checking for instances of RequestDetails in the generateCacheKey method, as the imported class was not the same as the one used in the source. By updating the imports to point to the original source files, type checks (such as instanceof RequestDetails) now behave correctly.
https://github.com/hiero-ledger/hiero-json-rpc-relay/pull/3873/files#diff-cdce3dcc7c73d10d08f1dccc43860f2b14d0feb8321935967728568ea7f2931eR7