-
Notifications
You must be signed in to change notification settings - Fork 91
feat: adds additional test coverage to multiple files #3920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test Results 20 files ±0 277 suites ±0 17m 54s ⏱️ -3s Results for commit 029c6de. ± Comparison against base commit f82f220. This pull request removes 1 test.♻️ This comment has been updated with latest results. |
quiet-node
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch on the missing tests and great set of new tests!
packages/relay/src/lib/services/ethService/ethFilterService/FilterService.ts
Show resolved
Hide resolved
Signed-off-by: Simeon Nakov <[email protected]>
Signed-off-by: Simeon Nakov <[email protected]>
Signed-off-by: Simeon Nakov <[email protected]>
Signed-off-by: Simeon Nakov <[email protected]>
Signed-off-by: Simeon Nakov <[email protected]>
Signed-off-by: Simeon Nakov <[email protected]>
Signed-off-by: Simeon Nakov <[email protected]>
Signed-off-by: Simeon Nakov <[email protected]>
Signed-off-by: Simeon Nakov <[email protected]>
Signed-off-by: Simeon Nakov <[email protected]>
74106a5 to
62ab4d8
Compare
quiet-node
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM great work as always!
packages/relay/tests/lib/services/rateLimiterService/rateLimiterService.spec.ts
Outdated
Show resolved
Hide resolved
packages/relay/tests/lib/services/rateLimiterService/rateLimiterService.spec.ts
Outdated
Show resolved
Hide resolved
packages/relay/tests/lib/services/rateLimiterService/RedisRateLimitStore.spec.ts
Show resolved
Hide resolved
packages/relay/tests/lib/services/rateLimiterService/RedisRateLimitStore.spec.ts
Outdated
Show resolved
Hide resolved
packages/relay/tests/lib/services/rateLimiterService/RedisRateLimitStore.spec.ts
Show resolved
Hide resolved
packages/relay/tests/lib/services/rateLimiterService/RedisRateLimitStore.spec.ts
Show resolved
Hide resolved
packages/relay/tests/lib/services/rateLimiterService/RedisRateLimitStore.spec.ts
Show resolved
Hide resolved
Signed-off-by: Simeon Nakov <[email protected]>
Signed-off-by: Simeon Nakov <[email protected]>
quiet-node
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #3920 +/- ##
==========================================
+ Coverage 86.86% 87.39% +0.53%
==========================================
Files 87 87
Lines 5039 5047 +8
Branches 1020 1018 -2
==========================================
+ Hits 4377 4411 +34
+ Misses 400 384 -16
+ Partials 262 252 -10
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Description:
This PR introduces new unit tests to increase coverage across several key areas of the relay, focusing on error handling, rate limiting, and data formatting.
Related issue(s):
closes #3910, closes #3911, closes #3912, closes #3913, closes #3914, closes #3915, closes #3916