Skip to content

Conversation

natanasow
Copy link
Contributor

Description

geth 1.16.0 updated ethereum/go-ethereum#31887 to return receipt for logs containing the blockTimestamp info, as proposed by ethereum/execution-apis#639.

Solution

Upgrade the relay to comply with the new logs receipt format.

Affected methods:

  • eth_getLogs
  • eth_getTransactionReceipt
  • eth_getBlockReceipt
  • eth_getFilterLogs
  • eth_getFilterChanges

Related issue(s)

Fixes #3890

Testing Guide

Changes from original design (optional)

N/A

Additional work needed (optional)

N/A

Checklist

  • I've assigned an assignee to this PR and related issue(s) (if applicable)
  • I've assigned a label to this PR and related issue(s) (if applicable)
  • I've assigned a milestone to this PR and related issue(s) (if applicable)
  • I've updated documentation (code comments, README, etc. if applicable)
  • I've done sufficient testing (unit, integration, etc.)

@natanasow natanasow self-assigned this Sep 5, 2025
@natanasow natanasow added the enhancement New feature or request label Sep 5, 2025
@natanasow natanasow added this to the 0.73.0 milestone Sep 5, 2025
Copy link

github-actions bot commented Sep 5, 2025

Test Results

 20 files  ±0  265 suites  ±0   18m 57s ⏱️ - 7m 8s
725 tests ±0  720 ✅ +2  5 💤 ±0  0 ❌  - 2 
741 runs  ±0  736 ✅ +2  5 💤 ±0  0 ❌  - 2 

Results for commit 178cab0. ± Comparison against base commit 3efdcad.

♻️ This comment has been updated with latest results.

@natanasow natanasow marked this pull request as ready for review September 9, 2025 10:56
@natanasow natanasow requested review from a team as code owners September 9, 2025 10:56
@natanasow natanasow requested a review from acuarica September 9, 2025 10:56
@natanasow natanasow merged commit f1e11a8 into main Sep 11, 2025
46 of 48 checks passed
@natanasow natanasow deleted the 3890-update-logs-to-include-blocktimestamp branch September 11, 2025 07:42
Copy link

codecov bot commented Sep 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@           Coverage Diff           @@
##             main    #4358   +/-   ##
=======================================
  Coverage   95.61%   95.61%           
=======================================
  Files         121      121           
  Lines       19936    19936           
  Branches     1732     1732           
=======================================
  Hits        19061    19061           
  Misses        850      850           
  Partials       25       25           
Flag Coverage Δ
config-service 98.80% <ø> (ø)
relay 90.66% <100.00%> (ø)
server 88.82% <ø> (ø)
ws-server 53.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/relay/src/lib/model.ts 89.23% <100.00%> (+0.11%) ⬆️
...vices/ethService/ethCommonService/CommonService.ts 95.50% <100.00%> (+<0.01%) ⬆️
...thService/transactionService/TransactionService.ts 97.23% <100.00%> (-0.02%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade the logs receipt format to include the blockTimestamp field
3 participants