Skip to content

Conversation

natanasow
Copy link
Contributor

@natanasow natanasow commented Sep 11, 2025

Description

Check whether these methods are excluded from checks in the JSON-RPC spec tests, and if they are not - add them to exclusions. All methods are described in the linked issue.

Related issue(s)

Fixes #4355

Testing Guide

Changes from original design (optional)

N/A

Additional work needed (optional)

N/A

Checklist

  • I've assigned an assignee to this PR and related issue(s) (if applicable)
  • I've assigned a label to this PR and related issue(s) (if applicable)
  • I've assigned a milestone to this PR and related issue(s) (if applicable)
  • I've updated documentation (code comments, README, etc. if applicable)
  • I've done sufficient testing (unit, integration, etc.)

Signed-off-by: nikolay <[email protected]>
@natanasow natanasow added the enhancement New feature or request label Sep 11, 2025
@natanasow natanasow added this to the 0.73.0 milestone Sep 11, 2025
Copy link

github-actions bot commented Sep 11, 2025

Test Results

 20 files  ±0  265 suites  ±0   18m 45s ⏱️ - 7m 20s
726 tests +1  721 ✅ +3  5 💤 ±0  0 ❌  - 2 
742 runs  +1  737 ✅ +3  5 💤 ±0  0 ❌  - 2 

Results for commit a4be3a9. ± Comparison against base commit 3efdcad.

♻️ This comment has been updated with latest results.

@natanasow natanasow self-assigned this Sep 11, 2025
@natanasow natanasow marked this pull request as ready for review September 11, 2025 12:26
@natanasow natanasow requested review from a team as code owners September 11, 2025 12:26
@natanasow natanasow requested a review from simzzz September 11, 2025 12:26
acuarica
acuarica previously approved these changes Sep 11, 2025
Signed-off-by: nikolay <[email protected]>
@natanasow natanasow requested review from a team and Nana-EC September 15, 2025 08:16
@natanasow natanasow merged commit 506466d into main Sep 15, 2025
66 of 69 checks passed
@natanasow natanasow deleted the 4355-update-openrpc-json-updater branch September 15, 2025 12:09
Copy link

codecov bot commented Sep 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@           Coverage Diff           @@
##             main    #4370   +/-   ##
=======================================
  Coverage   95.61%   95.61%           
=======================================
  Files         121      121           
  Lines       19936    19958   +22     
  Branches     1732     1733    +1     
=======================================
+ Hits        19061    19083   +22     
  Misses        850      850           
  Partials       25       25           
Flag Coverage Δ
config-service 98.80% <ø> (ø)
relay 90.64% <ø> (-0.03%) ⬇️
server 88.82% <ø> (ø)
ws-server 53.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add unsupported, not implemented and not found method from JSON-RPC spec to the excluded methods list
4 participants