feat: remove caching from getTransactionCount with block tag = latest #4398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
simzzz
approved these changes
Sep 23, 2025
| return await this.getAccountNonceForHistoricBlock(address, blockNumOrTag, requestDetails); | ||
| } | ||
|
|
||
| const cacheTtl = |
There was a problem hiding this comment.
@natanasow shouldnt we keep the cache for the earliest block and specific block numbers?
There was a problem hiding this comment.
They are cached on an upper level here https://github.com/hiero-ledger/hiero-json-rpc-relay/blob/main/packages/relay/src/lib/eth.ts#L928.
konstantinabl
approved these changes
Sep 23, 2025
natanasow
deleted the
4389-remove-cache-for-latest-on-get-transaction-count
branch
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## feat/transaction-pool #4398 +/- ##
=========================================================
- Coverage 96.10% 96.10% -0.01%
=========================================================
Files 121 121
Lines 19940 19920 -20
Branches 1755 1748 -7
=========================================================
- Hits 19164 19144 -20
Misses 751 751
Partials 25 25
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
konstantinabl
pushed a commit
that referenced
this pull request
Sep 30, 2025
…#4398) Signed-off-by: nikolay <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, we cache getTransactionCount("latest") with ttl 500ms, however, we may still return an old value that is not relevant, if e.g we cache the getTransactionCount("latest") for 500ms, but after 300ms a new block is mined, the value needs to be updated, but we will still return the older value.
Motivation
Avoid returning an old value on request to
eth_getTransctionCountwith block tag = latestRelated issue(s)
Fixes #4389
Testing Guide
Changes from original design (optional)
N/A
Additional work needed (optional)
N/A
Checklist