Skip to content

Conversation

konstantinabl
Copy link
Contributor

@konstantinabl konstantinabl commented Oct 1, 2025

Description

This PR implements RedisPendingTransactionStorage, a Redis-backed storage for the transaction pool

Uses Redis Sets per address (pending:

) to store unique transaction hashes with natural deduplication via SADD.

Related issue(s)

Fixes #4390

Changes from original design (optional)

It was decided LUA scripts are not needed for the simple operations of addition, removal and length check we use, since they are atomic anyways

Checklist

  • I've assigned an assignee to this PR and related issue(s) (if applicable)
  • I've assigned a label to this PR and related issue(s) (if applicable)
  • I've assigned a milestone to this PR and related issue(s) (if applicable)
  • I've updated documentation (code comments, README, etc. if applicable)
  • I've done sufficient testing (unit, integration, etc.)

Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]>
@konstantinabl konstantinabl linked an issue Oct 1, 2025 that may be closed by this pull request
@konstantinabl konstantinabl changed the base branch from main to feat/transaction-pool October 1, 2025 12:22
Copy link

github-actions bot commented Oct 1, 2025

Test Results

 20 files  ±0  265 suites  ±0   35m 16s ⏱️ + 7m 33s
761 tests ±0  753 ✅  - 2  5 💤 ±0  3 ❌ +2 
777 runs  ±0  769 ✅  - 2  5 💤 ±0  3 ❌ +2 

For more details on these failures, see this check.

Results for commit bfe4d8d. ± Comparison against base commit 256d146.

♻️ This comment has been updated with latest results.

@konstantinabl konstantinabl self-assigned this Oct 1, 2025
@konstantinabl konstantinabl added the enhancement New feature or request label Oct 1, 2025
@konstantinabl konstantinabl added this to the 0.72.0 milestone Oct 1, 2025
@konstantinabl konstantinabl marked this pull request as ready for review October 1, 2025 12:32
@konstantinabl konstantinabl requested review from a team as code owners October 1, 2025 12:32
@konstantinabl konstantinabl requested a review from acuarica October 1, 2025 12:32
Copy link

codecov bot commented Oct 1, 2025

Codecov Report

❌ Patch coverage is 95.91837% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ctionPoolService/RedisPendingTransactionStorage.ts 95.91% 4 Missing ⚠️
@@                   Coverage Diff                    @@
##             feat/transaction-pool    #4438   +/-   ##
========================================================
  Coverage                         ?   95.83%           
========================================================
  Files                            ?      124           
  Lines                            ?    20206           
  Branches                         ?     1757           
========================================================
  Hits                             ?    19365           
  Misses                           ?      819           
  Partials                         ?       22           
Flag Coverage Δ
config-service 98.80% <ø> (?)
relay 90.85% <95.91%> (?)
server 88.82% <ø> (?)
ws-server 98.27% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ctionPoolService/RedisPendingTransactionStorage.ts 95.91% <95.91%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@konstantinabl konstantinabl requested review from a team October 1, 2025 13:23
Signed-off-by: Konstantina Blazhukova <[email protected]>
@konstantinabl konstantinabl requested a review from simzzz October 2, 2025 07:45
@konstantinabl konstantinabl merged commit a7125e1 into feat/transaction-pool Oct 2, 2025
5 of 6 checks passed
@konstantinabl konstantinabl deleted the 4390-implement-redispendingtransactionstorage branch October 2, 2025 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement RedisPendingTransactionStorage
3 participants