-
Notifications
You must be signed in to change notification settings - Fork 85
feat: Implement Redis storage #4438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement Redis storage #4438
Conversation
Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]>
Test Results 20 files ±0 265 suites ±0 35m 16s ⏱️ + 7m 33s For more details on these failures, see this check. Results for commit bfe4d8d. ± Comparison against base commit 256d146. ♻️ This comment has been updated with latest results. |
packages/relay/src/lib/services/transactionPoolService/RedisPendingTransactionStorage.ts
Outdated
Show resolved
Hide resolved
packages/relay/src/lib/services/transactionPoolService/RedisPendingTransactionStorage.ts
Show resolved
Hide resolved
packages/relay/src/lib/services/transactionPoolService/RedisPendingTransactionStorage.ts
Outdated
Show resolved
Hide resolved
packages/relay/src/lib/services/transactionPoolService/RedisPendingTransactionStorage.ts
Outdated
Show resolved
Hide resolved
packages/relay/src/lib/services/transactionPoolService/RedisPendingTransactionStorage.ts
Outdated
Show resolved
Hide resolved
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## feat/transaction-pool #4438 +/- ##
========================================================
Coverage ? 95.83%
========================================================
Files ? 124
Lines ? 20206
Branches ? 1757
========================================================
Hits ? 19365
Misses ? 819
Partials ? 22
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Signed-off-by: Konstantina Blazhukova <[email protected]>
Description
This PR implements RedisPendingTransactionStorage, a Redis-backed storage for the transaction pool
Uses Redis Sets per address (pending:
) to store unique transaction hashes with natural deduplication via SADD.Related issue(s)
Fixes #4390
Changes from original design (optional)
It was decided LUA scripts are not needed for the simple operations of addition, removal and length check we use, since they are atomic anyways
Checklist