Skip to content

Conversation

konstantinabl
Copy link
Contributor

@konstantinabl konstantinabl commented Oct 2, 2025

Description

This PR adds the new functionality for the transaction pool in the sendRawTransactionProcessor, so before submitting a transaction and after it being validated we save/remove it.

Related issue(s)

Fixes #4393

Changes from original design (optional)

N/A

Additional work needed (optional)

N/A

Checklist

  • I've assigned an assignee to this PR and related issue(s) (if applicable)
  • I've assigned a label to this PR and related issue(s) (if applicable)
  • I've assigned a milestone to this PR and related issue(s) (if applicable)
  • I've updated documentation (code comments, README, etc. if applicable)
  • I've done sufficient testing (unit, integration, etc.)

@konstantinabl konstantinabl changed the base branch from main to feat/transaction-pool October 2, 2025 13:13
Copy link

codecov bot commented Oct 2, 2025

Codecov Report

❌ Patch coverage is 91.89189% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...thService/transactionService/TransactionService.ts 92.30% 2 Missing ⚠️
packages/relay/src/lib/eth.ts 90.00% 1 Missing ⚠️
@@                   Coverage Diff                    @@
##             feat/transaction-pool    #4444   +/-   ##
========================================================
  Coverage                         ?   85.09%           
========================================================
  Files                            ?      126           
  Lines                            ?    20302           
  Branches                         ?     1107           
========================================================
  Hits                             ?    17277           
  Misses                           ?     3008           
  Partials                         ?       17           
Flag Coverage Δ
config-service 98.80% <ø> (?)
relay 51.58% <51.35%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/relay/src/lib/relay.ts 91.79% <100.00%> (ø)
packages/relay/src/lib/eth.ts 99.48% <90.00%> (ø)
...thService/transactionService/TransactionService.ts 88.63% <92.30%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

github-actions bot commented Oct 2, 2025

Test Results

 20 files  ± 0  260 suites   - 3   17m 31s ⏱️ - 17m 37s
750 tests +10  742 ✅ +12  5 💤 ±0  3 ❌  - 2 
770 runs  +16  762 ✅ +18  5 💤 ±0  3 ❌  - 2 

For more details on these failures, see this check.

Results for commit c20b8f7. ± Comparison against base commit 57c9fa1.

Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]>
@konstantinabl konstantinabl self-assigned this Oct 3, 2025
@konstantinabl konstantinabl added the enhancement New feature or request label Oct 3, 2025
@konstantinabl konstantinabl added this to the 0.72.0 milestone Oct 3, 2025
@konstantinabl konstantinabl marked this pull request as ready for review October 3, 2025 07:51
@konstantinabl konstantinabl requested review from a team as code owners October 3, 2025 07:51
Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]>
@konstantinabl konstantinabl requested review from a team October 3, 2025 11:21
@natanasow natanasow merged commit 02ba6bd into feat/transaction-pool Oct 3, 2025
5 checks passed
@natanasow natanasow deleted the 4393-update-sendrawtransaction-methods branch October 3, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update sendRawTransactionprocessor and sendRawTransactionErrorHandler methods
3 participants