-
Notifications
You must be signed in to change notification settings - Fork 88
feat: Add ENV var to use JSON logging #4474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: kasey-alusi-vcc <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kasey-alusi-vcc! Nice work and LG so far just 1 item
Signed-off-by: kasey-alusi-vcc <[email protected]>
d17386a to
d5742d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG, could you also add this new var to the .env example files env.http.example and env.ws.example?
Signed-off-by: kasey-alusi-vcc <[email protected]>
Signed-off-by: kasey-alusi-vcc <[email protected]>
Signed-off-by: kasey-alusi-vcc <[email protected]>
|
Hey @kasey-alusi-vcc, there was an issue where a Dependabot PR corrupted the package-lock.json file, which caused all the current CI failures. The fix has been merged into main, so could you please do a quick rebase to get the CIs running again? Sorry for the inconvenience |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Hi @konstantinabl can you review this PR? |
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project check has failed because the head coverage (64.15%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.
@@ Coverage Diff @@
## main #4474 +/- ##
===========================================
- Coverage 95.41% 64.15% -31.27%
===========================================
Files 127 127
Lines 20447 20457 +10
Branches 1754 404 -1350
===========================================
- Hits 19510 13124 -6386
- Misses 918 7326 +6408
+ Partials 19 7 -12
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 74 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Description
This PR adds a new environment variable
PRETTY_LOGS_ENABLEDto be able to override the default log format with JSON formatted logs. Default behavior will remain pino-pretty. JSON logging can be set withPRETTY_LOGS_ENABLED=false.Fixes: #4498
Testing Guide
PRETTY_LOGS_ENABLED=false, validating that log messages are in json format.Checklist