feat: adds cache: prefix to all CacheService keys
#4559
Merged
+159
−40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CacheServicestores Redis keys without a prefix, while other services use prefixes (pending:*,hbar-limit:*, etc.). This causes:Unsafe clearing:
CacheService.clear()can't distinguish its keys from others, so we hardcode a filter:This couples RedisCache to TransactionPoolService and doesn't scale.
No ownership: Can't tell which keys belong to which service.
Maintenance burden: Every new Redis user must update the filter.
This PR solves that by adding the prefix to all CacheService keys. The
pending:key was also changed totxpool:pending. All tests have been added to reflect that.Related issue(s)
Fixes #4501
Testing Guide
Changes from original design (optional)
N/A
Additional work needed (optional)
N/A
Checklist