fix: simplify transaction events query #2279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Vercel deployment URL: https://stacks-blockchain-d2g2gtf2a-hirosystems.vercel.app 🚀 |
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the /extended/v1/tx/events SQL to only include relevant event-type subqueries instead of relying on UNIONs against a null‐filled placeholder.
- Introduce an array of
PgSqlQuerysegments pushed conditionally per event type. - Build the final CTE via
reduceto unite only the selected filters.
Comments suppressed due to low confidence (1)
src/datastore/pg-store.ts:1785
- Add tests covering scenarios where
args.eventTypeFilteris empty or includes multiple types to ensure the new dynamic query assembly behaves correctly.
const eventQueries: PgSqlQuery[] = [];
hirosystems-release-bot bot
added a commit
that referenced
this pull request
May 26, 2025
## [8.11.0](v8.10.0...v8.11.0) (2025-05-26) ### Features * add /extended/v2/block-tenures/:height/blocks endpoint ([#2285](#2285)) ([f5c2e01](f5c2e01)) * stacks core event and rpc proxy body limits configurable via env ([#2278](#2278)) ([8a54e9d](8a54e9d)) * store and expose vm_error for failed transactions ([#2286](#2286)) ([7ac7513](7ac7513)) ### Bug Fixes * consider microblock transactions in balance calculations ([#2277](#2277)) ([3418863](3418863)) * count stx mint data at block 0 towards account balances ([#2289](#2289)) ([a0cd9f2](a0cd9f2)) * ignore unanchored param for BNS names endpoint ([#2263](#2263)) ([3d33725](3d33725)) * keep a table of latest stacks node event timestamps ([#2266](#2266)) ([6f111ad](6f111ad)) * module imports in block tenure routes ([#2287](#2287)) ([2cb442e](2cb442e)) * **rosetta:** get current block should only join by stacks chain tip information ([#2265](#2265)) ([78ebad0](78ebad0)) * simplify transaction events query ([#2279](#2279)) ([517ca68](517ca68))
|
🎉 This PR is included in version 8.11.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simply the SQL query for the
/extended/v1/tx/eventsendpoint so it doesn't rely on UNIONs with null columns. It will only query against tables based on the given filters.Fixes #2261