-
Notifications
You must be signed in to change notification settings - Fork 122
fix: discount re-orged microblock transactions from ft_balances table #2322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Vercel deployment URL: https://stacks-blockchain-4v5zcuqxn-hirosystems.vercel.app 🚀 |
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sql looks good to me. Will the CTE be a performance issue? I'm sure devops can handle it, just noting it since it seems likely to be slow
## [8.11.5](v8.11.4...v8.11.5) (2025-07-18) ### Bug Fixes * discount re-orged microblock transactions from ft_balances table ([#2322](#2322)) ([911c620](911c620))
🎉 This PR is included in version 8.11.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
The current
ft_balances
table logic does not take into account when a microblock-confirmed transaction is reorged, which means operations can appear more than once in balance calculations for old Stacks 2.x blocks.This PR fixes this by looking at past microblock re-orgs and recalculating balances based on their transactions.