Skip to content

Conversation

@vanch3d
Copy link
Contributor

@vanch3d vanch3d commented May 6, 2025

See https://hivemq.kanbanize.com/ctrl_board/57/cards/31835/details/

The Pr improves the CI pipeline for the frontend in two directions

  • The Cypress-based tests (component and E2E) have been split into subgroups. to parallelise their execution through github action matrix. The splits are only actionable based on test file paths (i.e. globs) and are only viable because of an opinionated structure of the code base (e.g. E2E, extensions, components, modules). This reorganisation has reduced the duration of the CI pipeline by more than 60%
  • Code coverage for the frontend is added, with integration with SonarQube Cloud (see https://sonarcloud.io/organizations/hivemq/projects)
    The integration relies on a local SonarQube configuration and on the extraction of the code coverage data for three sources of tests (unit tests with Vitest, component and E2E tests with Cypress, as organised into multiple tests).

The PR also refactors the frontend workflow to abide by the new Check structure imposed by #938:

  • Files renamed
  • Frontend workflow trigger changed to workflow_call
  • Failure on final check removed fo frontend

Out-of-scope

  • Integration of the frontend as a project in SonarQube cloud still needs to be configured properly. It will be done in a follow-up ticket.
  • The visual tests (Percy) are not integrated anymore in the new frontend. It will be redone in a subsequent ticket

Before

Screenshot 2025-05-06 at 15 22 23

After

Screenshot 2025-05-06 at 15 24 09

After rebase

Screenshot 2025-05-07 at 12 59 49

@vanch3d vanch3d self-assigned this May 6, 2025
@cla-bot cla-bot bot added the cla-signed label May 6, 2025
Copy link
Contributor

@oli-hivemq oli-hivemq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great setup!

@vanch3d vanch3d changed the title chore(31835): Add matrix-based Cypress test and Code Coverage chore(31835): Add matrix-based Cypress job and Code Coverage May 7, 2025
@vanch3d vanch3d force-pushed the chore/31835-code-coverage branch from ed2d147 to 4b41000 Compare May 7, 2025 10:46
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 7, 2025

@vanch3d vanch3d merged commit e8019bf into master May 7, 2025
16 of 18 checks passed
@vanch3d vanch3d deleted the chore/31835-code-coverage branch May 7, 2025 12:11
@vanch3d vanch3d restored the chore/31835-code-coverage branch May 8, 2025 08:35
@vanch3d vanch3d deleted the chore/31835-code-coverage branch May 14, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants