Refactor Errors for DataHub Validation #993
Open
+7,606
−1,026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caoccao
changed the title
vanch3d
requested changes
May 30, 2025
ext/openAPI/components/schemas/errors/common/TemporaryNotAvailableError.yaml
Outdated
Show resolved
Hide resolved
ext/openAPI/components/schemas/errors/common/RequestBodyMissingError.yaml
Outdated
Show resolved
Hide resolved
ext/openAPI/components/schemas/errors/validation/EmptyFieldValidationError.yaml
Outdated
Show resolved
Hide resolved
ext/openAPI/components/schemas/errors/validation/InvalidIdentifierValidationError.yaml
Outdated
Show resolved
Hide resolved
hivemq-edge-openapi/openapi/components/schemas/errors/validation/ValidationError.yaml
Show resolved
Hide resolved
hivemq-edge-openapi/openapi/components/schemas/errors/validation/ValidationError.yaml
Show resolved
Hide resolved
ext/openAPI/components/schemas/errors/validation/ValidationErrors.yaml
Outdated
Show resolved
Hide resolved
vanch3d
requested changes
May 30, 2025
caoccao
changed the title
vanch3d
requested changes
Jun 5, 2025
...edge-openapi/openapi/components/schemas/errors/datahub/AtMostOneFunctionValidationError.yaml
Show resolved
Hide resolved
...edge-openapi/openapi/components/schemas/errors/datahub/AtMostOneFunctionValidationError.yaml
Show resolved
Hide resolved
ext/openAPI/components/schemas/errors/datahub/BehaviorPolicyAlreadyPresentError.yaml
Outdated
Show resolved
Hide resolved
ext/openAPI/components/schemas/errors/datahub/BehaviorPolicyCreationFailureError.yaml
Outdated
Show resolved
Hide resolved
ext/openAPI/components/schemas/errors/datahub/BehaviorPolicyNotFoundError.yaml
Outdated
Show resolved
Hide resolved
ext/openAPI/components/schemas/errors/validation/EmptyFieldValidationError.yaml
Outdated
Show resolved
Hide resolved
ext/openAPI/components/schemas/errors/validation/InvalidFieldLengthValidationError.yaml
Outdated
Show resolved
Hide resolved
ext/openAPI/components/schemas/errors/validation/InvalidFieldValueValidationError.yaml
Outdated
Show resolved
Hide resolved
ext/openAPI/components/schemas/errors/validation/MissingFieldValidationError.yaml
Outdated
Show resolved
Hide resolved
ext/openAPI/components/schemas/errors/validation/UnsupportedFieldValidationError.yaml
Outdated
Show resolved
Hide resolved
vanch3d
requested changes
Jun 5, 2025
ext/openAPI/paths/api_v1_data-hub_behavior-validation_policies.yaml
Outdated
Show resolved
Hide resolved
vanch3d
requested changes
Jun 6, 2025
vanch3d
requested changes
Jun 6, 2025
ext/openAPI/components/schemas/errors/datahub/BehaviorPolicyAlreadyPresentError.yaml
Outdated
Show resolved
Hide resolved
vanch3d
requested changes
Jun 10, 2025
...edge-openapi/openapi/components/schemas/errors/datahub/AtMostOneFunctionValidationError.yaml
Show resolved
Hide resolved
vanch3d
requested changes
Jun 23, 2025
There was a problem hiding this comment.
It looks pretty good.
I've closed all the outstanding issues, we will revisit problems with individual errors when I deal with them in the frontend (if I'm nt, no need to over-engineering)
There are two issues:
- rename ApiError to
DataHubApiError(very important) - rename all ApiError-related schemas to end with
ProblemDetailinstead ofErrororErrors
...ge-openapi/openapi/components/schemas/errors/datahub/BehaviorPolicyCreationFailureError.yaml
Show resolved
Hide resolved
hivemq-edge-openapi/openapi/components/schemas/errors/datahub/DataPolicyInvalidErrors.yaml
Show resolved
Hide resolved
...mq-edge-openapi/openapi/components/schemas/errors/datahub/BehaviorPolicyValidationError.yaml
Show resolved
Hide resolved
Not all API errors are DataHub errors. The DataHub validation reuses some shared errors. That's why I avoided prefixing with DataHub. I suggest we have a call discussing these issues. |
caoccao
force-pushed
the
epic/31382-datahub-maintenance
branch
from
b5769cd to
f7f0f0c
Compare
caoccao
force-pushed
the
refactor/29914-error-redesign-v2
branch
from
46de359 to
fcdf0ad
Compare
Coverage Report
|
caoccao
force-pushed
the
refactor/29914-error-redesign-v2
branch
2 times, most recently
from
4f610d0 to
dc0e924
Compare
caoccao
force-pushed
the
refactor/29914-error-redesign-v2
branch
3 times, most recently
from
8168bc7 to
16ae985
Compare
vanch3d
approved these changes
Jul 30, 2025
caoccao
force-pushed
the
refactor/29914-error-redesign-v2
branch
from
f0f8576 to
86e8c80
Compare
codepitbull
approved these changes
Aug 7, 2025
caoccao
force-pushed
the
refactor/29914-error-redesign-v2
branch
2 times, most recently
from
fcff24f to
2c0c503
Compare
caoccao
force-pushed
the
refactor/29914-error-redesign-v2
branch
from
2c0c503 to
2f53465
Compare
caoccao
force-pushed
the
refactor/29914-error-redesign-v2
branch
from
2f53465 to
2dc993d
Compare
caoccao
force-pushed
the
refactor/29914-error-redesign-v2
branch
from
d15da62 to
6e8d383
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hivemq.kanbanize.com/ctrl_board/57/cards/29914/details/