Priliminary support for staged keyword
#348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation during diff testing
…ring Add Block.mls into DiffMaker and prepare the function for lowering Use older Import syntax for now
|
There is no need to add such a field to |
This comment was marked as resolved.
This comment was marked as resolved.
LPTK
requested changes
Nov 5, 2025
Please elaborate; this doesn't help. Why are they failing? Also, please fix the conflicts. |
Co-authored-by: Lionel Parreaux <[email protected]>
Co-authored-by: Lionel Parreaux <[email protected]>
LPTK
reviewed
Nov 6, 2025
|
I think we can merge this as soon as you finish addressing the comments. I guess it can be marked as "ready", yes? |
|
Yes, it is ready now. |
LPTK
reviewed
Nov 6, 2025
This reverts commit e4d7b22.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR to implement the
stagedkeyword and:stagingcompiler flag.This currently cannot merge due to the change in semantics.Import syntax in MLsCompiler.scala.
Adding the
staged: Boolfield intoFunDefnis a bit hacky to avoid rewriting existing match statements, we'll look into adding the field toClsLikeBodyinstead.