Skip to content

fix(database): remove unused mysql values #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 28, 2025
Merged

fix(database): remove unused mysql values #163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions charts/homarr/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: homarr
description: A Helm chart to deploy homarr for Kubernetes
home: https://homarr-labs.github.io/charts/charts/homarr/
type: application
version: 7.0.0
version: 7.1.0
# renovate datasource=docker depName=ghcr.io/homarr-labs/homarr
appVersion: "v1.39.0"
icon: https://raw.githubusercontent.com/homarr-labs/charts/refs/heads/main/charts/homarr/icon.svg
Expand All @@ -21,12 +21,8 @@ annotations:
fingerprint: 36F9A886ABA6AA4C1588B942E7EC1AA0EFD54840
url: https://homarr-labs.github.io/charts/pgp_keys.asc
artifacthub.io/changes: |-
- kind: changed
description: remove Mysql bitnami dependency
- kind: added
description: add Postgresql support
- kind: added
description: add LOG_LEVEL, NO_EXTERNAL_CONNECTION and ENABLE_DNS_CACHING env variables
- kind: fixed
description: remove unused mysql values
artifacthub.io/links: |-
- name: App Source
url: https://github.com/homarr-labs/homarr
Expand Down
15 changes: 3 additions & 12 deletions charts/homarr/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<img src="https://raw.githubusercontent.com/homarr-labs/charts/refs/heads/main/charts/homarr/icon.svg" align="right" width="92" alt="homarr logo">

![Version: 7.0.0](https://img.shields.io/badge/Version-7.0.0-informational?style=flat)
![Version: 7.1.0](https://img.shields.io/badge/Version-7.1.0-informational?style=flat)
![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat)
![AppVersion: v1.39.0](https://img.shields.io/badge/AppVersion-v1.39.0-informational?style=flat)

Expand Down Expand Up @@ -76,31 +76,23 @@ To avoid including sensitive information in plain text within your version contr

Below is an exhaustive list of all secrets:

<center>

| FEATURE | SECRET NAME | SECRET KEYS | Required |
| FEATURE | SECRET NAME | SECRET KEYS | Required |
|-----------|-------------------------|-----------------------------------------|-----------------------------------------------------------------------|
| OIDC | auth-oidc-secret | oidc-client-id<br>oidc-client-secret | No |
| LDAP | auth-ldap-secret | bind-password | No |
| DATABASE | db-secret | db-encryption-key<br>db-url | Depends (see Database section) at least db-encryption-key is required |

</center>

### Database

You have multiple options for configuring the database:

<center>

| DRIVER TYPE | Persistence mode |
|----------------|---------------------------------|
| better-sqlite3 | Pod disk |
| better-sqlite3 | homarr-database PVC |
| mysql2 | External MySql database |
| node-postgres | External Postgresql database |

</center>

#### Pod disk

No additional configuration is required. However, keep in mind that if the pod restarts, all data will be lost. This setup is not *recommended* for production use.
Expand Down Expand Up @@ -378,7 +370,7 @@ All available values are listed on the [artifacthub](https://artifacthub.io/pack
| autoscaling.targetCPUUtilizationPercentage | int | `80` | Target CPU utilization for autoscaling |
| containerPorts | object | `{"http":{"port":7575,"protocol":"TCP"}}` | containerPorts defines the ports to open on the container. It is a map where each entry specifies: - `port` (int) (required): The port number to expose inside the container. - `protocol` (string) (required): The network protocol (TCP or UDP) used for the port. - `disabled` (bool) : Optional flag to disable this port (defaults to false). Can be overridden via Helm values. By default, this configuration exposes TCP port 7575 with the name `http`. |
| database.migrationEnabled | bool | `true` | Database migration configuration. DB_MIGRATIONS_DISABLED Set to `true` to disable database migrations. Migrations are enabled by default (`false`). |
| database.type | string | `"sqlite"` | Database type: sqlite | mysql | postgresql |
| database.type | string | `"sqlite"` | Database type: sqlite, mysql or postgresql |
| env.AUTH_LDAP_BASE | string | `nil` | Base dn of your LDAP server |
| env.AUTH_LDAP_BIND_DN | string | `nil` | User used for finding users and groups |
| env.AUTH_LDAP_GROUP_CLASS | string | `"groupOfUniqueNames"` | Class used for querying groups |
Expand Down Expand Up @@ -432,7 +424,6 @@ All available values are listed on the [artifacthub](https://artifacthub.io/pack
| ingress.tls | list | `[]` | Ingress TLS configuration |
| livenessProbe.httpGet.path | string | `"/api/health/live"` | This is the liveness check endpoint used by Kubernetes to determine if the application is still running. |
| livenessProbe.httpGet.port | int | `7575` | The port on which the liveness check will be performed. This must be the same as the container port exposed by the application. |
| mysql | object | See [values.yaml](https://github.com/homarr-labs/charts/blob/dev/charts/homarr/values.yaml) | Enable and configure Mysql database subchart under this key. For more options see [Mysql chart documentation](https://github.com/bitnami/charts/tree/main/bitnami/mysql) |
| nameOverride | string | `""` | Overrides chart's name |
| nodeSelector | object | `{}` | Node selectors for pod scheduling |
| persistence.homarrDatabase.accessMode | string | `"ReadWriteOnce"` | homarr-database access mode |
Expand Down
9 changes: 1 addition & 8 deletions charts/homarr/README_CONFIG.md.gotmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,31 +15,24 @@ To avoid including sensitive information in plain text within your version contr

Below is an exhaustive list of all secrets:

<center>

| FEATURE | SECRET NAME | SECRET KEYS | Required |
| FEATURE | SECRET NAME | SECRET KEYS | Required |
|-----------|-------------------------|-----------------------------------------|-----------------------------------------------------------------------|
| OIDC | auth-oidc-secret | oidc-client-id<br>oidc-client-secret | No |
| LDAP | auth-ldap-secret | bind-password | No |
| DATABASE | db-secret | db-encryption-key<br>db-url | Depends (see Database section) at least db-encryption-key is required |

</center>

### Database

You have multiple options for configuring the database:

<center>

| DRIVER TYPE | Persistence mode |
|----------------|---------------------------------|
| better-sqlite3 | Pod disk |
| better-sqlite3 | homarr-database PVC |
| mysql2 | External MySql database |
| node-postgres | External Postgresql database |

</center>

#### Pod disk

No additional configuration is required. However, keep in mind that if the pod restarts, all data will be lost. This setup is not *recommended* for production use.
Expand Down
9 changes: 0 additions & 9 deletions charts/homarr/templates/homarr-dc.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,15 +35,6 @@ spec:
securityContext:
{{- toYaml .Values.podSecurityContext | nindent 8 }}

initContainers:
{{- if .Values.mysql.internal }}
- name: wait-for-mysql
image: busybox
command: [ 'sh', '-c', 'until nc -z -v -w30 $DB_HOST 3306; do echo "Waiting for MySQL..."; sleep 5; done;' ]
env:
- name: DB_HOST
value: homarr-mysql
{{- end }}
containers:
- name: {{ .Chart.Name }}
securityContext:
Expand Down
12 changes: 1 addition & 11 deletions charts/homarr/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ env:
AUTH_OIDC_NAME_ATTRIBUTE_OVERWRITE:

database:
# -- Database type: sqlite | mysql | postgresql
# -- Database type: sqlite, mysql or postgresql
type: sqlite
# -- Database migration configuration.
# DB_MIGRATIONS_DISABLED Set to `true` to disable database migrations.
Expand Down Expand Up @@ -329,16 +329,6 @@ tolerations: []
# -- Node affinity for pod scheduling
affinity: {}

# -- Enable and configure Mysql database subchart under this key.
# For more options see [Mysql chart documentation](https://github.com/bitnami/charts/tree/main/bitnami/mysql)
# @default -- See [values.yaml](https://github.com/homarr-labs/charts/blob/dev/charts/homarr/values.yaml)
mysql:
internal: false
auth:
existingSecret: "db-secret"
username: homarr
database: homarrdb

# -- Enable RBAC resources for Kubernetes integration
# Creates Role, ClusterRole, and associated bindings for Homarr's Kubernetes features
rbac:
Expand Down