Improve setup exception handling in ruckus_unleashed#168014
Open
lanrat wants to merge 1 commit intohome-assistant:devfrom
Open
Improve setup exception handling in ruckus_unleashed#168014lanrat wants to merge 1 commit intohome-assistant:devfrom
lanrat wants to merge 1 commit intohome-assistant:devfrom
Conversation
Wrap post-login API calls (first refresh, system info, AP list) in try-except to catch ConnectionError/SchemaError and re-raise as ConfigEntryNotReady.
home-assistant
bot
added
cla-signed
code-quality
integration: ruckus_unleashed
small-pr
|
Hey there @ms264556, @gabe565, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
21 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Improves ruckus_unleashed config entry setup resiliency by converting post-login connection/schema failures during initial API calls into ConfigEntryNotReady so Home Assistant can retry setup cleanly.
Changes:
- Wrapes initial refresh +
get_system_info()+get_aps()in atry/exceptthat converts connection/schema errors intoConfigEntryNotReady. - Closes the Ruckus client on these failures to avoid leaving resources open.
erwindouna
suggested changes
Apr 12, 2026
| system_info = await ruckus.api.get_system_info() | ||
| system_info = await ruckus.api.get_system_info() | ||
| aps = await ruckus.api.get_aps() | ||
| except (ConnectionError, SchemaError) as err: |
Contributor
There was a problem hiding this comment.
Do we have tests to support these exceptions?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Wrap post-login API calls (first refresh, system info, AP list) in try-except to catch ConnectionError/SchemaError and re-raise as ConfigEntryNotReady.
Addresses: #164706 (comment)
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: